Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-13 Thread Zeng, Star 
Good finding.
The typo has been fixed in local.
Thanks very much.

Star
-Original Message-
From: Wu, Hao A 
Sent: Tuesday, March 13, 2018 8:56 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Ni, Ruiyu 
Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after 
supporting IOMMU

> -Original Message-
> From: Zeng, Star
> Sent: Monday, March 12, 2018 11:37 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Ni, Ruiyu; Zeng, Star
> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3:
> Enhancements after supporting IOMMU
> 
> I have handled the mistake at
> https://github.com/lzeng14/edk2/tree/DebugCommUsb3AfterIOMMUV2_WIP.
> 
> If you need, I can resend V2 patch. :)

Another comment for patch 2, also within function Usb3PciIoNotify():
if (Usb3GetIoMmu != NULL) {
^^^
should be:
if (Usb3GetIoMmu () != NULL) {

With that typo fixed, the 2nd commit on the above link seems good to me.
And for the series,
Reviewed-by: Hao Wu 

Best Regards,
Hao Wu

> 
> Thanks,
> Star
> -Original Message-
> From: Zeng, Star
> Sent: Monday, March 12, 2018 10:28 AM
> To: Wu, Hao A ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Ni, Ruiyu 
> ; Zeng, Star 
> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3:
> Enhancements after supporting IOMMU
> 
> Hao,
> 
> Good catch. :)
> It is a mistake when splitting patch.
> 
> 
> Thanks,
> Star
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, March 12, 2018 10:10 AM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Ni, Ruiyu 
> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3:
> Enhancements after supporting IOMMU
> 
> One minor comment:
> For patch 3, within changes in function Usb3PciIoNotify():
> 
> Usb3NamedEventListen (
>   ,
>   TPL_NOTIFY,
>   Usb3DxeSmmReadyToLockNotify,
> <---  Does this change related with patch 2?
>   );
> 
> Otherwise, for me, patch 2 is storing the event for 
> DxeSmmReadyToLockProtocol in an event which will be closed right after.
> 
> 
> Best Regards,
> Hao Wu
> 
> 
> > -Original Message-
> > From: Zeng, Star
> > Sent: Sunday, March 11, 2018 11:16 PM
> > To: edk2-devel@lists.01.org
> > Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A
> > Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements 
> > after supporting IOMMU
> >
> > Please get detailed information in the separated patches.
> >
> > Cc: Jiewen Yao 
> > Cc: Ruiyu Ni 
> > Cc: Hao Wu 
> >
> > Star Zeng (3):
> >   SourceLevelDebugPkg DebugCommUsb3: Refine some formats
> >   SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer
> >   SourceLevelDebugPkg DebugCommUsb3: Use the Handle from
> DebugAgentLib
> >
> >  .../DebugCommunicationLibUsb3Common.c  |  96 +-
> >  .../DebugCommunicationLibUsb3Dxe.c | 365 
> > -
> >  .../DebugCommunicationLibUsb3Dxe.inf   |  11 +-
> >  .../DebugCommunicationLibUsb3Internal.h|  60 +---
> >  .../DebugCommunicationLibUsb3Pei.c |  50 ++-
> >  .../DebugCommunicationLibUsb3Pei.inf   |   4 +-
> >  6 files changed, 332 insertions(+), 254 deletions(-)
> >
> > --
> > 2.13.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-13 Thread Wu, Hao A 
> -Original Message-
> From: Zeng, Star
> Sent: Monday, March 12, 2018 11:37 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Ni, Ruiyu; Zeng, Star
> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3:
> Enhancements after supporting IOMMU
> 
> I have handled the mistake at
> https://github.com/lzeng14/edk2/tree/DebugCommUsb3AfterIOMMUV2_WIP.
> 
> If you need, I can resend V2 patch. :)

Another comment for patch 2, also within function Usb3PciIoNotify():
if (Usb3GetIoMmu != NULL) {
^^^
should be:
if (Usb3GetIoMmu () != NULL) {

With that typo fixed, the 2nd commit on the above link seems good to me.
And for the series,
Reviewed-by: Hao Wu 

Best Regards,
Hao Wu

> 
> Thanks,
> Star
> -Original Message-
> From: Zeng, Star
> Sent: Monday, March 12, 2018 10:28 AM
> To: Wu, Hao A ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Ni, Ruiyu ; Zeng,
> Star 
> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3:
> Enhancements after supporting IOMMU
> 
> Hao,
> 
> Good catch. :)
> It is a mistake when splitting patch.
> 
> 
> Thanks,
> Star
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, March 12, 2018 10:10 AM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Ni, Ruiyu 
> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3:
> Enhancements after supporting IOMMU
> 
> One minor comment:
> For patch 3, within changes in function Usb3PciIoNotify():
> 
> Usb3NamedEventListen (
>   ,
>   TPL_NOTIFY,
>   Usb3DxeSmmReadyToLockNotify,
> <---  Does this change related with patch 2?
>   );
> 
> Otherwise, for me, patch 2 is storing the event for
> DxeSmmReadyToLockProtocol in an event which will be closed right after.
> 
> 
> Best Regards,
> Hao Wu
> 
> 
> > -Original Message-
> > From: Zeng, Star
> > Sent: Sunday, March 11, 2018 11:16 PM
> > To: edk2-devel@lists.01.org
> > Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A
> > Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements
> > after supporting IOMMU
> >
> > Please get detailed information in the separated patches.
> >
> > Cc: Jiewen Yao 
> > Cc: Ruiyu Ni 
> > Cc: Hao Wu 
> >
> > Star Zeng (3):
> >   SourceLevelDebugPkg DebugCommUsb3: Refine some formats
> >   SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer
> >   SourceLevelDebugPkg DebugCommUsb3: Use the Handle from
> DebugAgentLib
> >
> >  .../DebugCommunicationLibUsb3Common.c  |  96 +-
> >  .../DebugCommunicationLibUsb3Dxe.c | 365 
> > -
> >  .../DebugCommunicationLibUsb3Dxe.inf   |  11 +-
> >  .../DebugCommunicationLibUsb3Internal.h|  60 +---
> >  .../DebugCommunicationLibUsb3Pei.c |  50 ++-
> >  .../DebugCommunicationLibUsb3Pei.inf   |   4 +-
> >  6 files changed, 332 insertions(+), 254 deletions(-)
> >
> > --
> > 2.13.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-11 Thread Zeng, Star 
I have handled the mistake at 
https://github.com/lzeng14/edk2/tree/DebugCommUsb3AfterIOMMUV2_WIP.

If you need, I can resend V2 patch. :)

Thanks,
Star
-Original Message-
From: Zeng, Star 
Sent: Monday, March 12, 2018 10:28 AM
To: Wu, Hao A ; edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Ni, Ruiyu ; Zeng, 
Star 
Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after 
supporting IOMMU

Hao,

Good catch. :)
It is a mistake when splitting patch.


Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Monday, March 12, 2018 10:10 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Ni, Ruiyu 
Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after 
supporting IOMMU

One minor comment:
For patch 3, within changes in function Usb3PciIoNotify():

Usb3NamedEventListen (
  ,
  TPL_NOTIFY,
  Usb3DxeSmmReadyToLockNotify,
<---  Does this change related with patch 2?
  );

Otherwise, for me, patch 2 is storing the event for DxeSmmReadyToLockProtocol 
in an event which will be closed right after.


Best Regards,
Hao Wu


> -Original Message-
> From: Zeng, Star
> Sent: Sunday, March 11, 2018 11:16 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A
> Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements 
> after supporting IOMMU
> 
> Please get detailed information in the separated patches.
> 
> Cc: Jiewen Yao 
> Cc: Ruiyu Ni 
> Cc: Hao Wu 
> 
> Star Zeng (3):
>   SourceLevelDebugPkg DebugCommUsb3: Refine some formats
>   SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer
>   SourceLevelDebugPkg DebugCommUsb3: Use the Handle from DebugAgentLib
> 
>  .../DebugCommunicationLibUsb3Common.c  |  96 +-
>  .../DebugCommunicationLibUsb3Dxe.c | 365 
> -
>  .../DebugCommunicationLibUsb3Dxe.inf   |  11 +-
>  .../DebugCommunicationLibUsb3Internal.h|  60 +---
>  .../DebugCommunicationLibUsb3Pei.c |  50 ++-
>  .../DebugCommunicationLibUsb3Pei.inf   |   4 +-
>  6 files changed, 332 insertions(+), 254 deletions(-)
> 
> --
> 2.13.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-11 Thread Zeng, Star 
Hao,

Good catch. :)
It is a mistake when splitting patch.


Thanks,
Star
-Original Message-
From: Wu, Hao A 
Sent: Monday, March 12, 2018 10:10 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Ni, Ruiyu 
Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after 
supporting IOMMU

One minor comment:
For patch 3, within changes in function Usb3PciIoNotify():

Usb3NamedEventListen (
  ,
  TPL_NOTIFY,
  Usb3DxeSmmReadyToLockNotify,
<---  Does this change related with patch 2?
  );

Otherwise, for me, patch 2 is storing the event for DxeSmmReadyToLockProtocol 
in an event which will be closed right after.


Best Regards,
Hao Wu


> -Original Message-
> From: Zeng, Star
> Sent: Sunday, March 11, 2018 11:16 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A
> Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements 
> after supporting IOMMU
> 
> Please get detailed information in the separated patches.
> 
> Cc: Jiewen Yao 
> Cc: Ruiyu Ni 
> Cc: Hao Wu 
> 
> Star Zeng (3):
>   SourceLevelDebugPkg DebugCommUsb3: Refine some formats
>   SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer
>   SourceLevelDebugPkg DebugCommUsb3: Use the Handle from DebugAgentLib
> 
>  .../DebugCommunicationLibUsb3Common.c  |  96 +-
>  .../DebugCommunicationLibUsb3Dxe.c | 365 
> -
>  .../DebugCommunicationLibUsb3Dxe.inf   |  11 +-
>  .../DebugCommunicationLibUsb3Internal.h|  60 +---
>  .../DebugCommunicationLibUsb3Pei.c |  50 ++-
>  .../DebugCommunicationLibUsb3Pei.inf   |   4 +-
>  6 files changed, 332 insertions(+), 254 deletions(-)
> 
> --
> 2.13.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-11 Thread Wu, Hao A 
One minor comment:
For patch 3, within changes in function Usb3PciIoNotify():

Usb3NamedEventListen (
  ,
  TPL_NOTIFY,
  Usb3DxeSmmReadyToLockNotify,
<---  Does this change related with patch 2?
  );

Otherwise, for me, patch 2 is storing the event for
DxeSmmReadyToLockProtocol in an event which will be closed right after.


Best Regards,
Hao Wu


> -Original Message-
> From: Zeng, Star
> Sent: Sunday, March 11, 2018 11:16 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A
> Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements
> after supporting IOMMU
> 
> Please get detailed information in the separated patches.
> 
> Cc: Jiewen Yao 
> Cc: Ruiyu Ni 
> Cc: Hao Wu 
> 
> Star Zeng (3):
>   SourceLevelDebugPkg DebugCommUsb3: Refine some formats
>   SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer
>   SourceLevelDebugPkg DebugCommUsb3: Use the Handle from DebugAgentLib
> 
>  .../DebugCommunicationLibUsb3Common.c  |  96 +-
>  .../DebugCommunicationLibUsb3Dxe.c | 365 
> -
>  .../DebugCommunicationLibUsb3Dxe.inf   |  11 +-
>  .../DebugCommunicationLibUsb3Internal.h|  60 +---
>  .../DebugCommunicationLibUsb3Pei.c |  50 ++-
>  .../DebugCommunicationLibUsb3Pei.inf   |   4 +-
>  6 files changed, 332 insertions(+), 254 deletions(-)
> 
> --
> 2.13.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-11 Thread Star Zeng 
Please get detailed information in the separated patches.

Cc: Jiewen Yao 
Cc: Ruiyu Ni 
Cc: Hao Wu 

Star Zeng (3):
  SourceLevelDebugPkg DebugCommUsb3: Refine some formats
  SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer
  SourceLevelDebugPkg DebugCommUsb3: Use the Handle from DebugAgentLib

 .../DebugCommunicationLibUsb3Common.c  |  96 +-
 .../DebugCommunicationLibUsb3Dxe.c | 365 -
 .../DebugCommunicationLibUsb3Dxe.inf   |  11 +-
 .../DebugCommunicationLibUsb3Internal.h|  60 +---
 .../DebugCommunicationLibUsb3Pei.c |  50 ++-
 .../DebugCommunicationLibUsb3Pei.inf   |   4 +-
 6 files changed, 332 insertions(+), 254 deletions(-)

--
2.13.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel