Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-23 Thread Gao, Liming
eu...@linaro.org>; Justen, Jordan L >> <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Gao, Liming >> <liming@intel.com> >> Subject: Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when >> compiled with GCC5 >> >> On 02/21/17 18:53, Anthony

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-23 Thread Anthony PERARD
On Thu, Feb 23, 2017 at 11:19:03AM +0100, Laszlo Ersek wrote: > On 02/22/17 09:54, Gao, Liming wrote: > > Laszlo: > > In edk2, I find the several functions with VA_LIST have no EFIAPI. > > They may use VA_ARG() or call other functions, but they don't use > > VA_COPY(). In Base.h, VA_ARG() is

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-23 Thread Laszlo Ersek
sts.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, February 22, 2017 3:03 AM >> To: Anthony PERARD <anthony.per...@citrix.com> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Justen, Jordan L >> <jordan.l.jus...@intel.com>; edk2-de...@ml01

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-22 Thread Gao, Liming
Jordan: If enable -mabi=ms, EFIAPI and ms_var_list will not be required to be defined, right? Do you verify it on X64 arch? Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, February 22, 2017 8:00 AM >To: Justen, Jordan L

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-22 Thread Gao, Liming
usten, Jordan L ><jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Gao, Liming ><liming....@intel.com> >Subject: Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when >compiled with GCC5 > >On 02/21/17 18:53, Anthony PERARD wrote: >> On Tue, Feb 21, 201

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-21 Thread Laszlo Ersek
On 02/21/17 23:45, Jordan Justen wrote: > On 2017-02-21 11:08:24, Rebecca Cran wrote: >> On 2/21/2017 12:02 PM, Laszlo Ersek wrote: >> >>> But in this case, the full edk2 codebase has to be grepped for >>> VA_LIST-taking functions, and all of them must be flipped to EFIAPI, if >>> they currently

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-21 Thread Jordan Justen
On 2017-02-21 11:08:24, Rebecca Cran wrote: > On 2/21/2017 12:02 PM, Laszlo Ersek wrote: > > > But in this case, the full edk2 codebase has to be grepped for > > VA_LIST-taking functions, and all of them must be flipped to EFIAPI, if > > they currently aren't EFIAPI. Covering just

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-21 Thread Rebecca Cran
On 2/21/2017 12:02 PM, Laszlo Ersek wrote: But in this case, the full edk2 codebase has to be grepped for VA_LIST-taking functions, and all of them must be flipped to EFIAPI, if they currently aren't EFIAPI. Covering just XenStoreVSPrint() seems incomplete. (Note: CryptoPkg/Library/OpensslLib

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-21 Thread Laszlo Ersek
On 02/21/17 18:53, Anthony PERARD wrote: > On Tue, Feb 21, 2017 at 06:07:15PM +0100, Laszlo Ersek wrote: >> CC Rebecca & Konrad >> >> On 02/21/17 17:39, Anthony PERARD wrote: [snip] >>> So, should I add EFIAPI to XenStoreVSPrint, as it is using VA_COPY? >>> >> >> Hm, please help me jog my

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-21 Thread Anthony PERARD
On Tue, Feb 21, 2017 at 06:07:15PM +0100, Laszlo Ersek wrote: > CC Rebecca & Konrad > > On 02/21/17 17:39, Anthony PERARD wrote: > > On Sat, Dec 03, 2016 at 06:59:28PM +0100, Laszlo Ersek wrote: > >> On 12/02/16 20:26, Laszlo Ersek wrote: > >>> On 12/02/16 17:02, Anthony PERARD wrote: > On

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-21 Thread Laszlo Ersek
CC Rebecca & Konrad On 02/21/17 17:39, Anthony PERARD wrote: > On Sat, Dec 03, 2016 at 06:59:28PM +0100, Laszlo Ersek wrote: >> On 12/02/16 20:26, Laszlo Ersek wrote: >>> On 12/02/16 17:02, Anthony PERARD wrote: On Thu, Dec 01, 2016 at 07:43:24PM +0100, Laszlo Ersek wrote: > On 12/01/16

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2017-02-21 Thread Anthony PERARD
On Sat, Dec 03, 2016 at 06:59:28PM +0100, Laszlo Ersek wrote: > On 12/02/16 20:26, Laszlo Ersek wrote: > > On 12/02/16 17:02, Anthony PERARD wrote: > >> On Thu, Dec 01, 2016 at 07:43:24PM +0100, Laszlo Ersek wrote: > >>> On 12/01/16 16:28, Anthony PERARD wrote: > Hi, > > That might

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-05 Thread Laszlo Ersek
mber 04, 2016 1:59 AM > To: Anthony PERARD <anthony.per...@citrix.com> > Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; > Gao, Liming <liming....@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> > Subject: Re: [edk2] [PATCH 0/

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-04 Thread Gao, Liming
, 2016 1:59 AM To: Anthony PERARD <anthony.per...@citrix.com> Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Gao, Liming <liming@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-03 Thread Laszlo Ersek
On 12/02/16 20:26, Laszlo Ersek wrote: > On 12/02/16 17:02, Anthony PERARD wrote: >> On Thu, Dec 01, 2016 at 07:43:24PM +0100, Laszlo Ersek wrote: >>> On 12/01/16 16:28, Anthony PERARD wrote: Hi, That might be only with the Xen part of OVMF but now that the GCC5 toolchains is

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-02 Thread Laszlo Ersek
On 12/02/16 17:02, Anthony PERARD wrote: > On Thu, Dec 01, 2016 at 07:43:24PM +0100, Laszlo Ersek wrote: >> On 12/01/16 16:28, Anthony PERARD wrote: >>> Hi, >>> >>> That might be only with the Xen part of OVMF but now that the GCC5 >>> toolchains is used with my gcc (6.2.1 20160830, Arch Linux),

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-02 Thread Anthony PERARD
On Thu, Dec 01, 2016 at 07:43:24PM +0100, Laszlo Ersek wrote: > On 12/01/16 16:28, Anthony PERARD wrote: > > Hi, > > > > That might be only with the Xen part of OVMF but now that the GCC5 > > toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail > > to boot in Xen guests. > >

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-02 Thread Laszlo Ersek
com>; Gao, Liming <liming@intel.com>; Zhu, > Yonghong <yonghong@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: edk2-de...@ml01.01.org > Subject: Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled > with GCC5 > > On 12/01/16 16

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-02 Thread Laszlo Ersek
On 12/02/16 01:58, Jordan Justen wrote: > On 2016-12-01 12:54:34, Laszlo Ersek wrote: >> On 12/01/16 21:06, Jordan Justen wrote: >>> On 2016-12-01 10:43:24, Laszlo Ersek wrote: Hrpmf, wait a second, I do see something interesting: in this series you *are* modifying APIs declared in a

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-01 Thread Gao, Liming
To: Anthony PERARD <anthony.per...@citrix.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: edk2-de...@ml01.01.org Subject: Re: [edk2]

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-01 Thread Jordan Justen
On 2016-12-01 12:54:34, Laszlo Ersek wrote: > On 12/01/16 21:06, Jordan Justen wrote: > > On 2016-12-01 10:43:24, Laszlo Ersek wrote: > >> Hrpmf, wait a second, I do see something interesting: in this series you > >> *are* modifying APIs declared in a library class header (namely > >>

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-01 Thread Laszlo Ersek
On 12/01/16 21:06, Jordan Justen wrote: > On 2016-12-01 10:43:24, Laszlo Ersek wrote: >> On 12/01/16 16:28, Anthony PERARD wrote: >>> Hi, >>> >>> That might be only with the Xen part of OVMF but now that the GCC5 >>> toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail >>> to

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-01 Thread Jordan Justen
On 2016-12-01 10:43:24, Laszlo Ersek wrote: > On 12/01/16 16:28, Anthony PERARD wrote: > > Hi, > > > > That might be only with the Xen part of OVMF but now that the GCC5 > > toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail > > to boot in Xen guests. > > > > Here is the

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-01 Thread Laszlo Ersek
On 12/01/16 16:28, Anthony PERARD wrote: > Hi, > > That might be only with the Xen part of OVMF but now that the GCC5 > toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail > to boot in Xen guests. > > Here is the result: > X64 Exception Type - 06(#UD - Invalid Opcode)

[edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-01 Thread Anthony PERARD
Hi, That might be only with the Xen part of OVMF but now that the GCC5 toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail to boot in Xen guests. Here is the result: X64 Exception Type - 06(#UD - Invalid Opcode) CPU Apic ID - RIP - 1F26AF6B, CS -