Re: [edk2] [PATCH 13/26] MdeModulePkg UsbBotPei: Remove redundant functions
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 13/26] MdeModulePkg UsbBotPei: Remove redundant functions
The functions that are never called have been removed.
They are PeiUsbSetConfiguration,PeiUsbSetDeviceAddress,
IsPortConnect,IsPortConnectChange,IsPortLowSpeedDeviceAttached
and PeiUsbGetDescriptor.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 190 -
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 98 ---
2 files changed, 288 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
index 4f20c71144..cd765c40c5 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
@@ -17,92 +17,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
EXPRESS OR IMPLIED.
#include "UsbPeim.h"
#include "PeiUsbLib.h"
-/**
- Get a given usb descriptor.
-
- @param PeiServicesGeneral-purpose services that are available to
every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param Value Request Value.
- @param Index Request Index.
- @param DescriptorLength Request descriptor Length.
- @param Descriptor Request descriptor.
-
-
- @retval EFI_SUCCESSUsb descriptor is obtained successfully.
- @retval EFI_DEVICE_ERROR Cannot get the usb descriptor due to a hardware
error.
- @retval Others Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbGetDescriptor (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN UINT16 Value,
- IN UINT16 Index,
- IN UINT16 DescriptorLength,
- OUT VOID *Descriptor
- )
-{
- EFI_USB_DEVICE_REQUEST DevReq;
-
- ASSERT (UsbIoPpi != NULL);
-
- DevReq.RequestType = USB_DEV_GET_DESCRIPTOR_REQ_TYPE;
- DevReq.Request = USB_DEV_GET_DESCRIPTOR;
- DevReq.Value= Value;
- DevReq.Index= Index;
- DevReq.Length = DescriptorLength;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- ,
- EfiUsbDataIn,
- PcdGet32 (PcdUsbTransferTimeoutValue),
- Descriptor,
- DescriptorLength
- );
-}
-
-/**
- Set a usb device with a specified address.
-
- @param PeiServicesGeneral-purpose services that are available to
every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param AddressValue The address to assign.
-
- @retval EFI_SUCCESSUsb device address is set successfully.
- @retval EFI_DEVICE_ERROR Cannot set the usb address due to a hardware
error.
- @retval Others Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetDeviceAddress (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN UINT16 AddressValue
- )
-{
- EFI_USB_DEVICE_REQUEST DevReq;
-
- ASSERT (UsbIoPpi != NULL);
-
- DevReq.RequestType = USB_DEV_SET_ADDRESS_REQ_TYPE;
- DevReq.Request = USB_DEV_SET_ADDRESS;
- DevReq.Value= AddressValue;
- DevReq.Index= 0;
- DevReq.Length = 0;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- ,
- EfiUsbNoData,
- PcdGet32 (PcdUsbTransferTimeoutValue),
- NULL,
- 0
- );
-}
/**
Clear a given usb feature.
@@ -161,40 +75,6 @@ PeiUsbClearDeviceFeature (
);
}
-/**
- Configure a usb device to Configuration 1.
-
- @param PeiServicesGeneral-purpose services that are available to
every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
-
- @retval EFI_SUCCESS Usb device is set to use Configuration 1
successfully.
- @retval EFI_DEVICE_ERROR Cannot set the usb device due to a hardware error.
- @retval OthersOther failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetConfiguration (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi
- )
-{
- EFI_USB_DEVICE_REQUEST DevReq;
- ZeroMem (, sizeof (EFI_USB_DEVICE_REQUEST));
-
- DevReq.RequestType = USB_DEV_SET_CONFIGURATION_REQ_TYPE;
- DevReq.Request = USB_DEV_SET_CONFIGURATION;
- DevReq.Value= 1;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- ,
-
[edk2] [PATCH 13/26] MdeModulePkg UsbBotPei: Remove redundant functions
The functions that are never called have been removed.
They are PeiUsbSetConfiguration,PeiUsbSetDeviceAddress,
IsPortConnect,IsPortConnectChange,IsPortLowSpeedDeviceAttached
and PeiUsbGetDescriptor.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 190 -
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 98 ---
2 files changed, 288 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
index 4f20c71144..cd765c40c5 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
@@ -17,92 +17,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
EXPRESS OR IMPLIED.
#include "UsbPeim.h"
#include "PeiUsbLib.h"
-/**
- Get a given usb descriptor.
-
- @param PeiServicesGeneral-purpose services that are available to
every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param Value Request Value.
- @param Index Request Index.
- @param DescriptorLength Request descriptor Length.
- @param Descriptor Request descriptor.
-
-
- @retval EFI_SUCCESSUsb descriptor is obtained successfully.
- @retval EFI_DEVICE_ERROR Cannot get the usb descriptor due to a hardware
error.
- @retval Others Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbGetDescriptor (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN UINT16 Value,
- IN UINT16 Index,
- IN UINT16 DescriptorLength,
- OUT VOID *Descriptor
- )
-{
- EFI_USB_DEVICE_REQUEST DevReq;
-
- ASSERT (UsbIoPpi != NULL);
-
- DevReq.RequestType = USB_DEV_GET_DESCRIPTOR_REQ_TYPE;
- DevReq.Request = USB_DEV_GET_DESCRIPTOR;
- DevReq.Value= Value;
- DevReq.Index= Index;
- DevReq.Length = DescriptorLength;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- ,
- EfiUsbDataIn,
- PcdGet32 (PcdUsbTransferTimeoutValue),
- Descriptor,
- DescriptorLength
- );
-}
-
-/**
- Set a usb device with a specified address.
-
- @param PeiServicesGeneral-purpose services that are available to
every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
- @param AddressValue The address to assign.
-
- @retval EFI_SUCCESSUsb device address is set successfully.
- @retval EFI_DEVICE_ERROR Cannot set the usb address due to a hardware
error.
- @retval Others Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetDeviceAddress (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi,
- IN UINT16 AddressValue
- )
-{
- EFI_USB_DEVICE_REQUEST DevReq;
-
- ASSERT (UsbIoPpi != NULL);
-
- DevReq.RequestType = USB_DEV_SET_ADDRESS_REQ_TYPE;
- DevReq.Request = USB_DEV_SET_ADDRESS;
- DevReq.Value= AddressValue;
- DevReq.Index= 0;
- DevReq.Length = 0;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- ,
- EfiUsbNoData,
- PcdGet32 (PcdUsbTransferTimeoutValue),
- NULL,
- 0
- );
-}
/**
Clear a given usb feature.
@@ -161,40 +75,6 @@ PeiUsbClearDeviceFeature (
);
}
-/**
- Configure a usb device to Configuration 1.
-
- @param PeiServicesGeneral-purpose services that are available to
every PEIM.
- @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance.
-
- @retval EFI_SUCCESS Usb device is set to use Configuration 1
successfully.
- @retval EFI_DEVICE_ERROR Cannot set the usb device due to a hardware error.
- @retval OthersOther failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetConfiguration (
- IN EFI_PEI_SERVICES **PeiServices,
- IN PEI_USB_IO_PPI *UsbIoPpi
- )
-{
- EFI_USB_DEVICE_REQUEST DevReq;
- ZeroMem (, sizeof (EFI_USB_DEVICE_REQUEST));
-
- DevReq.RequestType = USB_DEV_SET_CONFIGURATION_REQ_TYPE;
- DevReq.Request = USB_DEV_SET_CONFIGURATION;
- DevReq.Value= 1;
-
- return UsbIoPpi->UsbControlTransfer (
- PeiServices,
- UsbIoPpi,
- ,
- EfiUsbNoData,
- PcdGet32 (PcdUsbTransferTimeoutValue),
- NULL,
- 0
- );
-}
/**
Clear Endpoint Halt.
@@ -258,74 +138,4 @@ PeiUsbClearEndpointHalt (
return
