Re: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a redundant function
I agree with Hao.
And there is a typo in commit log. 'calld' should be 'called'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, August 10, 2018 10:58 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a redundant
function
One minor comment:
Please help to remove the comment that mentioned 'SdPeimUnlinkMemBlock'
within function SdPeimFreeMemPool().
For me,
//
// Unlink all the memory blocks from the pool, then free them.
//
will be fine.
With that change,
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Wednesday, August 08, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Zeng, Star
> Subject: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a
> redundant function
>
> The function SdPeimUnlinkMemBlock that is never calld has been
> removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 24
> --
> 1 file changed, 24 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> index 24ad3dc6c2..0c3a424e3b 100644
> --- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> +++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> @@ -219,31 +219,7 @@ SdPeimIsMemBlockEmpty (
>return TRUE;
> }
>
> -/**
> - Unlink the memory block from the pool's list.
> -
> - @param Head The block list head of the memory's pool.
> - @param BlockToUnlink The memory block to unlink.
>
> -**/
> -VOID
> -SdPeimUnlinkMemBlock (
> - IN SD_PEIM_MEM_BLOCK *Head,
> - IN SD_PEIM_MEM_BLOCK *BlockToUnlink
> - )
> -{
> - SD_PEIM_MEM_BLOCK *Block;
> -
> - ASSERT ((Head != NULL) && (BlockToUnlink != NULL));
> -
> - for (Block = Head; Block != NULL; Block = Block->Next) {
> -if (Block->Next == BlockToUnlink) {
> - Block->Next = BlockToUnlink->Next;
> - BlockToUnlink->Next = NULL;
> - break;
> -}
> - }
> -}
>
> /**
>Initialize the memory management pool for the host controller.
> --
> 2.18.0.windows.1
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a redundant function
One minor comment:
Please help to remove the comment that mentioned 'SdPeimUnlinkMemBlock'
within function SdPeimFreeMemPool().
For me,
//
// Unlink all the memory blocks from the pool, then free them.
//
will be fine.
With that change,
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Wednesday, August 08, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Zeng, Star
> Subject: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a
> redundant function
>
> The function SdPeimUnlinkMemBlock that is never calld
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 24 --
> 1 file changed, 24 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> index 24ad3dc6c2..0c3a424e3b 100644
> --- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> +++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
> @@ -219,31 +219,7 @@ SdPeimIsMemBlockEmpty (
>return TRUE;
> }
>
> -/**
> - Unlink the memory block from the pool's list.
> -
> - @param Head The block list head of the memory's pool.
> - @param BlockToUnlink The memory block to unlink.
>
> -**/
> -VOID
> -SdPeimUnlinkMemBlock (
> - IN SD_PEIM_MEM_BLOCK *Head,
> - IN SD_PEIM_MEM_BLOCK *BlockToUnlink
> - )
> -{
> - SD_PEIM_MEM_BLOCK *Block;
> -
> - ASSERT ((Head != NULL) && (BlockToUnlink != NULL));
> -
> - for (Block = Head; Block != NULL; Block = Block->Next) {
> -if (Block->Next == BlockToUnlink) {
> - Block->Next = BlockToUnlink->Next;
> - BlockToUnlink->Next = NULL;
> - break;
> -}
> - }
> -}
>
> /**
>Initialize the memory management pool for the host controller.
> --
> 2.18.0.windows.1
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a redundant function
The function SdPeimUnlinkMemBlock that is never calld
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 24 --
1 file changed, 24 deletions(-)
diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
index 24ad3dc6c2..0c3a424e3b 100644
--- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
+++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
@@ -219,31 +219,7 @@ SdPeimIsMemBlockEmpty (
return TRUE;
}
-/**
- Unlink the memory block from the pool's list.
-
- @param Head The block list head of the memory's pool.
- @param BlockToUnlink The memory block to unlink.
-**/
-VOID
-SdPeimUnlinkMemBlock (
- IN SD_PEIM_MEM_BLOCK *Head,
- IN SD_PEIM_MEM_BLOCK *BlockToUnlink
- )
-{
- SD_PEIM_MEM_BLOCK *Block;
-
- ASSERT ((Head != NULL) && (BlockToUnlink != NULL));
-
- for (Block = Head; Block != NULL; Block = Block->Next) {
-if (Block->Next == BlockToUnlink) {
- Block->Next = BlockToUnlink->Next;
- BlockToUnlink->Next = NULL;
- break;
-}
- }
-}
/**
Initialize the memory management pool for the host controller.
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
