Re: [edk2] [PATCH 23/37] Nt32Pkg: Removing ipf which is no longer supported from edk2.

2018-06-13 Thread Wu, Hao A
Reviewed-by: Hao Wu 

Best Regards,
Hao Wu

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> chenc2
> Sent: Wednesday, June 13, 2018 11:45 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Wu, Hao A; Kinney, Michael D
> Subject: [edk2] [PATCH 23/37] Nt32Pkg: Removing ipf which is no longer
> supported from edk2.
> 
> Removing rules for Ipf sources file:
> * Remove the source file which path with "ipf" and also listed in
>   [Sources.IPF] section of INF file.
> * Remove the source file which listed in [Components.IPF] section
>   of DSC file and not listed in any other [Components] section.
> * Remove the embedded Ipf code for MDE_CPU_IPF.
> 
> Removing rules for Inf file:
> * Remove IPF from VALID_ARCHITECTURES comments.
> * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section.
> * Remove the INF which only listed in [Components.IPF] section in DSC.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> * Remove any IPF sepcific sections.
> 
> Removing rules for Dec file:
> * Remove [Includes.IPF] section from Dec.
> 
> Removing rules for Dsc file:
> * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC.
> * Remove any IPF specific sections.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> 
> Cc: Ruiyu Ni 
> Cc: Hao Wu 
> Cc: Michael D Kinney 
> Signed-off-by: chenc2 
> Contributed-under: TianoCore Contribution Agreement 1.1
> ---
>  Nt32Pkg/BootModePei/BootModePei.inf   | 4 
> ++--
>  .../DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusCodeLib.inf   |
> 2 +-
>  Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf   | 2 +-
>  Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf | 2 +-
>  Nt32Pkg/StallPei/StallPei.inf | 2 +-
>  Nt32Pkg/WinNtFirmwareVolumePei/WinNtFirmwareVolumePei.inf | 4
> ++--
>  Nt32Pkg/WinNtFlashMapPei/WinNtFlashMapPei.inf | 2 +-
>  7 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/Nt32Pkg/BootModePei/BootModePei.inf
> b/Nt32Pkg/BootModePei/BootModePei.inf
> index 43d6476734..0d3357b204 100644
> --- a/Nt32Pkg/BootModePei/BootModePei.inf
> +++ b/Nt32Pkg/BootModePei/BootModePei.inf
> @@ -26,7 +26,7 @@
>  #
>  # The following information is for reference only and not required by the 
> build
> tools.
>  #
> -#  VALID_ARCHITECTURES   = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES   = IA32 X64 EBC
>  #
> 
>  [Sources]
> @@ -47,4 +47,4 @@
>gEfiPeiBootInRecoveryModePpiGuid  # PPI SOMETIMES_PRODUCED
> 
>  [depex]
> -  TRUE
> \ No newline at end of file
> +  TRUE
> diff --git
> a/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusC
> odeLib.inf
> b/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusC
> odeLib.inf
> index 6d2a33b44d..5874ea651c 100644
> ---
> a/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusC
> odeLib.inf
> +++
> b/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusC
> odeLib.inf
> @@ -21,7 +21,7 @@
>FILE_GUID  = EF172A23-C7C5-47b7-B24E-D10DFE15540F
>MODULE_TYPE= DXE_DRIVER
>VERSION_STRING = 1.0
> -  LIBRARY_CLASS  = OemHookStatusCodeLib|DXE_DRIVER
> DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER
> UEFI_APPLICATION UEFI_DRIVER
> +  LIBRARY_CLASS  = OemHookStatusCodeLib|DXE_DRIVER
> DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
> 
>  #
>  # The following information is for reference only and not required by the 
> build
> tools.
> diff --git a/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> b/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> index a6891dd5f3..aef0ff421a 100644
> --- a/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> +++ b/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> @@ -23,7 +23,7 @@
>  #
>  # The following information is for reference only and not required by the 
> build
> tools.
>  #
> -#  VALID_ARCHITECTURES   = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES   = IA32 X64 EBC
>  #
> 
>  [Sources]
> diff --git a/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
> b/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
> index 70449015fa..4f421927ee 100644
> --- a/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
> +++ b/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
> @@ -26,7 +26,7 @@
>  #
>  # The following information is for reference only and not required by the 
> build
> tools.
>  #
> -#  VALID_ARC

[edk2] [PATCH 23/37] Nt32Pkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file:
* Remove the source file which path with "ipf" and also listed in
  [Sources.IPF] section of INF file.
* Remove the source file which listed in [Components.IPF] section
  of DSC file and not listed in any other [Components] section.
* Remove the embedded Ipf code for MDE_CPU_IPF.

Removing rules for Inf file:
* Remove IPF from VALID_ARCHITECTURES comments.
* Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section.
* Remove the INF which only listed in [Components.IPF] section in DSC.
* Remove statements from [BuildOptions] that provide IPF specific flags.
* Remove any IPF sepcific sections.

Removing rules for Dec file:
* Remove [Includes.IPF] section from Dec.

Removing rules for Dsc file:
* Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC.
* Remove any IPF specific sections.
* Remove statements from [BuildOptions] that provide IPF specific flags.

Cc: Ruiyu Ni 
Cc: Hao Wu 
Cc: Michael D Kinney 
Signed-off-by: chenc2 
Contributed-under: TianoCore Contribution Agreement 1.1
---
 Nt32Pkg/BootModePei/BootModePei.inf   | 4 ++--
 .../DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusCodeLib.inf   | 2 +-
 Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf   | 2 +-
 Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf | 2 +-
 Nt32Pkg/StallPei/StallPei.inf | 2 +-
 Nt32Pkg/WinNtFirmwareVolumePei/WinNtFirmwareVolumePei.inf | 4 ++--
 Nt32Pkg/WinNtFlashMapPei/WinNtFlashMapPei.inf | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Nt32Pkg/BootModePei/BootModePei.inf 
b/Nt32Pkg/BootModePei/BootModePei.inf
index 43d6476734..0d3357b204 100644
--- a/Nt32Pkg/BootModePei/BootModePei.inf
+++ b/Nt32Pkg/BootModePei/BootModePei.inf
@@ -26,7 +26,7 @@
 #
 # The following information is for reference only and not required by the 
build tools.
 #
-#  VALID_ARCHITECTURES   = IA32 X64 IPF EBC
+#  VALID_ARCHITECTURES   = IA32 X64 EBC
 #
 
 [Sources]
@@ -47,4 +47,4 @@
   gEfiPeiBootInRecoveryModePpiGuid  # PPI SOMETIMES_PRODUCED
 
 [depex]
-  TRUE
\ No newline at end of file
+  TRUE
diff --git 
a/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusCodeLib.inf 
b/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusCodeLib.inf
index 6d2a33b44d..5874ea651c 100644
--- 
a/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusCodeLib.inf
+++ 
b/Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/DxeNt32OemHookStatusCodeLib.inf
@@ -21,7 +21,7 @@
   FILE_GUID  = EF172A23-C7C5-47b7-B24E-D10DFE15540F
   MODULE_TYPE= DXE_DRIVER
   VERSION_STRING = 1.0
-  LIBRARY_CLASS  = OemHookStatusCodeLib|DXE_DRIVER 
DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
+  LIBRARY_CLASS  = OemHookStatusCodeLib|DXE_DRIVER 
DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
 
 #
 # The following information is for reference only and not required by the 
build tools.
diff --git a/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf 
b/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf
index a6891dd5f3..aef0ff421a 100644
--- a/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf
+++ b/Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.inf
@@ -23,7 +23,7 @@
 #
 # The following information is for reference only and not required by the 
build tools.
 #
-#  VALID_ARCHITECTURES   = IA32 X64 IPF EBC
+#  VALID_ARCHITECTURES   = IA32 X64 EBC
 #
 
 [Sources]
diff --git a/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf 
b/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
index 70449015fa..4f421927ee 100644
--- a/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
+++ b/Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
@@ -26,7 +26,7 @@
 #
 # The following information is for reference only and not required by the 
build tools.
 #
-#  VALID_ARCHITECTURES   = IA32 X64 IPF EBC
+#  VALID_ARCHITECTURES   = IA32 X64 EBC
 #
 
 [Sources]
diff --git a/Nt32Pkg/StallPei/StallPei.inf b/Nt32Pkg/StallPei/StallPei.inf
index 31020ed7ed..b6b0588eef 100644
--- a/Nt32Pkg/StallPei/StallPei.inf
+++ b/Nt32Pkg/StallPei/StallPei.inf
@@ -25,7 +25,7 @@
 #
 # The following information is for reference only and not required by the 
build tools.
 #
-#  VALID_ARCHITECTURES   = IA32 X64 IPF EBC
+#  VALID_ARCHITECTURES   = IA32 X64 EBC
 #
 
 [Sources]
diff --git a/Nt32Pkg/WinNtFirmwareVolumePei/WinNtFirmwareVolumePei.inf 
b/Nt32Pkg/WinNtFirmwareVolumePei/WinNtFirmwareVolumePei.inf
index 721f1b374c..dee7b8769e 100644
--- a/Nt32Pkg/WinNtFirmwareVolumePei/WinNtFirmwareVolumePei.inf
+++ b/Nt32Pkg/WinNtFirmwareVolumePei/WinNtFirmwareVolumePei.inf
@@ -26,7 +26,7 @@
 #
 # The following information is for reference only and not required by the 
build tools.
 #
-#  VALID_ARCHITECTURES   = IA32 X64 IPF EBC
+#  VALID