Some pending fixes for BaseMemoryLib* and BaseMemoryLibOptDxe, now resent
as a single series.
Patch #1 fixes an arithmetic bug in BaseMemoryLibOptDxe for ARM, which renders
it unusable at the moment.
Patch #2 adds some asserts that are mentioned in the respective comment blocks
but are missing from the code.
Patch #3 fixes a performance regressions observed by moving from the (soon to be
deprecated) BaseMemoryLibStm in ArmPkg to BaseMemoryLibOptDxe. The culprit has
been identified to be CompareGuid(), which needlessly uses unaligned accessors
(since this library can only be used in a context where unaligned accesses are
allowed)
Ard Biesheuvel (3):
MdePkg/BaseMemoryLibOptDxe ARM: fix arithmetic bugs in CompareMem()
MdePkg/BaseMemoryLib*: add missing ASSERT()s
MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: implement accelerated GUID
functions
MdePkg/Library/BaseMemoryLib/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareGuid.S | 40 ++++++
MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 66 +++++++++
MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.asm | 69 +++++++++
MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 4 +-
MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c | 152
++++++++++++++++++++
MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | 7 +-
MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c | 8 ++
MdePkg/Library/PeiMemoryLib/MemLibGuid.c | 8 ++
MdePkg/Library/UefiMemoryLib/MemLibGuid.c | 8 ++
14 files changed, 399 insertions(+), 3 deletions(-)
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareGuid.S
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.asm
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
--
2.7.4
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
