Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-10 Thread Ashish Singhal
om: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Ashish Singhal > > Sent: Thursday, January 10, 2019 9:19 AM > > To: Kinney, Michael D ; > > edk2-devel@lists.01.org > > Cc: Fu, Siyuan ; Wu, Jiaxin > > ; Gao, Liming > > Subject: Re: [edk2] [PA

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-10 Thread Gao, Liming
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Ashish Singhal > > Sent: Thursday, January 10, 2019 9:19 AM > > To: Kinney, Michael D ; > > edk2-devel@lists.01.org > > Cc: Fu, Siyuan ; Wu, Jiaxin > > ; Gao, Liming > > Su

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-10 Thread Ashish Singhal
axin > ; Gao, Liming > Subject: Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for > protocol uninstallation > > Thanks Mike. Hope to see the patches merged soon. Please let me know if you > want me to file the BZ. > > Hi Liming, > > Please let me know if you need

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-10 Thread Gao, Liming
age- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ashish > Singhal > Sent: Thursday, January 10, 2019 9:19 AM > To: Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin ; Gao, > Liming > Subject: Re: [edk2] [PATCH v4 0/2] P

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-09 Thread Ashish Singhal
Thanks Mike. Hope to see the patches merged soon. Please let me know if you want me to file the BZ. Hi Liming, Please let me know if you need me to take care of anything in the patch before you push it. Hi Siyuan/Jiaxin, I think you reviewed the changes in PATCH v2 which is same as in PATCH

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-09 Thread Kinney, Michael D
Hi Ashish, This V4 version of the patch produces the expected size results for platform and driver builds. There are some very minor issues with some extra carriage returns, but those can be handled by Liming when the patch series is committed. I may be good to have an additional BZ to use

[edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-09 Thread Ashish Singhal
An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after initialization failure was not done right. Bug 1428 was filed in this regard. As per discussions with Mike, it was also discussed that having UEFILib provide protocol uninstallation abstraction would help to avoid these issues