Re: [edk2] [Patch] BaseTools: Add *B Flag for the field that from command line

[Gao, Liming]

Reviewed-by: Liming Gao <liming@intel.com>

>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Friday, February 23, 2018 1:07 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Add *B Flag for the field that from
>command line
>
>For structure PCD, the field value may override in the command line,
>so in the report when we print the field info we add *B Flag for those
>field.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 53d0039..2114499 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -1234,18 +1234,14 @@ class PcdReport(object):
> self.PrintPcdDefault(File, Pcd, IsStructure, DscMatch,
>DscDefaultValue, InfMatch, InfDefaultValue, DecMatch, DecDefaultValue)
>
> def PrintStructureInfo(self, File, Struct):
> NewInfo = collections.OrderedDict()
> for Key, Value in Struct.items():
>-if Key not in NewInfo:
>-NewInfo[Key] = Value[0]
>+if Value[1] and 'build command options' in Value[1]:
>+FileWrite(File, '*B  %-*s = %s' % (self.MaxLen + 4, '.' + 
>Key,
>Value[0]))
> else:
>-del NewInfo[Key]
>-NewInfo[Key] = Value[0]
>-if NewInfo:
>-for item in NewInfo:
>-FileWrite(File, '%-*s = %s' % (self.MaxLen + 4, '.' + 
>item,
>NewInfo[item]))
>+FileWrite(File, '%-*s = %s' % (self.MaxLen + 4, '.' + 
>Key, Value[0]))
>
> def StrtoHex(self, value):
> try:
> value = hex(int(value))
> return value
>--
>2.6.1.windows.1
>
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch] BaseTools: Add *B Flag for the field that from command line

[Yonghong Zhu]

For structure PCD, the field value may override in the command line,
so in the report when we print the field info we add *B Flag for those
field.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu 
---
 BaseTools/Source/Python/build/BuildReport.py | 10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/BaseTools/Source/Python/build/BuildReport.py 
b/BaseTools/Source/Python/build/BuildReport.py
index 53d0039..2114499 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -1234,18 +1234,14 @@ class PcdReport(object):
 self.PrintPcdDefault(File, Pcd, IsStructure, DscMatch, 
DscDefaultValue, InfMatch, InfDefaultValue, DecMatch, DecDefaultValue)
 
 def PrintStructureInfo(self, File, Struct):
 NewInfo = collections.OrderedDict()
 for Key, Value in Struct.items():
-if Key not in NewInfo:
-NewInfo[Key] = Value[0]
+if Value[1] and 'build command options' in Value[1]:
+FileWrite(File, '*B  %-*s = %s' % (self.MaxLen + 4, '.' + 
Key, Value[0]))
 else:
-del NewInfo[Key]
-NewInfo[Key] = Value[0]
-if NewInfo:
-for item in NewInfo:
-FileWrite(File, '%-*s = %s' % (self.MaxLen + 4, '.' + 
item, NewInfo[item]))
+FileWrite(File, '%-*s = %s' % (self.MaxLen + 4, '.' + 
Key, Value[0]))
 
 def StrtoHex(self, value):
 try:
 value = hex(int(value))
 return value
-- 
2.6.1.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel