Re: [edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip

2016-09-20 Thread Kinney, Michael D 
Jeff,

These changes look good to me and I have verified Galileo boots with these 
changes.

Series Reviewed-by: Michael Kinney <michael.d.kin...@intel.com>

Mike

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff 
> Fan
> Sent: Tuesday, September 20, 2016 1:29 AM
> To: edk2-de...@ml01.01.org
> Subject: [edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip
> 
> Flat32.S should set ESP to top of eSRAM range that aligns with Flat32.asm.
> It cause ASSERT() reported at 
> https://tianocore.acgmultimedia.com/show_bug.cgi?id=123
> 
> Jeff Fan (3):
>   QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S
>   UefiCpuPkg/SecCore: Fix comment typo
>   UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs
> 
>  QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S |  4 ++--
>  UefiCpuPkg/SecCore/SecBist.c  | 14 --
>  2 files changed, 10 insertions(+), 8 deletions(-)
> 
> --
> 2.9.3.windows.2
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip

2016-09-20 Thread Jeff Fan 
Flat32.S should set ESP to top of eSRAM range that aligns with Flat32.asm.
It cause ASSERT() reported at 
https://tianocore.acgmultimedia.com/show_bug.cgi?id=123

Jeff Fan (3):
  QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S
  UefiCpuPkg/SecCore: Fix comment typo
  UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs

 QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S |  4 ++--
 UefiCpuPkg/SecCore/SecBist.c  | 14 --
 2 files changed, 10 insertions(+), 8 deletions(-)

-- 
2.9.3.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel