Re: [edk2] [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools
Bob: This change is not related to ECP. Please keep this definition. >-Original Message- >From: Feng, Bob C >Sent: Wednesday, January 09, 2019 4:35 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >; Carsey, Jaben >Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C >tools > >From: "Feng, Bob C" > >https://bugzilla.tianocore.org/show_bug.cgi?id=1350 >Remove ECP support from BaseTools C code. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Bob Feng >Cc: Liming Gao >Cc: Jaben Carsey >--- > BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h >b/BaseTools/Source/C/Include/IndustryStandard/pci22.h >index d7c5f0c858..873ce69094 100644 >--- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h >+++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h >@@ -178,11 +178,10 @@ typedef struct { > #define PCI_IF_16850 0x05 > #define PCI_IF_16950 0x06 > #define PCI_SUBCLASS_PARALLEL 0x01 > #define PCI_IF_PARALLEL_PORT 0x00 > #define PCI_IF_BI_DIR_PARALLEL_PORT 0x01 >-#define PCI_IF_ECP_PARALLEL_PORT 0x02 > #define PCI_IF_1284_CONTROLLER0x03 > #define PCI_IF_1284_DEVICE0xFE > #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02 > #define PCI_SUBCLASS_MODEM0x03 > #define PCI_IF_GENERIC_MODEM 0x00 >-- >2.19.1.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools
Reviewed-by: Jaben Carsey > -Original Message- > From: Feng, Bob C > Sent: Wednesday, January 09, 2019 12:35 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > ; Carsey, Jaben > Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C > tools > Importance: High > > From: "Feng, Bob C" > > https://bugzilla.tianocore.org/show_bug.cgi?id=1350 > Remove ECP support from BaseTools C code. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Jaben Carsey > --- > BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h > b/BaseTools/Source/C/Include/IndustryStandard/pci22.h > index d7c5f0c858..873ce69094 100644 > --- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h > +++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h > @@ -178,11 +178,10 @@ typedef struct { > #define PCI_IF_16850 0x05 > #define PCI_IF_16950 0x06 > #define PCI_SUBCLASS_PARALLEL 0x01 > #define PCI_IF_PARALLEL_PORT 0x00 > #define PCI_IF_BI_DIR_PARALLEL_PORT 0x01 > -#define PCI_IF_ECP_PARALLEL_PORT 0x02 > #define PCI_IF_1284_CONTROLLER0x03 > #define PCI_IF_1284_DEVICE0xFE > #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02 > #define PCI_SUBCLASS_MODEM0x03 > #define PCI_IF_GENERIC_MODEM 0x00 > -- > 2.19.1.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1350 Remove ECP support from BaseTools C code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h b/BaseTools/Source/C/Include/IndustryStandard/pci22.h index d7c5f0c858..873ce69094 100644 --- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h +++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h @@ -178,11 +178,10 @@ typedef struct { #define PCI_IF_16850 0x05 #define PCI_IF_16950 0x06 #define PCI_SUBCLASS_PARALLEL 0x01 #define PCI_IF_PARALLEL_PORT 0x00 #define PCI_IF_BI_DIR_PARALLEL_PORT 0x01 -#define PCI_IF_ECP_PARALLEL_PORT 0x02 #define PCI_IF_1284_CONTROLLER0x03 #define PCI_IF_1284_DEVICE0xFE #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02 #define PCI_SUBCLASS_MODEM0x03 #define PCI_IF_GENERIC_MODEM 0x00 -- 2.19.1.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel