Re: [edk2] [Patch 4/5] Vlv2TbltDevicePkg: Display logo on BOOT_ON_FLASH_UPDATE

[Wei, David]

Reviewed-by: David Wei 

Thanks,
David  Wei

Intel SSG/STO/UEFI BIOS 


-Original Message-
From: Kinney, Michael D 
Sent: Wednesday, March 28, 2018 1:33 PM
To: edk2-devel@lists.01.org
Cc: Wei, David ; Guo, Mang ; Yao, 
Jiewen ; Kinney, Michael D 
Subject: [Patch 4/5] Vlv2TbltDevicePkg: Display logo on BOOT_ON_FLASH_UPDATE

https://bugzilla.tianocore.org/show_bug.cgi?id=911

Update PlatformBdsLib to show boot logo when the boot
mode is BOOT_ON_FLASH_UPDATE.

Cc: David Wei 
Cc: Mang Guo 
Cc: Jiewen Yao 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c | 14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c 
b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
index e42e82b678..c25e1d301a 100644
--- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
+++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
@@ -1,6 +1,6 @@
 /** @file
 
-  Copyright (c) 2004  - 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2004  - 2018, Intel Corporation. All rights reserved.


   This program and the accompanying materials are licensed and made available 
under
   the terms and conditions of the BSD License that accompanies this 
distribution.  
@@ -1871,6 +1871,7 @@ PlatformBdsPolicyBehavior (
 //
 PlatformBdsConnectConsole (gPlatformConsole);
 PlatformBdsDiagnostics (EXTENSIVE, FALSE, BaseMemoryTest);
+EnableQuietBoot (PcdGetPtr(PcdLogoFile));
 
 DEBUG((DEBUG_INFO, "ProcessCapsules Before EndOfDxe..\n"));
 ProcessCapsules ();
@@ -2642,6 +2643,8 @@ PlatformBdsEnterFrontPageWithHotKey (
 {
   EFI_STATUSStatus;
 
+  EFI_STATUS LogoStatus;
+  EFI_BOOT_LOGO_PROTOCOL *BootLogo;
   EFI_GRAPHICS_OUTPUT_PROTOCOL   *GraphicsOutput;
   EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL*SimpleTextOut;
   UINTN  BootTextColumn;
@@ -2721,6 +2724,14 @@ PlatformBdsEnterFrontPageWithHotKey (
 gST->ConOut->EnableCursor (gST->ConOut, TRUE);
 gST->ConOut->ClearScreen (gST->ConOut);
 
+//
+// Boot Logo is corrupted, report it using Boot Logo protocol.
+//
+LogoStatus = gBS->LocateProtocol (, NULL, (VOID 
**) );
+if (!EFI_ERROR (LogoStatus) && (BootLogo != NULL)) {
+  BootLogo->SetBootLogo (BootLogo, NULL, 0, 0, 0, 0);
+}
+
 if (EFI_ERROR (Status)) {
   //
   // Timeout or user press enter to continue
@@ -2728,6 +2739,7 @@ PlatformBdsEnterFrontPageWithHotKey (
   goto Exit;
 }
   }
+
   //
   // Install BM HiiPackages. 
   // Keep BootMaint HiiPackage, so that it can be covered by global setting. 
-- 
2.14.2.windows.3

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch 4/5] Vlv2TbltDevicePkg: Display logo on BOOT_ON_FLASH_UPDATE

[Kinney, Michael D]

https://bugzilla.tianocore.org/show_bug.cgi?id=911

Update PlatformBdsLib to show boot logo when the boot
mode is BOOT_ON_FLASH_UPDATE.

Cc: David Wei 
Cc: Mang Guo 
Cc: Jiewen Yao 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c | 14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c 
b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
index e42e82b678..c25e1d301a 100644
--- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
+++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
@@ -1,6 +1,6 @@
 /** @file
 
-  Copyright (c) 2004  - 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2004  - 2018, Intel Corporation. All rights reserved.


   This program and the accompanying materials are licensed and made available 
under
   the terms and conditions of the BSD License that accompanies this 
distribution.  
@@ -1871,6 +1871,7 @@ PlatformBdsPolicyBehavior (
 //
 PlatformBdsConnectConsole (gPlatformConsole);
 PlatformBdsDiagnostics (EXTENSIVE, FALSE, BaseMemoryTest);
+EnableQuietBoot (PcdGetPtr(PcdLogoFile));
 
 DEBUG((DEBUG_INFO, "ProcessCapsules Before EndOfDxe..\n"));
 ProcessCapsules ();
@@ -2642,6 +2643,8 @@ PlatformBdsEnterFrontPageWithHotKey (
 {
   EFI_STATUSStatus;
 
+  EFI_STATUS LogoStatus;
+  EFI_BOOT_LOGO_PROTOCOL *BootLogo;
   EFI_GRAPHICS_OUTPUT_PROTOCOL   *GraphicsOutput;
   EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL*SimpleTextOut;
   UINTN  BootTextColumn;
@@ -2721,6 +2724,14 @@ PlatformBdsEnterFrontPageWithHotKey (
 gST->ConOut->EnableCursor (gST->ConOut, TRUE);
 gST->ConOut->ClearScreen (gST->ConOut);
 
+//
+// Boot Logo is corrupted, report it using Boot Logo protocol.
+//
+LogoStatus = gBS->LocateProtocol (, NULL, (VOID 
**) );
+if (!EFI_ERROR (LogoStatus) && (BootLogo != NULL)) {
+  BootLogo->SetBootLogo (BootLogo, NULL, 0, 0, 0, 0);
+}
+
 if (EFI_ERROR (Status)) {
   //
   // Timeout or user press enter to continue
@@ -2728,6 +2739,7 @@ PlatformBdsEnterFrontPageWithHotKey (
   goto Exit;
 }
   }
+
   //
   // Install BM HiiPackages. 
   // Keep BootMaint HiiPackage, so that it can be covered by global setting. 
-- 
2.14.2.windows.3

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel