Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / General Rules: limit line lengths to 80 columns

2017-08-12 Thread Leif Lindholm
On Fri, Aug 11, 2017 at 11:52:44PM +0100, Ard Biesheuvel wrote: > On 11 August 2017 at 17:48, Laszlo Ersek wrote: > > We currently say "stick with 80 if it's convenient, extend to 120 > > otherwise". > > It doesn't say that. It says you can make an exception for postfix >

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / General Rules: limit line lengths to 80 columns

2017-08-11 Thread Ard Biesheuvel
On 11 August 2017 at 17:48, Laszlo Ersek wrote: > We currently say "stick with 80 if it's convenient, extend to 120 > otherwise". It doesn't say that. It says you can make an exception for postfix comments, which is not unreasonable imo. This means most of the code in

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / General Rules: limit line lengths to 80 columns

2017-08-11 Thread Jordan Justen
On 2017-08-11 09:48:50, Laszlo Ersek wrote: > We currently say "stick with 80 if it's convenient, extend to 120 > otherwise". This is too lax; much new edk2 code ignores the 80 columns > recommendation, resulting in source files that are hard to read for some > contributors. Remove the 120 columns