Re: [edk2] [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue

2018-03-06 Thread Zhang, Chao B 
Reviewed-by: Chao Zhang 

-Original Message-
From: Bi, Dandan 
Sent: Wednesday, March 7, 2018 1:54 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B 
Subject: [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue

Boolean values do not need to use explicit comparisons to TRUE or FALSE.

Cc: Chao Zhang 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi 
---
 .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c 
b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
index dfef6c8..6a4dce9 100644
--- 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
+++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPres
+++ enceLib.c
@@ -339,11 +339,11 @@ Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
 case 
TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_ENABLE_BLOCK_SID_FUNC_FALSE:
 case 
TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_DISABLE_BLOCK_SID_FUNC_FALSE:
   break;
 
 default:
-  if (mIsTcg2PPVerLowerThan_1_3 == FALSE) {
+  if (!mIsTcg2PPVerLowerThan_1_3) {
 if (OperationRequest < 
TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {
   //
   // TCG2 PP1.3 spec defined operations that are reserved or 
un-implemented
   //
   return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED;
--
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue

2018-03-06 Thread Dandan Bi 
Boolean values do not need to use explicit comparisons
to TRUE or FALSE.

Cc: Chao Zhang 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi 
---
 .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c 
b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
index dfef6c8..6a4dce9 100644
--- 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
+++ 
b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
@@ -339,11 +339,11 @@ Tcg2PhysicalPresenceLibGetUserConfirmationStatusFunction (
 case 
TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_ENABLE_BLOCK_SID_FUNC_FALSE:
 case 
TCG2_PHYSICAL_PRESENCE_SET_PP_REQUIRED_FOR_DISABLE_BLOCK_SID_FUNC_FALSE:
   break;
 
 default:
-  if (mIsTcg2PPVerLowerThan_1_3 == FALSE) {
+  if (!mIsTcg2PPVerLowerThan_1_3) {
 if (OperationRequest < 
TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {
   //
   // TCG2 PP1.3 spec defined operations that are reserved or 
un-implemented
   //
   return TCG_PP_GET_USER_CONFIRMATION_NOT_IMPLEMENTED;
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

2016-10-21 Thread Bi, Dandan 
Reviewed-by: Dandan Bi 

Thanks,
Dandan

-Original Message-
From: Zhang, Chao B 
Sent: Friday, October 21, 2016 1:25 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Long, Qin ; Zhang, 
Chao B 
Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

Fix coding style issue for function descriptor.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang 
---
 SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 4 ++--
 .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h 
b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
index 696c7e8..910da7a 100644
--- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
+++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
@@ -125,8 +125,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
 
   Caution: This function may receive untrusted input.
 
-  @param[in out]  Pointer to OperationRequest TPM physical presence operation 
request.
-  @param[in out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
+  @param[in, out]  Pointer to OperationRequest TPM physical presence operation 
request.
+  @param[in, out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
 
   @return Return Code for Submit TPM Operation Request to Pre-OS Environment 
and
 Submit TPM Operation Request to Pre-OS Environment 2.
diff --git 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c 
b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
index c03b42b..039bca1 100644
--- 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
+++ 
b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
@@ -91,8 +91,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
 
   Caution: This function may receive untrusted input.
 
-  @param[in out]  Pointer to OperationRequest TPM physical presence operation 
request.
-  @param[in out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
+  @param[in, out]  Pointer to OperationRequest TPM physical presence operation 
request.
+  @param[in, out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
 
   @return Return Code for Submit TPM Operation Request to Pre-OS Environment 
and
 Submit TPM Operation Request to Pre-OS Environment 2.
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

2016-10-21 Thread Long, Qin 
Reviewed-by: Qin Long 


> -Original Message-
> From: Zhang, Chao B
> Sent: Friday, October 21, 2016 1:25 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Long, Qin ;
> Zhang, Chao B 
> Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style
> issue
> 
> Fix coding style issue for function descriptor.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang 
> ---
>  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 4 
> ++--
>  .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c   | 4
> ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> index 696c7e8..910da7a 100644
> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> @@ -125,8 +125,8 @@
> Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
> 
>Caution: This function may receive untrusted input.
> 
> -  @param[in out]  Pointer to OperationRequest TPM physical presence
> operation request.
> -  @param[in out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> +  @param[in, out]  Pointer to OperationRequest TPM physical presence
> operation request.
> +  @param[in, out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> 
>@return Return Code for Submit TPM Operation Request to Pre-OS
> Environment and
>  Submit TPM Operation Request to Pre-OS Environment 2.
> diff --git
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> index c03b42b..039bca1 100644
> ---
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> +++
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> @@ -91,8 +91,8 @@
> Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
> 
>Caution: This function may receive untrusted input.
> 
> -  @param[in out]  Pointer to OperationRequest TPM physical presence
> operation request.
> -  @param[in out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> +  @param[in, out]  Pointer to OperationRequest TPM physical presence
> operation request.
> +  @param[in, out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> 
>@return Return Code for Submit TPM Operation Request to Pre-OS
> Environment and
>  Submit TPM Operation Request to Pre-OS Environment 2.
> --
> 1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

2016-10-20 Thread Zhang, Chao B 
Fix coding style issue for function descriptor.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang 
---
 SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 4 ++--
 .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h 
b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
index 696c7e8..910da7a 100644
--- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
+++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
@@ -125,8 +125,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
 
   Caution: This function may receive untrusted input.
 
-  @param[in out]  Pointer to OperationRequest TPM physical presence operation 
request.
-  @param[in out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
+  @param[in, out]  Pointer to OperationRequest TPM physical presence operation 
request.
+  @param[in, out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
 
   @return Return Code for Submit TPM Operation Request to Pre-OS Environment 
and
 Submit TPM Operation Request to Pre-OS Environment 2.
diff --git 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c 
b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
index c03b42b..039bca1 100644
--- 
a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
+++ 
b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
@@ -91,8 +91,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
 
   Caution: This function may receive untrusted input.
 
-  @param[in out]  Pointer to OperationRequest TPM physical presence operation 
request.
-  @param[in out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
+  @param[in, out]  Pointer to OperationRequest TPM physical presence operation 
request.
+  @param[in, out]  Pointer to RequestParameter TPM physical presence operation 
request parameter.
 
   @return Return Code for Submit TPM Operation Request to Pre-OS Environment 
and
 Submit TPM Operation Request to Pre-OS Environment 2.
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel