On 12 July 2018 at 09:39, Marcin Wojtas wrote:
> For upcoming patches there is a need to get the CP110 base address,
> introduce according getter function for it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas
> ---
> Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h
> | 6 ++
>
> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c
> | 11 +++
> 2 files changed, 17 insertions(+)
>
> diff --git a/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h
> b/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h
> index d2bcf2a..56efdbe 100644
> --- a/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h
> +++ b/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h
> @@ -36,6 +36,12 @@ ArmadaSoCDescComPhyGet (
>IN OUT UINTN*DescCount
>);
>
> +UINTN
If this is a memory address, you should use EFI_PHYSICAL_ADDRESS here.
> +EFIAPI
> +ArmadaSoCDescCpBaseGet (
> + IN UINTN CpIndex
> + );
> +
> //
> // I2C
> //
> diff --git
> a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c
>
> b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c
> index 6ce6bad..c7c9c13 100644
> ---
> a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c
> +++
> b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c
> @@ -61,6 +61,17 @@ ArmadaSoCDescComPhyGet (
>return EFI_SUCCESS;
> }
>
> +UINTN
> +EFIAPI
> +ArmadaSoCDescCpBaseGet (
> + IN UINTN CpIndex
> + )
> +{
> + ASSERT (CpIndex < FixedPcdGet8 (PcdMaxCpCount));
> +
> + return MV_SOC_CP_BASE (CpIndex);
> +}
> +
> EFI_STATUS
> EFIAPI
> ArmadaSoCDescI2cGet (
> --
> 2.7.4
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel