[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-05 Thread Fan Jeff
vanjeff_...@hotmail.com>> Sent: Friday, November 3, 2017 4:21:22 PM To: Yao, Jiewen; Kinney, Michael D; Wang, Jian J; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Dong, Eric; Zeng, Star Subject: [edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-05 Thread Fan Jeff
n; Kinney, Michael D; Wang, Jian J; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Dong, Eric; Zeng, Star Subject: [edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support Jian, Could you use some global variables in https://github.com/tianocore/edk2/bl

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-03 Thread Fan Jeff
ilto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan > Jeff > Sent: Tuesday, October 31, 2017 7:33 PM > To: Yao, Jiewen <jiewen@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Do

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Fan Jeff
Jian, You are right! The exception handler setup in DxeIplPeim does not need stack at all. Thanks your clarification. Jeff 发件人: Wang, Jian J 发送时间: 2017年11月1日 11:12 收件人: Wang, Jian J; Fan Jeff; Yao,

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Fan Jeff
That’s fine. Thanks Developers should have such assumption without exception dumping message if NULL instance used. Jeff 发件人: Wang, Jian J 发送时间: 2017年11月1日 11:08 收件人: Fan Jeff; Yao, Jiewen;

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Fan Jeff
Jian, No. I suggest to fix #109 in another separate patch. But to fix #109, we have to makes sure AsmWriteTr() and some definitions are in MdePkg. But I have no strong opinion to add them into MdePkg in this patch. I have another question: If NULL CPU exception handler instance is chosen,

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Fan Jeff
1. Should add EFIAPI for the following function. +VOID +AsmWriteTr ( + UINT16 Selector + ); 2. Should not add EFIAPI for the following function. +VOID +EFIAPI +ArchSetupExcpetionStack ( + IN IA32_IDT_GATE_DESCRIPTOR *IdtTable + ) 发件人: Jian J

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Fan Jeff
Per https://bugzilla.tianocore.org/show_bug.cgi?id=109, TR should be setup (Such as in DxeIplPeim) even though NULL Cpu Exception Handler instance is chosen. For long term, I agree we need to move AsmWriteTr, IA32_TASK_STATE_SEGMENT, IA32_TSS_DESCRIPTOR to MdePkg(Such as BaseLib) For this