Re: [edk2] [PATCH] SecurityPkg: Remove superfluous return statement

2017-02-16 Thread Thomas Huth 
On 25.01.2017 10:58, Thomas Huth wrote:
> If the code eventually returns "Status" anyway, it does not make
> sense to explicitly return "Status" in case of an error, too.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth 
> ---
>  SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 
>  1 file changed, 4 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c 
> b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> index 33f77bd..a95ea2f 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> @@ -1286,10 +1286,6 @@ AhciModeInitialize (
>   EFI_TIMER_PERIOD_SECONDS(16)
>   );
>  
> -  if (EFI_ERROR (Status)) {
> -return Status;
> -  }
> -
>return Status;
>  }

Ping?

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] SecurityPkg: Remove superfluous return statement

2017-02-02 Thread Zhang, Chao B 
Reviewed-by: Chao Zhang 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas 
Huth
Sent: Wednesday, January 25, 2017 5:59 PM
To: edk2-de...@ml01.01.org
Cc: Zhang, Chao B 
Subject: [edk2] [PATCH] SecurityPkg: Remove superfluous return statement

If the code eventually returns "Status" anyway, it does not make sense to 
explicitly return "Status" in case of an error, too.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth 
---
 SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c 
b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
index 33f77bd..a95ea2f 100644
--- a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
+++ b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
@@ -1286,10 +1286,6 @@ AhciModeInitialize (
  EFI_TIMER_PERIOD_SECONDS(16)
  );
 
-  if (EFI_ERROR (Status)) {
-return Status;
-  }
-
   return Status;
 }
 
--
1.8.3.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel