Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Pete Batard
Hi Andrew, On 2016.09.22 21:27, Andrew Fish wrote: It seems like tracking the PUSHes would work? First of all, as got pointed out by Ard, I need to mention that much of my earlier analysis results, which you quoted, were due to a misread of the specs, as it does mandates pushing 32 bit

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Andrew Fish
> On Sep 22, 2016, at 4:05 AM, Pete Batard wrote: > > On 2016.09.22 11:06, Ard Biesheuvel wrote: >> However, there is a fundamental issue with EBC on ARM that has not >> been addressed yet, which makes EBC support problematic: >> ARM uses natural alignment for 64-bit types, which

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 12:26, Pete Batard wrote: > On 2016.09.22 12:14, Ard Biesheuvel wrote: >> >> For X64 and AARCH64, the issue does not exist because the EBC spec >> mandates that all function arguments are widened to the native word >> size. So when executing on a 64-bit

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Pete Batard
On 2016.09.22 12:14, Ard Biesheuvel wrote: For X64 and AARCH64, the issue does not exist because the EBC spec mandates that all function arguments are widened to the native word size. So when executing on a 64-bit architecture, the EBC stack looks differently from what you describe above, and

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 12:05, Pete Batard wrote: > On 2016.09.22 11:06, Ard Biesheuvel wrote: >> >> However, there is a fundamental issue with EBC on ARM that has not >> been addressed yet, which makes EBC support problematic: >> ARM uses natural alignment for 64-bit types, which

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Pete Batard
On 2016.09.22 11:06, Ard Biesheuvel wrote: However, there is a fundamental issue with EBC on ARM that has not been addressed yet, which makes EBC support problematic: ARM uses natural alignment for 64-bit types, which means it leaves gaps in the stack frame, and the thunking code has no way of

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 11:06, Ard Biesheuvel wrote: > On 22 September 2016 at 10:43, Pete Batard wrote: >> Hi, >> >> The following is an updated/fixed version of the patch(es), put forward by >> Ard Biesheuvel on August 9 ([1], [2]), and re-submitted for

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 10:43, Pete Batard wrote: > Hi, > > The following is an updated/fixed version of the patch(es), put forward by > Ard Biesheuvel on August 9 ([1], [2]), and re-submitted for formal > inclusion, so that the EDK2 can provide EBC functionality for all of IA32, >