Re: [edk2] [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

2018-02-09 Thread Leif Lindholm
On Thu, Feb 08, 2018 at 07:22:33PM +, Ard Biesheuvel wrote:
> On 8 February 2018 at 19:19, Leif Lindholm  wrote:
> > Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to
> > actually drop it as a dependency for BeagleBoardLib.
> >
> > Get rid of it, so the module will still build when the Pcd is _really_
> > removed.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm 
> 
> For the series:
> Reviewed-by: Ard Biesheuvel 

Thanks!
Pushed as ce2818e418..6791175f05.

> > ---
> >  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf 
> > b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> > index e004d6f10b..3b62f3cbf7 100644
> > --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> > +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> > @@ -44,9 +44,6 @@ [Sources.common]
> >BeagleBoardHelper.S| GCC
> >BeagleBoardHelper.asm  | RVCT
> >
> > -[FeaturePcd]
> > -  gEmbeddedTokenSpaceGuid.PcdCacheEnable
> > -
> >  [FixedPcd]
> >gArmTokenSpaceGuid.PcdFdBaseAddress
> >gArmTokenSpaceGuid.PcdFdSize
> > --
> > 2.11.0
> >
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

2018-02-08 Thread Ard Biesheuvel
On 8 February 2018 at 19:19, Leif Lindholm  wrote:
> Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to
> actually drop it as a dependency for BeagleBoardLib.
>
> Get rid of it, so the module will still build when the Pcd is _really_
> removed.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm 

For the series:
Reviewed-by: Ard Biesheuvel 

> ---
>  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf 
> b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> index e004d6f10b..3b62f3cbf7 100644
> --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> @@ -44,9 +44,6 @@ [Sources.common]
>BeagleBoardHelper.S| GCC
>BeagleBoardHelper.asm  | RVCT
>
> -[FeaturePcd]
> -  gEmbeddedTokenSpaceGuid.PcdCacheEnable
> -
>  [FixedPcd]
>gArmTokenSpaceGuid.PcdFdBaseAddress
>gArmTokenSpaceGuid.PcdFdSize
> --
> 2.11.0
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel