Re: [edk2] [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function

2017-02-16 Thread Ard Biesheuvel 
On 13 February 2017 at 07:53, Haojian Zhuang  wrote:
> When call PL061GetPins() or PL061SetPins(), should use GPIO_PIN_MASK(offset)
> as parameter, not offset.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Haojian Zhuang 

Reviewed-by: Ard Biesheuvel 

Pushed as

d164a0e31bf8 ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG
d176bb3c5c28 ArmPlatformPkg/PL061Gpio: fix the offset value in Get function

> ---
>  ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c 
> b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> index ff8bb3b..81b9f6d 100644
> --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> @@ -186,7 +186,7 @@ Get (
>  return EFI_INVALID_PARAMETER;
>}
>
> -  if (PL061GetPins (RegisterBase, Offset)) {
> +  if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) {
>  *Value = 1;
>} else {
>  *Value = 0;
> --
> 2.7.4
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function

2017-02-13 Thread Haojian Zhuang 
On 13 February 2017 at 15:53, Haojian Zhuang  wrote:
> When call PL061GetPins() or PL061SetPins(), should use GPIO_PIN_MASK(offset)
> as parameter, not offset.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Haojian Zhuang 
> ---
>  ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c 
> b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> index ff8bb3b..81b9f6d 100644
> --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> @@ -186,7 +186,7 @@ Get (
>  return EFI_INVALID_PARAMETER;
>}
>
> -  if (PL061GetPins (RegisterBase, Offset)) {
> +  if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) {
>  *Value = 1;
>} else {
>  *Value = 0;
> --
> 2.7.4
>

Correct Ard's email address.

Regards
Haojian
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel