Re: [edk2] [PATCH 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection

2017-10-13 Thread Wang, Jian J
You're right. "BIT3 | BIT2" should be enclosed by parentheses. Thanks for catching this issue. > -Original Message- > From: Dong, Eric > Sent: Friday, October 13, 2017 9:24 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ;

Re: [edk2] [PATCH 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection

2017-10-12 Thread Dong, Eric
Hi Jian, > + if (!mCpuSmmStaticPageTable || (PcdGet8 (PcdHeapGuardPropertyMask) > & > + BIT3 | BIT2) != 0) { I think above code logic is not correct, the "&" will be handled before the "|" which is not an expected order, right? Thanks, Eric > -Original Message- > From: Wang, Jian J >