Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-28 Thread Leif Lindholm
On Fri, Feb 23, 2018 at 11:47:28AM +0100, Laszlo Ersek wrote: > >> I think the solution that saves the most on the *source* code size > >> is: > >> - introduce the BeIoLib class > >> - duplicate the MMIO functions from BaseIoLibIntrinsic to the one > >> BeIoLib instance that we introduce > >> -

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Laszlo Ersek
Lindholm <leif.lindh...@linaro.org> >> Cc: michael.d.kin...@intel.com; edk2-devel@lists.01.org; >> ard.biesheu...@linaro.org; Meenakshi Aggarwal >> <meenakshi.aggar...@nxp.com> >> Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support >> for Big

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Pankaj Bansal
.@intel.com; edk2-devel@lists.01.org; > ard.biesheu...@linaro.org; Meenakshi Aggarwal > <meenakshi.aggar...@nxp.com> > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/23/18 12:04, Pankaj Bansal wrote: > >

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Udit Kumar
gt;; Leif Lindholm > <leif.lindh...@linaro.org> > Cc: michael.d.kin...@intel.com; edk2-devel@lists.01.org; > ard.biesheu...@linaro.org > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/23/18 11:25, Udit Ku

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Laszlo Ersek
On 02/23/18 12:04, Pankaj Bansal wrote: > However Laszlo, with the method you suggest (using STATIC CONST > UINT16 mOne), would it not add delay in each Mmio Operation ? > > I am concerned about boot delay using this approach. The condition can be evaluated at compile time, so I expect

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Udit Kumar
chael.d.kin...@intel.com; edk2-devel@lists.01.org; > ard.biesheu...@linaro.org; Meenakshi Aggarwal > <meenakshi.aggar...@nxp.com> > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/23/18 11:39, Udit Kumar wrote: &

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Pankaj Bansal
d.kin...@intel.com; edk2-devel@lists.01.org; > ard.biesheu...@linaro.org; Meenakshi Aggarwal > <meenakshi.aggar...@nxp.com> > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/23/18 11:39, Udit Kumar wrote: &

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Laszlo Ersek
Leif Lindholm >> <leif.lindh...@linaro.org> >> Cc: michael.d.kin...@intel.com; edk2-devel@lists.01.org; >> ard.biesheu...@linaro.org >> Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support >> for Big Endian Mmio APIs >> >> On 02/23/18

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Laszlo Ersek
t; >> Cc: michael.d.kin...@intel.com; edk2-devel@lists.01.org; >> ard.biesheu...@linaro.org >> Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add >> support for Big Endian Mmio APIs >> >> On 02/22/18 12:52, Leif Lindholm wrote: >>> On T

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Udit Kumar
el.d.kin...@intel.com; edk2-devel@lists.01.org; > ard.biesheu...@linaro.org > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/23/18 09:40, Pankaj Bansal wrote: > > Hi All > > > >> -Original Messa

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Udit Kumar
; ard.biesheu...@linaro.org > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/22/18 12:52, Leif Lindholm wrote: > > On Thu, Feb 22, 2018 at 09:34:05AM +0100, Laszlo Ersek wrote: > > >>> But

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Laszlo Ersek
@nxp.com>; Leif Lindholm >> <leif.lindh...@linaro.org> >> Cc: michael.d.kin...@intel.com; edk2-devel@lists.01.org; >> ard.biesheu...@linaro.org >> Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support >> for Big Endian Mmio APIs >>

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Meenakshi Aggarwal
el.d.kin...@intel.com; edk2-devel@lists.01.org; > ard.biesheu...@linaro.org > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/23/18 09:40, Pankaj Bansal wrote: > > Hi All > > > >> -Original Messa

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Laszlo Ersek
.org> >> Cc: michael.d.kin...@intel.com; edk2-devel@lists.01.org; >> ard.biesheu...@linaro.org >> Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support >> for Big Endian Mmio APIs >> >> On 02/22/18 12:52, Leif Lindholm wrote: >>>

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-23 Thread Pankaj Bansal
ts.01.org; > ard.biesheu...@linaro.org > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On 02/22/18 12:52, Leif Lindholm wrote: > > On Thu, Feb 22, 2018 at 09:34:05AM +0100, Laszlo Ersek wrote: > > >>> But

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-22 Thread Laszlo Ersek
On 02/22/18 12:52, Leif Lindholm wrote: > On Thu, Feb 22, 2018 at 09:34:05AM +0100, Laszlo Ersek wrote: >>> But that brings back the complication as to how we have a driver that >>> needs an LE IO library to write output, and a BE IO library to >>> manipulate the hardware. >> >> Can you please

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-22 Thread Leif Lindholm
On Thu, Feb 22, 2018 at 09:34:05AM +0100, Laszlo Ersek wrote: > >> - As long as the specs are LE-only, "endianness opposite to the > >> executing processor" is needless complication / speculative generality > >> in my eyes. > > > > HTON/NTOH? > > I don't understand this reference; host-to-net

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-22 Thread Laszlo Ersek
On 02/21/18 19:58, Leif Lindholm wrote: > On Wed, Feb 21, 2018 at 05:06:02PM +0100, Laszlo Ersek wrote: >> On 02/21/18 16:46, Leif Lindholm wrote: >>> Apologies for dropping the ball on this series during my sabbatical. >>> >>> For this particular patch, I would still like to see a core library

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-21 Thread Udit Kumar
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, February 21, 2018 9:16 PM > Subject: Re: [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big > Endian Mmio APIs > > Apologies for dropping the ball on

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-21 Thread Meenakshi Aggarwal
el@lists.01.org; > ard.biesheu...@linaro.org > Subject: Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support > for Big Endian Mmio APIs > > On Wed, Feb 21, 2018 at 05:06:02PM +0100, Laszlo Ersek wrote: > > On 02/21/18 16:46, Leif Lindholm wrote: > > > Apologi

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-21 Thread Leif Lindholm
On Wed, Feb 21, 2018 at 05:06:02PM +0100, Laszlo Ersek wrote: > On 02/21/18 16:46, Leif Lindholm wrote: > > Apologies for dropping the ball on this series during my sabbatical. > > > > For this particular patch, I would still like to see a core library > > provide the needed functionality. I just

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-21 Thread Laszlo Ersek
On 02/21/18 16:46, Leif Lindholm wrote: > Apologies for dropping the ball on this series during my sabbatical. > > For this particular patch, I would still like to see a core library > provide the needed functionality. I just sent out an RFC of a possible > implementation. > > Regardless, a key

Re: [edk2] [PATCH edk2-platforms 01/39] Silicon/NXP: Add support for Big Endian Mmio APIs

2018-02-21 Thread Leif Lindholm
Apologies for dropping the ball on this series during my sabbatical. For this particular patch, I would still like to see a core library provide the needed functionality. I just sent out an RFC of a possible implementation. Regardless, a key point is that this isn't about "big-endian", it is