Re: [edk2] [PATCH edk2-platforms v2 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-22 Thread Laszlo Ersek
On 02/22/18 18:50, Ard Biesheuvel wrote: > On 22 February 2018 at 17:46, Kinney, Michael D > wrote: >> Ard, >> >> The check for the runtime flag seems inconsistent. >> >> Since the issue being addressed is use of SerialPortLib, >> can't the mEfiAtRuntime flag be use

Re: [edk2] [PATCH edk2-platforms v2 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-22 Thread Laszlo Ersek
On 02/22/18 17:28, Ard Biesheuvel wrote: > Introduce a variant of BaseDebugLibSerialPort that behaves correctly with > regards to the use of the serial port after ExitBootServices(). Also, it > caches PCD values in the constructor so that no calls into PcdLib are > made at runtime. > >

Re: [edk2] [PATCH edk2-platforms v2 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-22 Thread Ard Biesheuvel
On 22 February 2018 at 17:46, Kinney, Michael D wrote: > Ard, > > The check for the runtime flag seems inconsistent. > > Since the issue being addressed is use of SerialPortLib, > can't the mEfiAtRuntime flag be use around SerialPortLib > calls only. > I take it you

Re: [edk2] [PATCH edk2-platforms v2 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-22 Thread Kinney, Michael D
Ard, The check for the runtime flag seems inconsistent. Since the issue being addressed is use of SerialPortLib, can't the mEfiAtRuntime flag be use around SerialPortLib calls only. Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday,

Re: [edk2] [PATCH edk2-platforms v2 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-22 Thread Ard Biesheuvel
On 22 February 2018 at 16:28, Ard Biesheuvel wrote: > Introduce a variant of BaseDebugLibSerialPort that behaves correctly with > regards to the use of the serial port after ExitBootServices(). Also, it > caches PCD values in the constructor so that no calls into PcdLib