Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

2016-06-16 Thread Fu, Siyuan 
Reviewed-by: Fu Siyuan 



> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> hegdenag
> Sent: Thursday, June 16, 2016 12:51 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin 
> Subject: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in
> Mtfp6.h
> 
> defined values of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION and
> EFI_MTFTP6_ERRORCODE_FILE_ALREADY_EXISTS are the same. This patch
> corrects the value of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION to 4.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P 
> ---
>  MdePkg/Include/Protocol/Mtftp6.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/Mtftp6.h
> b/MdePkg/Include/Protocol/Mtftp6.h
> index b983660..e0cfc49 100644
> --- a/MdePkg/Include/Protocol/Mtftp6.h
> +++ b/MdePkg/Include/Protocol/Mtftp6.h
> @@ -4,6 +4,8 @@
>multicast TFTP operations.
> 
>Copyright (c) 2008 - 2011, Intel Corporation. All rights reserved.
> +  (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> +
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be
> found at
> @@ -70,7 +72,7 @@ typedef struct _EFI_MTFTP6_TOKEN
> EFI_MTFTP6_TOKEN;
>  ///
>  /// The MTFTPv6 operation was illegal.
>  ///
> -#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 6
> +#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 4
>  ///
>  /// The transfer ID is unknown.
>  ///
> --
> 2.8.3.windows.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

2016-06-15 Thread Wu, Jiaxin 
Reviewed-By: Wu Jiaxin 


> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> hegdenag
> Sent: Thursday, June 16, 2016 12:51 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin 
> Subject: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in
> Mtfp6.h
> 
> defined values of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION and
> EFI_MTFTP6_ERRORCODE_FILE_ALREADY_EXISTS are the same. This patch
> corrects the value of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION to 4.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P 
> ---
>  MdePkg/Include/Protocol/Mtftp6.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/Mtftp6.h
> b/MdePkg/Include/Protocol/Mtftp6.h
> index b983660..e0cfc49 100644
> --- a/MdePkg/Include/Protocol/Mtftp6.h
> +++ b/MdePkg/Include/Protocol/Mtftp6.h
> @@ -4,6 +4,8 @@
>multicast TFTP operations.
> 
>Copyright (c) 2008 - 2011, Intel Corporation. All rights reserved.
> +  (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> +
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be
> found at
> @@ -70,7 +72,7 @@ typedef struct _EFI_MTFTP6_TOKEN
> EFI_MTFTP6_TOKEN;
>  ///
>  /// The MTFTPv6 operation was illegal.
>  ///
> -#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 6
> +#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 4
>  ///
>  /// The transfer ID is unknown.
>  ///
> --
> 2.8.3.windows.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

2016-06-15 Thread Subramanian, Sriram (EG Servers Platform SW) 
Reviewed-by: Sriram Subramanian 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde, 
Nagaraj P
Sent: Thursday, June 16, 2016 10:21 AM
To: edk2-devel@lists.01.org
Cc: ting...@intel.com; siyuan...@intel.com; jiaxin...@intel.com
Subject: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

defined values of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION and
EFI_MTFTP6_ERRORCODE_FILE_ALREADY_EXISTS are the same. This patch
corrects the value of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION to 4.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hegde Nagaraj P 
---
 MdePkg/Include/Protocol/Mtftp6.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Protocol/Mtftp6.h b/MdePkg/Include/Protocol/Mtftp6.h
index b983660..e0cfc49 100644
--- a/MdePkg/Include/Protocol/Mtftp6.h
+++ b/MdePkg/Include/Protocol/Mtftp6.h
@@ -4,6 +4,8 @@
   multicast TFTP operations.
 
   Copyright (c) 2008 - 2011, Intel Corporation. All rights reserved.
+  (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -70,7 +72,7 @@ typedef struct _EFI_MTFTP6_TOKENEFI_MTFTP6_TOKEN;
 ///
 /// The MTFTPv6 operation was illegal.
 ///
-#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 6
+#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 4
 ///
 /// The transfer ID is unknown.
 ///
-- 
2.8.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

2016-06-15 Thread Ye, Ting 
Thanks for capturing and fixing the issue.
Reviewed-by: Ye Ting  

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of hegdenag
Sent: Thursday, June 16, 2016 12:51 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin 

Subject: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

defined values of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION and 
EFI_MTFTP6_ERRORCODE_FILE_ALREADY_EXISTS are the same. This patch corrects the 
value of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION to 4.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hegde Nagaraj P 
---
 MdePkg/Include/Protocol/Mtftp6.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Protocol/Mtftp6.h b/MdePkg/Include/Protocol/Mtftp6.h
index b983660..e0cfc49 100644
--- a/MdePkg/Include/Protocol/Mtftp6.h
+++ b/MdePkg/Include/Protocol/Mtftp6.h
@@ -4,6 +4,8 @@
   multicast TFTP operations.
 
   Copyright (c) 2008 - 2011, Intel Corporation. All rights reserved.
+  (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -70,7 +72,7 @@ typedef struct _EFI_MTFTP6_TOKENEFI_MTFTP6_TOKEN;
 ///
 /// The MTFTPv6 operation was illegal.
 ///
-#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 6
+#define EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION 4
 ///
 /// The transfer ID is unknown.
 ///
--
2.8.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel