Reviewed-by: Liming Gao <liming....@intel.com> > -----Original Message----- > From: Ni, Ruiyu > Sent: Saturday, March 3, 2018 1:11 PM > To: edk2-devel@lists.01.org > Cc: Lin, Jie <jie....@intel.com>; Gao, Liming <liming....@intel.com>; Zhu, > Yonghong <yonghong....@intel.com> > Subject: [PATCH v2] MdePkg/DevicePathFromText: Fix byte orders of iSCSI.Lun > > Per UEFI spec, iSCSI.Lun is a 8-byte array with byte #0 in the left. > It means "0102030405060708" should be converted to: > UINT8[8] = {01, 02, 03, 04, 05, 06, 07, 08} > or UINT64 = {0807060504030201} > > Today's implementation wrongly uses the reversed order. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jie Lin <jie....@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Yonghong Zhu <yonghong....@intel.com> > --- > MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > index c66b77ba6c..35a73e83ff 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > @@ -2542,6 +2542,7 @@ DevPathFromTextiSCSI ( > CHAR16 *ProtocolStr; > CHAR8 *AsciiStr; > ISCSI_DEVICE_PATH_WITH_NAME *ISCSIDevPath; > + UINT64 Lun; > > NameStr = GetNextParamStr (&TextDeviceNode); > PortalGroupStr = GetNextParamStr (&TextDeviceNode); > @@ -2560,7 +2561,8 @@ DevPathFromTextiSCSI ( > StrToAscii (NameStr, &AsciiStr); > > ISCSIDevPath->TargetPortalGroupTag = (UINT16) Strtoi (PortalGroupStr); > - Strtoi64 (LunStr, &ISCSIDevPath->Lun); > + Strtoi64 (LunStr, &Lun); > + WriteUnaligned64 ((UINT64 *) &ISCSIDevPath->Lun, SwapBytes64 (Lun)); > > Options = 0x0000; > if (StrCmp (HeaderDigestStr, L"CRC32C") == 0) { > -- > 2.16.1.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel