Reviewed-by: Jaben Carsey <jaben.car...@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, August 19, 2015 2:48 AM
> To: edk2-devel@lists.01.org; leif.lindh...@linaro.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin
> <shumin....@intel.com>; ler...@redhat.com; Ard Biesheuvel
> <ard.biesheu...@linaro.org>
> Subject: [edk2] [PATCH v2 1/2] ShellPkg: force use of AARCH64 small model
> when building DEBUG shell
> Importance: High
> 
> The tiny code model used by AARCH64 only supports binaries of up to
> 1 MB in size. Since the Shell application exceeds that when built in
> DEBUG mode, make sure we build it using the small code model instead.
> 
> Cc: Jaben Carsey <jaben.car...@intel.com>,
> Cc: Shumin Qiu <shumin....@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>
> Tested-by: Leif Lindholm <leif.lindh...@linaro.org>
> ---
>  ShellPkg/Application/Shell/Shell.inf | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.inf
> b/ShellPkg/Application/Shell/Shell.inf
> index f7039369227c..09aecf717bd7 100644
> --- a/ShellPkg/Application/Shell/Shell.inf
> +++ b/ShellPkg/Application/Shell/Shell.inf
> @@ -108,3 +108,9 @@ [Pcd]
>    gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole         ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellSupplier             ## CONSUMES
> 
> +[BuildOptions.AARCH64]
> +  # The tiny code model used by AARCH64 only supports binaries of up to 1
> MB in
> +  # size. Since the Shell application exceeds that when built in DEBUG mode,
> +  # make sure we build it using the small code model instead.
> +  GCC:DEBUG_*_*_CC_FLAGS = -mcmodel=small
> +  GCC:DEBUG_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> --
> 1.9.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to