Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-11-13 Thread Ard Biesheuvel
On 13 November 2017 at 12:42, Supreeth Venkatesh wrote: > On Mon, 2017-11-13 at 12:19 +, Ard Biesheuvel wrote: >> On 13 November 2017 at 12:15, Supreeth Venkatesh >> wrote: >> > >> > On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-11-13 Thread Supreeth Venkatesh
On Mon, 2017-11-13 at 12:19 +, Ard Biesheuvel wrote: > On 13 November 2017 at 12:15, Supreeth Venkatesh > wrote: > > > > On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel wrote: > > > > > > On 13 November 2017 at 11:40, Supreeth Venkatesh > > >

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-11-13 Thread Ard Biesheuvel
On 13 November 2017 at 12:15, Supreeth Venkatesh wrote: > On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel wrote: >> On 13 November 2017 at 11:40, Supreeth Venkatesh >> wrote: >> > >> > On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-11-13 Thread Supreeth Venkatesh
On Mon, 2017-11-13 at 11:48 +, Ard Biesheuvel wrote: > On 13 November 2017 at 11:40, Supreeth Venkatesh > wrote: > > > > On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel wrote: > > > > > > On 25 October 2017 at 17:32, Supreeth Venkatesh > > >

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-11-13 Thread Ard Biesheuvel
On 13 November 2017 at 11:40, Supreeth Venkatesh wrote: > On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel wrote: >> On 25 October 2017 at 17:32, Supreeth Venkatesh >> wrote: >> > >> > PI v1.5 Specification Volume 4 defines Management Mode

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-11-13 Thread Supreeth Venkatesh
On Mon, 2017-11-13 at 10:30 +, Ard Biesheuvel wrote: > On 25 October 2017 at 17:32, Supreeth Venkatesh > wrote: > > > > PI v1.5 Specification Volume 4 defines Management Mode Core > > Interface > > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-11-13 Thread Ard Biesheuvel
On 25 October 2017 at 17:32, Supreeth Venkatesh wrote: > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > means of communicating between drivers outside of MM and MMI >

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-10-26 Thread Supreeth Venkatesh
On Thu, 2017-10-26 at 11:13 +0100, Achin Gupta wrote: > Hi Supreeth, > > some CIL, > > On Wed, Oct 25, 2017 at 05:32:57PM +0100, Supreeth Venkatesh wrote: > > > > PI v1.5 Specification Volume 4 defines Management Mode Core > > Interface > > and defines EFI_MM_COMMUNICATION_PROTOCOL. This

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-10-26 Thread Supreeth Venkatesh
On Thu, 2017-10-26 at 05:05 +, Udit Kumar wrote: > Hi  > > > > > +  Status = gBS->AllocatePages (AllocateAddress, > > +   EfiRuntimeServicesData, > > +   EFI_SIZE_TO_PAGES > > (mNsCommBuffMemRegion.Length), > > + 

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-10-26 Thread Achin Gupta
Hi Supreeth, some CIL, On Wed, Oct 25, 2017 at 05:32:57PM +0100, Supreeth Venkatesh wrote: > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > means of communicating between drivers outside of MM and MMI

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-10-25 Thread Udit Kumar
Hi > + Status = gBS->AllocatePages (AllocateAddress, > + EfiRuntimeServicesData, > + EFI_SIZE_TO_PAGES > (mNsCommBuffMemRegion.Length), > + ); > + if (EFI_ERROR (Status)) { > +DEBUG ((DEBUG_ERROR,