Re: [edk2] [Patch 3/3] MdeModulePkg/BootLogoLib: Use Boot Logo 2 Protocol

2018-02-15 Thread Kinney, Michael D
Sean, Thanks for the feedback. I have posted V2 with this change. Mike From: Sean Brogan [mailto:sean.bro...@microsoft.com] Sent: Tuesday, February 13, 2018 7:21 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Bret Barkelew ; Yao, Jiewen ; Zeng, Star ; Dong, Eric Subject: Re: [Patch 3

Re: [edk2] [Patch 3/3] MdeModulePkg/BootLogoLib: Use Boot Logo 2 Protocol

2018-02-13 Thread Sean Brogan
Mike, Looking over the MdeModulePkg library changes it seems wasteful to call both protocols for Set. In the previously submitted protocol implementation you actually allocate/free memory and copy the buffer in the set routines. For a high resolution screen/logo this could be an expensive op