Re: [edk2] [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
I did the work last year so I didn't do anything but the email this year... > -Original Message- > From: Zeng, Star > Sent: Tuesday, January 08, 2019 5:18 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Zeng, Star > Subject: RE: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib > Importance: High > > How about updating "2018" to "2019"? :) > > > With that, Reviewed-by: Star Zeng . > > Thanks, > Star > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, January 9, 2019 5:58 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J > Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib > > The comments are incorrect for the base version of this lib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jaben Carsey > Cc: Star Zeng > Cc: Jian J Wang > --- > MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > index ab8a60585ee2..8f30c00971eb 100644 > --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > @@ -1,7 +1,7 @@ > /** @file >Library used for sorting routines. > > - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. > + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. > + >This program and the accompanying materials >are licensed and made available under the terms and conditions of the BSD > License >which accompanies this distribution. The full text of the license may be > found at @@ -193,14 +193,12 @@ DevicePathCompare ( } > > /** > - Function to compare 2 strings without regard to case of the characters. > + Not supported in Base version. > > - @param[in] Buffer1Pointer to String to compare. > - @param[in] Buffer2Pointer to second String to compare. > + @param[in] Buffer1 Ignored. > + @param[in] Buffer2 Ignored. > > - @retval 0 Buffer1 equal to Buffer2. > - @return < 0 Buffer1 is less than Buffer2. > - @return > 0 Buffer1 is greater than Buffer2. > + ASSERT and return 0. > **/ > INTN > EFIAPI > @@ -215,14 +213,12 @@ StringNoCaseCompare ( > > > /** > - Function to compare 2 strings. > + Not supported in Base version. > > - @param[in] Buffer1Pointer to String to compare (CHAR16**). > - @param[in] Buffer2Pointer to second String to compare > (CHAR16**). > + @param[in] Buffer1 Ignored. > + @param[in] Buffer2 Ignored. > > - @retval 0 Buffer1 equal to Buffer2. > - @return < 0 Buffer1 is less than Buffer2. > - @return > 0 Buffer1 is greater than Buffer2. > + ASSERT and return 0. > **/ > INTN > EFIAPI > -- > 2.16.2.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
How about updating "2018" to "2019"? :) With that, Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Carsey, Jaben Sent: Wednesday, January 9, 2019 5:58 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib The comments are incorrect for the base version of this lib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey Cc: Star Zeng Cc: Jian J Wang --- MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c index ab8a60585ee2..8f30c00971eb 100644 --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c @@ -1,7 +1,7 @@ /** @file Library used for sorting routines. - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. + This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -193,14 +193,12 @@ DevicePathCompare ( } /** - Function to compare 2 strings without regard to case of the characters. + Not supported in Base version. - @param[in] Buffer1Pointer to String to compare. - @param[in] Buffer2Pointer to second String to compare. + @param[in] Buffer1 Ignored. + @param[in] Buffer2 Ignored. - @retval 0 Buffer1 equal to Buffer2. - @return < 0 Buffer1 is less than Buffer2. - @return > 0 Buffer1 is greater than Buffer2. + ASSERT and return 0. **/ INTN EFIAPI @@ -215,14 +213,12 @@ StringNoCaseCompare ( /** - Function to compare 2 strings. + Not supported in Base version. - @param[in] Buffer1Pointer to String to compare (CHAR16**). - @param[in] Buffer2Pointer to second String to compare (CHAR16**). + @param[in] Buffer1 Ignored. + @param[in] Buffer2 Ignored. - @retval 0 Buffer1 equal to Buffer2. - @return < 0 Buffer1 is less than Buffer2. - @return > 0 Buffer1 is greater than Buffer2. + ASSERT and return 0. **/ INTN EFIAPI -- 2.16.2.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
Reviewed-by: Jian J Wang > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, January 09, 2019 5:58 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J > Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib > > The comments are incorrect for the base version of this lib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jaben Carsey > Cc: Star Zeng > Cc: Jian J Wang > --- > MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > index ab8a60585ee2..8f30c00971eb 100644 > --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > @@ -1,7 +1,7 @@ > /** @file >Library used for sorting routines. > > - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. > + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. >This program and the accompanying materials >are licensed and made available under the terms and conditions of the BSD > License >which accompanies this distribution. The full text of the license may be > found > at > @@ -193,14 +193,12 @@ DevicePathCompare ( > } > > /** > - Function to compare 2 strings without regard to case of the characters. > + Not supported in Base version. > > - @param[in] Buffer1Pointer to String to compare. > - @param[in] Buffer2Pointer to second String to compare. > + @param[in] Buffer1 Ignored. > + @param[in] Buffer2 Ignored. > > - @retval 0 Buffer1 equal to Buffer2. > - @return < 0 Buffer1 is less than Buffer2. > - @return > 0 Buffer1 is greater than Buffer2. > + ASSERT and return 0. > **/ > INTN > EFIAPI > @@ -215,14 +213,12 @@ StringNoCaseCompare ( > > > /** > - Function to compare 2 strings. > + Not supported in Base version. > > - @param[in] Buffer1Pointer to String to compare (CHAR16**). > - @param[in] Buffer2Pointer to second String to compare > (CHAR16**). > + @param[in] Buffer1 Ignored. > + @param[in] Buffer2 Ignored. > > - @retval 0 Buffer1 equal to Buffer2. > - @return < 0 Buffer1 is less than Buffer2. > - @return > 0 Buffer1 is greater than Buffer2. > + ASSERT and return 0. > **/ > INTN > EFIAPI > -- > 2.16.2.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
Reviewed-by: Star Zeng -Original Message- From: Carsey, Jaben Sent: Thursday, November 1, 2018 3:21 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib The comments are incorrect for the base version of this lib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey Cc: Star Zeng Cc: Jian J Wang --- MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c index ab8a60585ee2..8f30c00971eb 100644 --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c @@ -1,7 +1,7 @@ /** @file Library used for sorting routines. - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. + This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -193,14 +193,12 @@ DevicePathCompare ( } /** - Function to compare 2 strings without regard to case of the characters. + Not supported in Base version. - @param[in] Buffer1Pointer to String to compare. - @param[in] Buffer2Pointer to second String to compare. + @param[in] Buffer1 Ignored. + @param[in] Buffer2 Ignored. - @retval 0 Buffer1 equal to Buffer2. - @return < 0 Buffer1 is less than Buffer2. - @return > 0 Buffer1 is greater than Buffer2. + ASSERT and return 0. **/ INTN EFIAPI @@ -215,14 +213,12 @@ StringNoCaseCompare ( /** - Function to compare 2 strings. + Not supported in Base version. - @param[in] Buffer1Pointer to String to compare (CHAR16**). - @param[in] Buffer2Pointer to second String to compare (CHAR16**). + @param[in] Buffer1 Ignored. + @param[in] Buffer2 Ignored. - @retval 0 Buffer1 equal to Buffer2. - @return < 0 Buffer1 is less than Buffer2. - @return > 0 Buffer1 is greater than Buffer2. + ASSERT and return 0. **/ INTN EFIAPI -- 2.16.2.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
