Re: [edk2] [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue

2018-03-07 Thread Laszlo Ersek 
On 03/07/18 06:53, Dandan Bi wrote:
> Boolean values do not need to use explicit comparisons
> to TRUE or FALSE.
> 
> Cc: Eric Dong 
> Cc: Laszlo Ersek 
> Cc: Ruiyu Ni 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi 
> ---
>  UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c 
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> index cc64dbb..27ca911 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> @@ -138,11 +138,11 @@ McaInitialize (
>)
>  {
>MSR_IA32_MCG_CAP_REGISTER  McgCap;
>UINT32 BankIndex;
>  
> -  if (State == TRUE) {
> +  if (State) {
>  McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
>  for (BankIndex = 0; BankIndex < (UINT32) McgCap.Bits.Count; BankIndex++) 
> {
>CPU_REGISTER_TABLE_WRITE64 (
>  ProcessorNumber,
>  Msr,
> 

Reviewed-by: Laszlo Ersek 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue

2018-03-06 Thread Ni, Ruiyu 

On 3/7/2018 1:53 PM, Dandan Bi wrote:

Boolean values do not need to use explicit comparisons
to TRUE or FALSE.

Cc: Eric Dong 
Cc: Laszlo Ersek 
Cc: Ruiyu Ni 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi 
---
  UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c 
b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
index cc64dbb..27ca911 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
@@ -138,11 +138,11 @@ McaInitialize (
)
  {
MSR_IA32_MCG_CAP_REGISTER  McgCap;
UINT32 BankIndex;
  
-  if (State == TRUE) {

+  if (State) {
  McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
  for (BankIndex = 0; BankIndex < (UINT32) McgCap.Bits.Count; BankIndex++) {
CPU_REGISTER_TABLE_WRITE64 (
  ProcessorNumber,
  Msr,


Reviewed-by: Ruiyu Ni 

--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel