Re: [edk2] [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-16 Thread Gerd Hoffmann
Hi, OK, so I forgot to articulate that with the above patch, I'm seeing *both* uhci2 and uhci3, but not uhci1. Basically, if uhciX has an irq_pin less than 2, it won't show up in OSX if booted with ovmf. We're no longer looking at PIIX, this is q35 with ovmf or without. Can you test what

Re: [edk2] [RFC v2 00/15] Introduce Mp Service protocol to UefiCpuPkg

2014-09-16 Thread Fan, Jeff
Fixed link error by adding the following 2 lines in .nasm and adding some type case in source. 1. DEFAULT REL ; (only required for x64 version) 2. SECTION .text IA32 version seemed working well (APs output messages). But X64 version made windows QEMU crashed, I haven't found the root cause by

Re: [edk2] [Patch] Update the BaseTools/Source/Python/Makefile to check for dependent files

2014-09-16 Thread Gao, Liming
Larry: I find some file are still missing in build tool dependency. I update Makefile again. Please help review this patch. Thanks Liming From: Hauch, Larry [mailto:larry.ha...@intel.com] Sent: Friday, September 12, 2014 4:18 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch]

[edk2] [Patch] ShellPkg: Remove redundant quotes in file path string for Shell command parameters

2014-09-16 Thread Qiu, Shumin
Hi Jaben, Could you help to review the patch? It removes the redundant quotes in file path string for Shell command parameters. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.commailto:shumin@intel.com Thanks, Shumin

[edk2] [Patch] ShellPkg: Remove redundant quotes for command 'FOR' in Shell

2014-09-16 Thread Qiu, Shumin
Hi Jaben, Could you help to review the patch? The quote surrounded parameters in 'FOR IN' loop will introduce redundant quotes in command line when using this parameter in subsequent commands. For example: FOR %a IN a b c echo 5 - *%a* ENDFOR Previous script will cause [echo 5 - *a

Re: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics library

2014-09-16 Thread Olivier Martin
You are right. Please find the new version of the patch that should do the right thing. From: Carsey, Jaben [jaben.car...@intel.com] Sent: 21 August 2014 23:06 To: Olivier Martin; edk2-devel@lists.sourceforge.net Cc: Harry Liebel; Carsey, Jaben Subject:

Re: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics library

2014-09-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey jaben.car...@intel.com -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Tuesday, September 16, 2014 9:53 AM To: Carsey, Jaben; edk2-devel@lists.sourceforge.net Cc: Harry Liebel Subject: RE: [edk2] [PATCH] ShellPkg: Specify

Re: [edk2] [Patch] ShellPkg: Do TrimSpace again after StdIn, StdOut, and StdErr are set up.

2014-09-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey jaben.car...@intel.com From: Qiu, Shumin Sent: Tuesday, September 16, 2014 6:27 AM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] ShellPkg: Do TrimSpace again after StdIn, StdOut, and StdErr are set up. Importance: High Hi Jaben, Could

[edk2] [PATCH] ShellPkg: Add support for GCC stack protector to ARM

2014-09-16 Thread Olivier Martin
Dear ShellPkg maintainer, please find the attached patch that adds stack protector support to ARM architecture. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ronald Cron ronald.c...@arm.com Reviewed-By: Olivier Martin olivier.mar...@arm.com Best Regards, Olivier --

Re: [edk2] [Patch] ShellPkg: Use compare operator for non-Boolean comparisons

2014-09-16 Thread Carsey, Jaben
Reviewed-By: Jaben Carsey jaben.car...@inte.com From: Qiu, Shumin Sent: Monday, September 15, 2014 6:46 PM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] ShellPkg: Use compare operator for non-Boolean comparisons Importance: High Hi Jaben, Could you help to

Re: [edk2] [PATCH 2/2] MdeModulePkg: CoreStall: improve accuracy in iterating branch

2014-09-16 Thread Scott Duplichan
Tian, Feng [mailto:feng.t...@intel.com] wrote: ]Hi, Andrew ] ]The change was proposed to solve incorrect truncation and overflow issue on old revision. ] ]The original code is: ] Counter = (UINT32) DivU64x32Remainder ( ] Microseconds * 10, ]

Re: [edk2] [PATCH 2/2] MdeModulePkg: CoreStall: improve accuracy in iterating branch

2014-09-16 Thread Andrew Fish
f On Sep 16, 2014, at 10:53 AM, Scott Duplichan sc...@notabs.org wrote: Tian, Feng [mailto:feng.t...@intel.com] wrote: ]Hi, Andrew ] ]The change was proposed to solve incorrect truncation and overflow issue on old revision. ] ]The original code is: ] Counter = (UINT32)

Re: [edk2] [Patch] ShellPkg: Remove redundant quotes for command 'FOR' in Shell

2014-09-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey jaben.car...@intel.com From: Qiu, Shumin Sent: Tuesday, September 16, 2014 6:06 AM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] ShellPkg: Remove redundant quotes for command 'FOR' in Shell Importance: High Hi Jaben, Could you help to

Re: [edk2] [patch 0/5] Fix build failures for Microsoft tool chains

2014-09-16 Thread Scott Duplichan
Andrew Fish [mailto:af...@apple.com] wrote: On Sep 15, 2014, at 8:51 PM, Scott Duplichan sc...@notabs.org mailto:sc...@notabs.org wrote: Jordan Justen [ mailto:jljus...@gmail.com mailto:jljus...@gmail.com] wrote: ]On Mon, Sep 15, 2014 at 5:38 PM, Scott Duplichan mailto:sc...@notabs.org

[edk2] EDK2 GenFw

2014-09-16 Thread Brainerd, Mike
I have ported EDK2 to build on aarch64 platform. After fixing Makefile errors and some 'set but not used errors' I got a HelloWorld application to a .dll. When 'BaseTools(GenFw)' go to build .efi file it has problems with conversion to ARM v8. I have looked and cannot find where to post a bug

Re: [edk2] EDK2 GenFw

2014-09-16 Thread Andrew Fish
On Sep 16, 2014, at 2:57 PM, Brainerd, Mike mike.brain...@amd.com wrote: I have ported EDK2 to build on aarch64 platform. After fixing Makefile errors and some ‘set but not used errors’ I got a HelloWorld application to a .dll. When ‘BaseTools(GenFw)’ go to build .efi file it has problems

Re: [edk2] [PATCH 2/2] MdeModulePkg: CoreStall: improve accuracy in iterating branch

2014-09-16 Thread Scott Duplichan
Andrew Fish [mailto:af...@apple.com] wrote: On Sep 16, 2014, at 10:53 AM, Scott Duplichan sc...@notabs.org mailto:sc...@notabs.org wrote: Tian, Feng [ mailto:feng.t...@intel.com mailto:feng.t...@intel.com] wrote: ]Hi, Andrew ] ]The change was proposed to solve incorrect truncation and

Re: [edk2] EDK2 GenFw

2014-09-16 Thread Brainerd, Mike
I downloaded EDK2 yesterday, 'git clone https://github.com/tianocore/edk2'. I have also downloaded 'linaro-edk2' with the same issues. And, it does appear to be relocation issues. Command: build -v This is a truncated output: echo objcopy not needed for

Re: [edk2] EDK2 GenFw

2014-09-16 Thread Olivier Martin
Can you share your HelloWorld sources and say which toolchain (and its version) your are using. From: Brainerd, Mike [mike.brain...@amd.com] Sent: 16 September 2014 23:51 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] EDK2 GenFw I downloaded

Re: [edk2] [Patch] ShellPkg: Remove redundant quotes in file path string for Shell command parameters

2014-09-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey jaben.car...@intel.com From: Qiu, Shumin Sent: Tuesday, September 16, 2014 5:46 AM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] ShellPkg: Remove redundant quotes in file path string for Shell command parameters Importance: High Hi

Re: [edk2] [patch 0/5] Fix build failures for Microsoft tool chains

2014-09-16 Thread Scott Duplichan
Brian J. Johnson [mailto:bjohn...@sgi.com] wrote: ]On 09/15/2014 10:51 PM, Scott Duplichan wrote: ] Jordan Justen [mailto:jljus...@gmail.com] wrote: ] ] ] ]On Mon, Sep 15, 2014 at 5:38 PM, Scott Duplichan sc...@notabs.org wrote: ] ] Jordan Justen [mailto:jljus...@gmail.com] wrote: ] ] ] ] ]I

Re: [edk2] [patch 0/5] Fix build failures for Microsoft tool chains

2014-09-16 Thread Bruce Cran
On Tue, Sep 16, 2014 at 10:02 PM, Scott Duplichan sc...@notabs.org wrote: An excellent idea. I just tried it and it works great. I did the test building on Windows 7 X64. I built several projects for IA32 and X64. They all build without and compiler warning adjustments. One thing DDK3790 has