Re: [edk2] [PATCH V3 0/4] Some improvements on serial terminal
On 07/16/15 04:09, Heyi Guo wrote: > There were some issues when I ran SCT test against Serial IO Protocol > on qemu aarch64, and below patches were made after I went through the > code of TerminalDxe driver and the flow of console devices being > connected. > > V2 is based on TTY terminal patches. > V3 updates comment for PcdDefaultTerminalType. > > Please help review these patches and provide your comments. > > Thanks. > > Heyi Guo (4): > MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType > ArmVirtPkg: Make terminal type consistent > MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default > MdeModulePkg/TerminalDxe: Some improvements > > ArmVirtPkg/ArmVirtQemu.dsc | 8 ++ > EmulatorPkg/EmulatorPkg.dsc| 2 +- > .../Universal/Console/TerminalDxe/Terminal.c | 29 > -- > MdePkg/MdePkg.dec | 3 ++- > 4 files changed, 16 insertions(+), 26 deletions(-) > When you send the next version of a patch series (any series), for each patch: - please pick up the Reviewed-by tags that you got for the patch in the last version, if the patch remains unchanged (or just trivially changed) - or else, if the patch has been changed significantly (or is new), then please document it either in the blurb, or use "git notes" to attach such notes (outside of the commit message) to the patch. (See also git-format-patch --notes.) For example, looking at [PATCH V3 2/4] ArmVirtPkg: Make terminal type consistent now, I got no clue if you changed that patch relative to v2 (which I reviewed), and if so, how. Therefore now I must save both versions of the patch (v2 and v3), compare them, and if I find that v3 is unchanged, or just trivially changed, I have to send Reviewed-by again. If you pick up tags for a repost, and point out the changes per patch, that saves a *lot* of time for reviewers. Thanks Laszlo -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [PATCH V3 0/4] Some improvements on serial terminal
Thanks for your helpful info. On 07/16/2015 02:56 PM, Ard Biesheuvel wrote: > On 16 July 2015 at 04:09, Heyi Guo wrote: >> There were some issues when I ran SCT test against Serial IO Protocol >> on qemu aarch64, and below patches were made after I went through the >> code of TerminalDxe driver and the flow of console devices being >> connected. >> >> V2 is based on TTY terminal patches. >> V3 updates comment for PcdDefaultTerminalType. >> >> Please help review these patches and provide your comments. >> > Hello Heyi, > > Thanks for sending another version of this series. > > I noticed that you didn't add the Reviewed-by's you collected so far. > It is customary to add those to the patches when they have not changed > (or only in a very minor way) since the previous version. This makes > it easier for us poor reviewers to keep track of what goes on. > > So after you split the first patch into two, as requested by Jordan, > could you please make sure you add his Reviewed-by in the way he > requested? I.e,, just to the patch to which it applies? And also round > up the other ones you received over the past week? > > Thanks, > Ard. > > >> Heyi Guo (4): >>MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType >>ArmVirtPkg: Make terminal type consistent >>MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default >>MdeModulePkg/TerminalDxe: Some improvements >> >> ArmVirtPkg/ArmVirtQemu.dsc | 8 ++ >> EmulatorPkg/EmulatorPkg.dsc| 2 +- >> .../Universal/Console/TerminalDxe/Terminal.c | 29 >> -- >> MdePkg/MdePkg.dec | 3 ++- >> 4 files changed, 16 insertions(+), 26 deletions(-) >> >> -- >> 2.1.4 >> -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [PATCH V3 0/4] Some improvements on serial terminal
On 16 July 2015 at 04:09, Heyi Guo wrote: > There were some issues when I ran SCT test against Serial IO Protocol > on qemu aarch64, and below patches were made after I went through the > code of TerminalDxe driver and the flow of console devices being > connected. > > V2 is based on TTY terminal patches. > V3 updates comment for PcdDefaultTerminalType. > > Please help review these patches and provide your comments. > Hello Heyi, Thanks for sending another version of this series. I noticed that you didn't add the Reviewed-by's you collected so far. It is customary to add those to the patches when they have not changed (or only in a very minor way) since the previous version. This makes it easier for us poor reviewers to keep track of what goes on. So after you split the first patch into two, as requested by Jordan, could you please make sure you add his Reviewed-by in the way he requested? I.e,, just to the patch to which it applies? And also round up the other ones you received over the past week? Thanks, Ard. > Heyi Guo (4): > MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType > ArmVirtPkg: Make terminal type consistent > MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default > MdeModulePkg/TerminalDxe: Some improvements > > ArmVirtPkg/ArmVirtQemu.dsc | 8 ++ > EmulatorPkg/EmulatorPkg.dsc| 2 +- > .../Universal/Console/TerminalDxe/Terminal.c | 29 > -- > MdePkg/MdePkg.dec | 3 ++- > 4 files changed, 16 insertions(+), 26 deletions(-) > > -- > 2.1.4 > -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
[edk2] [PATCH V3 0/4] Some improvements on serial terminal
There were some issues when I ran SCT test against Serial IO Protocol on qemu aarch64, and below patches were made after I went through the code of TerminalDxe driver and the flow of console devices being connected. V2 is based on TTY terminal patches. V3 updates comment for PcdDefaultTerminalType. Please help review these patches and provide your comments. Thanks. Heyi Guo (4): MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType ArmVirtPkg: Make terminal type consistent MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default MdeModulePkg/TerminalDxe: Some improvements ArmVirtPkg/ArmVirtQemu.dsc | 8 ++ EmulatorPkg/EmulatorPkg.dsc| 2 +- .../Universal/Console/TerminalDxe/Terminal.c | 29 -- MdePkg/MdePkg.dec | 3 ++- 4 files changed, 16 insertions(+), 26 deletions(-) -- 2.1.4 -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
