Re: [edk2] [PATCH V3 1/4] MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType
On 07/16/15 06:45, Jordan Justen wrote: > Can you just split this into two patches? > > I think we should keep patches confined to updating a single module > unless there is a technical reason to touch separate packages in a > single patch. > > Or, I suppose if you are making the *exact* same change to more than 3 > packages, I guess it seems a little silly to make separate patches. > > On 2015-07-15 19:09:45, Heyi Guo wrote: >> Update comment for PcdDefaultTerminalType, as a new terminal type >> TTYTERM has been added with type value of 4. >> >> The new type is NOT defined in UEFI SPEC v2.5. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Heyi Guo > > In the commit message, you can Cc Andrew and I in the EmulatorPkg > patch here, and git send-email will automatically add the Cc when > sending the email. And please Cc: M: Michael D Kinney M: Liming Gao on the MdePkg patch. Thanks Laszlo > > You can add Reviewed-by: Jordan Justen to > the separate EmulatorPkg patch. > > -Jordan > >> --- >> EmulatorPkg/EmulatorPkg.dsc | 2 +- >> MdePkg/MdePkg.dec | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc >> index e0c6161..dfcd476 100644 >> --- a/EmulatorPkg/EmulatorPkg.dsc >> +++ b/EmulatorPkg/EmulatorPkg.dsc >> @@ -228,7 +228,7 @@ >>gEmulatorPkgTokenSpaceGuid.PcdEmuCpuModel|L"Intel(R) Processor Model" >>gEmulatorPkgTokenSpaceGuid.PcdEmuCpuSpeed|L"3000" >> >> - # 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8 >> + # 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM >>gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1 >> >> [PcdsDynamicDefault.common.DEFAULT] >> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >> index bda6550..598a6d0 100644 >> --- a/MdePkg/MdePkg.dec >> +++ b/MdePkg/MdePkg.dec >> @@ -2012,8 +2012,9 @@ >># 1 - VT100 >># 2 - VT100+ >># 3 - UTF8 >> + # 4 - TTYTERM, NOT defined in UEFI SPEC >># @Prompt Default Terminal Type. >> - # @ValidRange 0x8001 | 0 - 3 >> + # @ValidRange 0x8001 | 0 - 4 >>gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|0|UINT8|0x0024 >> >>## Error level for hardware recorder. >> -- >> 2.1.4 >> -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [PATCH V3 1/4] MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType
Reviewed-by: Liming Gao -Original Message- From: Heyi Guo [mailto:[email protected]] Sent: Thursday, July 16, 2015 10:10 AM To: [email protected] Subject: [edk2] [PATCH V3 1/4] MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType Update comment for PcdDefaultTerminalType, as a new terminal type TTYTERM has been added with type value of 4. The new type is NOT defined in UEFI SPEC v2.5. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- EmulatorPkg/EmulatorPkg.dsc | 2 +- MdePkg/MdePkg.dec | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index e0c6161..dfcd476 100644 --- a/EmulatorPkg/EmulatorPkg.dsc +++ b/EmulatorPkg/EmulatorPkg.dsc @@ -228,7 +228,7 @@ gEmulatorPkgTokenSpaceGuid.PcdEmuCpuModel|L"Intel(R) Processor Model" gEmulatorPkgTokenSpaceGuid.PcdEmuCpuSpeed|L"3000" - # 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8 + # 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1 [PcdsDynamicDefault.common.DEFAULT] diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index bda6550..598a6d0 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -2012,8 +2012,9 @@ # 1 - VT100 # 2 - VT100+ # 3 - UTF8 + # 4 - TTYTERM, NOT defined in UEFI SPEC # @Prompt Default Terminal Type. - # @ValidRange 0x8001 | 0 - 3 + # @ValidRange 0x8001 | 0 - 4 gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|0|UINT8|0x0024 ## Error level for hardware recorder. -- 2.1.4 -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [PATCH V3 1/4] MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType
Can you just split this into two patches? I think we should keep patches confined to updating a single module unless there is a technical reason to touch separate packages in a single patch. Or, I suppose if you are making the *exact* same change to more than 3 packages, I guess it seems a little silly to make separate patches. On 2015-07-15 19:09:45, Heyi Guo wrote: > Update comment for PcdDefaultTerminalType, as a new terminal type > TTYTERM has been added with type value of 4. > > The new type is NOT defined in UEFI SPEC v2.5. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo In the commit message, you can Cc Andrew and I in the EmulatorPkg patch here, and git send-email will automatically add the Cc when sending the email. You can add Reviewed-by: Jordan Justen to the separate EmulatorPkg patch. -Jordan > --- > EmulatorPkg/EmulatorPkg.dsc | 2 +- > MdePkg/MdePkg.dec | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc > index e0c6161..dfcd476 100644 > --- a/EmulatorPkg/EmulatorPkg.dsc > +++ b/EmulatorPkg/EmulatorPkg.dsc > @@ -228,7 +228,7 @@ >gEmulatorPkgTokenSpaceGuid.PcdEmuCpuModel|L"Intel(R) Processor Model" >gEmulatorPkgTokenSpaceGuid.PcdEmuCpuSpeed|L"3000" > > - # 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8 > + # 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM >gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1 > > [PcdsDynamicDefault.common.DEFAULT] > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index bda6550..598a6d0 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -2012,8 +2012,9 @@ ># 1 - VT100 ># 2 - VT100+ ># 3 - UTF8 > + # 4 - TTYTERM, NOT defined in UEFI SPEC ># @Prompt Default Terminal Type. > - # @ValidRange 0x8001 | 0 - 3 > + # @ValidRange 0x8001 | 0 - 4 >gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|0|UINT8|0x0024 > >## Error level for hardware recorder. > -- > 2.1.4 > -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
