Re: [edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network.
Hi, Jaben Add all of possible method types is to avoid failure in old platform and build tool which not support DynamicEx. And current build tool will choose a PCD type by its own policy and the platform owner could override it in platform DSC file. Siyuan -Original Message- From: Carsey, Jaben [mailto:[email protected]] Sent: Thursday, July 16, 2015 1:42 AM To: Zhang, Lubo; Ye, Ting; [email protected] Subject: Re: [edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network. Why add dynamic? Doesn't DynamicEx meet the needs of Dynamic also? > -Original Message- > From: Zhang, Lubo > Sent: Wednesday, July 15, 2015 8:50 AM > To: Fu, Siyuan; Ye, Ting; [email protected] > Subject: [patch] NetworkPkg: Fix bios bootup hang issue when enable > network. > > Add three PCD access method types for module to use the > PcdDhcp6UidType value to fix the issue. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Reviewed-by: Fu Siyuan > --- > NetworkPkg/NetworkPkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec > index 317cf41..52f9609 100644 > --- a/NetworkPkg/NetworkPkg.dec > +++ b/NetworkPkg/NetworkPkg.dec > @@ -67,11 +67,11 @@ > >## Private Key's size. ># @Prompt Private Key's size. > > gEfiNetworkPkgTokenSpaceGuid.PcdIpsecUefiCertificateKeySize|0x3d5|UIN > T32|0x0006 > > -[PcdsDynamicEx] > +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs > 3315 and 6355). ># 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT] ># 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID) ># 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN] > (not supported) ># 03 = DUID Based on Link-layer Address [DUID-LL] (not supported) > -- > 1.9.5.msysgit.1 > > > > -- > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > ___ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > -- > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > ___ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network.
Why add dynamic? Doesn't DynamicEx meet the needs of Dynamic also? > -Original Message- > From: Zhang, Lubo > Sent: Wednesday, July 15, 2015 8:50 AM > To: Fu, Siyuan; Ye, Ting; [email protected] > Subject: [patch] NetworkPkg: Fix bios bootup hang issue when enable > network. > > Add three PCD access method types for module to use the > PcdDhcp6UidType value to fix the issue. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Reviewed-by: Fu Siyuan > --- > NetworkPkg/NetworkPkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec > index 317cf41..52f9609 100644 > --- a/NetworkPkg/NetworkPkg.dec > +++ b/NetworkPkg/NetworkPkg.dec > @@ -67,11 +67,11 @@ > >## Private Key's size. ># @Prompt Private Key's size. > > gEfiNetworkPkgTokenSpaceGuid.PcdIpsecUefiCertificateKeySize|0x3d5|UIN > T32|0x0006 > > -[PcdsDynamicEx] > +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 > and 6355). ># 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT] ># 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID) ># 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN] > (not supported) ># 03 = DUID Based on Link-layer Address [DUID-LL] (not supported) > -- > 1.9.5.msysgit.1 > > > > -- > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that you > need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > ___ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > -- > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > ___ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network.
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Zhang, Lubo Sent: Wednesday, July 15, 2015 8:50 AM To: Fu, Siyuan; Ye, Ting; [email protected] Subject: [patch] NetworkPkg: Fix bios bootup hang issue when enable network. Add three PCD access method types for module to use the PcdDhcp6UidType value to fix the issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan --- NetworkPkg/NetworkPkg.dec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec index 317cf41..52f9609 100644 --- a/NetworkPkg/NetworkPkg.dec +++ b/NetworkPkg/NetworkPkg.dec @@ -67,11 +67,11 @@ ## Private Key's size. # @Prompt Private Key's size. gEfiNetworkPkgTokenSpaceGuid.PcdIpsecUefiCertificateKeySize|0x3d5|UINT32|0x0006 -[PcdsDynamicEx] +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 and 6355). # 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT] # 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID) # 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN] (not supported) # 03 = DUID Based on Link-layer Address [DUID-LL] (not supported) -- 1.9.5.msysgit.1 -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network.
Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Wednesday, July 15, 2015 8:50 AM To: Fu, Siyuan; Ye, Ting; [email protected] Subject: [patch] NetworkPkg: Fix bios bootup hang issue when enable network. Add three PCD access method types for module to use the PcdDhcp6UidType value to fix the issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan --- NetworkPkg/NetworkPkg.dec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec index 317cf41..52f9609 100644 --- a/NetworkPkg/NetworkPkg.dec +++ b/NetworkPkg/NetworkPkg.dec @@ -67,11 +67,11 @@ ## Private Key's size. # @Prompt Private Key's size. gEfiNetworkPkgTokenSpaceGuid.PcdIpsecUefiCertificateKeySize|0x3d5|UINT32|0x0006 -[PcdsDynamicEx] +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 and 6355). # 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT] # 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID) # 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN] (not supported) # 03 = DUID Based on Link-layer Address [DUID-LL] (not supported) -- 1.9.5.msysgit.1 -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network.
Reviewed-by: Fu Siyuan -Original Message- From: Zhang, Lubo Sent: Wednesday, July 15, 2015 8:50 AM To: Fu, Siyuan; Ye, Ting; [email protected] Subject: [patch] NetworkPkg: Fix bios bootup hang issue when enable network. Add three PCD access method types for module to use the PcdDhcp6UidType value to fix the issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan --- NetworkPkg/NetworkPkg.dec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec index 317cf41..52f9609 100644 --- a/NetworkPkg/NetworkPkg.dec +++ b/NetworkPkg/NetworkPkg.dec @@ -67,11 +67,11 @@ ## Private Key's size. # @Prompt Private Key's size. gEfiNetworkPkgTokenSpaceGuid.PcdIpsecUefiCertificateKeySize|0x3d5|UINT32|0x0006 -[PcdsDynamicEx] +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 and 6355). # 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT] # 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID) # 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN] (not supported) # 03 = DUID Based on Link-layer Address [DUID-LL] (not supported) -- 1.9.5.msysgit.1 -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ ___ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
