[Ekiga-devel-list] Lecture de lib/engine/action/

2015-01-05 Thread Julien Puydt
Hi, I finally found some time for ekiga yesterday evening and this morning. It turns out my chat_opal_v314 branch was dead : it didn't rebase cleanly and anyway it was not working and I don't remember anything about it. I'll just start from scratch. I saw my loudmouth code didn't compile

Re: [Ekiga-devel-list] Lecture de lib/engine/action/

2015-01-05 Thread Damien Sandras
Hi, Not much time to enter a lengthy discussion right now. My generic answer would be that it just works, which is already a good starting point. (3) I really think it is very bad that the base class Ekiga::Action has enable/disable methods : the loudmouth presentity knows if it can be

Re: [Ekiga-devel-list] Lecture de lib/engine/action/

2015-01-05 Thread Julien Puydt
Le 05/01/2015 11:46, Damien Sandras a écrit : (6) The fact that a base class isn't purely virtual is annoying... In the rest of the engine, a base class Ekiga::Foo is purely virtual for 100% of cases, and an Ekiga::FooImpl is provided with an implementation to cover 99% of use cases. Don't get

Re: [Ekiga-devel-list] Lecture de lib/engine/action/

2015-01-05 Thread Damien Sandras
Le lundi 05 janvier 2015 à 20:35 +0100, Julien Puydt a écrit : Le 05/01/2015 11:46, Damien Sandras a écrit : (6) The fact that a base class isn't purely virtual is annoying... In the rest of the engine, a base class Ekiga::Foo is purely virtual for 100% of cases, and an Ekiga::FooImpl is