Re: [Elementary-dev-community] [Merge] lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into lp:pantheon-terminal
Attempt to merge into lp:pantheon-terminal failed due to conflicts: text conflict in data/pantheon-terminal.desktop -- https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683 Your team elementary Developer Community is subscribed to branch lp:~elementary-dev-community/pantheon-terminal/fix-1329550. -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : elementary-dev-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
Re: [Elementary-dev-community] [Merge] lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into lp:pantheon-terminal
Review: Approve functionality, code-style Works not, thanks for fixing the code anyway. -- https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683 Your team elementary Developer Community is subscribed to branch lp:~elementary-dev-community/pantheon-terminal/fix-1329550. -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : elementary-dev-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
Re: [Elementary-dev-community] [Merge] lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into lp:pantheon-terminal
Review: Approve -- https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683 Your team elementary Developer Community is subscribed to branch lp:~elementary-dev-community/pantheon-terminal/fix-1329550. -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : elementary-dev-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
Re: [Elementary-dev-community] [Merge] lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into lp:pantheon-terminal
Ok, I managed to get around (2) by initializing Gtk in main() and then setting the dark theme. -- https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683 Your team elementary Developer Community is subscribed to branch lp:~elementary-dev-community/pantheon-terminal/fix-1329550. -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : elementary-dev-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
Re: [Elementary-dev-community] [Merge] lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into lp:pantheon-terminal
1) is not my code, but I can definitely include that change. 2) This may be a granite deficiency, as the about option here works by relying on the Granite.Application's behavior when running with the --about option. I think that when Granite creates the about dialog when the app is already running, the Gtk setting has already been set (in PantheonTerminalWindow.vala), but when it creates the dialog without a running app, no such setting has been made, and it comes up light. I tried setting the dark theme before running the main app, but it did not work. I got this error message: [_LOG_LEVEL_FATAL 16:24:08.038999] [GLib-GObject] g_object_set: assertion 'G_IS_OBJECT (object)' failed [_LOG_LEVEL_FATAL 16:24:08.039074] PantheonTerminal will not function properly. Perhaps a dark_theme value in Granite.Application is necessary? Or am I doing something wrong? I will try to investigate a little later. -- https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683 Your team elementary Developer Community is subscribed to branch lp:~elementary-dev-community/pantheon-terminal/fix-1329550. -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : elementary-dev-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
Re: [Elementary-dev-community] [Merge] lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into lp:pantheon-terminal
Review: Needs Fixing
1. Instead of
43 stdout.printf ("pantheon-terminal: ERROR: " + e.message + "\n");
44
45 return 0;
use
error (e.message);
2. Not sure about the relevant part in the code, but the dark GTK+ theme isn't
active when you start the About-Dialog from the quicklist and no
terminal-instance is already running. In this case the about-window uses the
normal GTK+ theme (so, a white window in elementary).
--
https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683
Your team elementary Developer Community is subscribed to branch
lp:~elementary-dev-community/pantheon-terminal/fix-1329550.
--
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help : https://help.launchpad.net/ListHelp
