Re: [Elementary-dev-community] Granite's IconFactory

2013-04-04 Thread Mario Guerriero
You should take a look at the code. I don't remember how it is used.
—
Sent from Mailbox for iPhone

On Wed, Apr 3, 2013 at 10:56 PM, David Gomes 
wrote:

> Do you know how hard it would be to make Files stop using IconFactory.vala?
> On Mon, Apr 1, 2013 at 7:45 PM, Mario Guerriero  wrote:
>> Files is using it.
>> —
>> Sent from Mailbox  for iPhone
>>
>>
>> On Mon, Apr 1, 2013 at 8:25 PM, Chris Timberlake  wrote:
>>
>>> Is there a way to add compile time warnings to it?
>>>
>>> In the event developers are using it and are unknowing? I'm not
>>> knowledgeable about adding compile time warnings in Vala but it might be
>>> worth it.
>>> On Apr 1, 2013 11:23 AM, "Sergey "Shnatsel" Davidoff" <
>>> ser...@elementaryos.org> wrote:
>>>
 I suggest deprecating it instead of removing it right away.


 2013/4/1 David Gomes 

> I can only remove it when Noise stops using it.
>
>
> On Mon, Apr 1, 2013 at 7:21 PM, Victor  wrote:
>
>> I'm sure Mario has used it in many of his projects.
>>
>> In my humble opinion, that class it not a big deal. It's only a
>> wrapper/facade around one method from GTK+.
>>
>> Would you mind removing the StatusBar class too? It is hacky, ugly and
>> incomplete and only Noise is using it.
>>
>> On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
>> wrote:
>>
>> Hello there,
>>
>> There's a class/object/file in Granite called "IconFactory.vala", you
>> can check it out here -
>> http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala
>> .
>>
>> Is anybody using it and definitely dependent on it?
>>
>> We're considering removing it and I need to know if it's necessary.
>>
>> Best regards,
>> David "Munchor" Gomes
>>
>>
>
> --
> Mailing list: https://launchpad.net/~elementary-dev-community
> Post to : elementary-dev-community@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~elementary-dev-community
> More help   : https://help.launchpad.net/ListHelp
>
>


 --
 Sergey "Shnatsel" Davidoff
 OS architect @ elementary

 --
 Mailing list: https://launchpad.net/~elementary-dev-community
 Post to : elementary-dev-community@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~elementary-dev-community
 More help   : https://help.launchpad.net/ListHelp


>>
>> --
>> Mailing list: https://launchpad.net/~elementary-dev-community
>> Post to : elementary-dev-community@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-03 Thread David Gomes
Do you know how hard it would be to make Files stop using IconFactory.vala?


On Mon, Apr 1, 2013 at 7:45 PM, Mario Guerriero  wrote:

> Files is using it.
> —
> Sent from Mailbox  for iPhone
>
>
> On Mon, Apr 1, 2013 at 8:25 PM, Chris Timberlake  wrote:
>
>> Is there a way to add compile time warnings to it?
>>
>> In the event developers are using it and are unknowing? I'm not
>> knowledgeable about adding compile time warnings in Vala but it might be
>> worth it.
>> On Apr 1, 2013 11:23 AM, "Sergey "Shnatsel" Davidoff" <
>> ser...@elementaryos.org> wrote:
>>
>>> I suggest deprecating it instead of removing it right away.
>>>
>>>
>>> 2013/4/1 David Gomes 
>>>
 I can only remove it when Noise stops using it.


 On Mon, Apr 1, 2013 at 7:21 PM, Victor  wrote:

> I'm sure Mario has used it in many of his projects.
>
> In my humble opinion, that class it not a big deal. It's only a
> wrapper/facade around one method from GTK+.
>
> Would you mind removing the StatusBar class too? It is hacky, ugly and
> incomplete and only Noise is using it.
>
> On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
> wrote:
>
> Hello there,
>
> There's a class/object/file in Granite called "IconFactory.vala", you
> can check it out here -
> http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala
> .
>
> Is anybody using it and definitely dependent on it?
>
> We're considering removing it and I need to know if it's necessary.
>
> Best regards,
> David "Munchor" Gomes
>
>

 --
 Mailing list: https://launchpad.net/~elementary-dev-community
 Post to : elementary-dev-community@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~elementary-dev-community
 More help   : https://help.launchpad.net/ListHelp


>>>
>>>
>>> --
>>> Sergey "Shnatsel" Davidoff
>>> OS architect @ elementary
>>>
>>> --
>>> Mailing list: https://launchpad.net/~elementary-dev-community
>>> Post to : elementary-dev-community@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>
> --
> Mailing list: https://launchpad.net/~elementary-dev-community
> Post to : elementary-dev-community@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~elementary-dev-community
> More help   : https://help.launchpad.net/ListHelp
>
>
-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Mario Guerriero
Files is using it.
—
Sent from Mailbox for iPhone

On Mon, Apr 1, 2013 at 8:25 PM, Chris Timberlake  wrote:

> Is there a way to add compile time warnings to it?
> In the event developers are using it and are unknowing? I'm not
> knowledgeable about adding compile time warnings in Vala but it might be
> worth it.
> On Apr 1, 2013 11:23 AM, "Sergey "Shnatsel" Davidoff" <
> ser...@elementaryos.org> wrote:
>> I suggest deprecating it instead of removing it right away.
>>
>>
>> 2013/4/1 David Gomes 
>>
>>> I can only remove it when Noise stops using it.
>>>
>>>
>>> On Mon, Apr 1, 2013 at 7:21 PM, Victor  wrote:
>>>
 I'm sure Mario has used it in many of his projects.

 In my humble opinion, that class it not a big deal. It's only a
 wrapper/facade around one method from GTK+.

 Would you mind removing the StatusBar class too? It is hacky, ugly and
 incomplete and only Noise is using it.

 On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
 wrote:

 Hello there,

 There's a class/object/file in Granite called "IconFactory.vala", you
 can check it out here -
 http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala
 .

 Is anybody using it and definitely dependent on it?

 We're considering removing it and I need to know if it's necessary.

 Best regards,
 David "Munchor" Gomes


>>>
>>> --
>>> Mailing list: https://launchpad.net/~elementary-dev-community
>>> Post to : elementary-dev-community@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>>
>> --
>> Sergey "Shnatsel" Davidoff
>> OS architect @ elementary
>>
>> --
>> Mailing list: https://launchpad.net/~elementary-dev-community
>> Post to : elementary-dev-community@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Victor

Yes Chris, it is possible.

Vala allows adding annotations to symbols. You only need to add the 
following annotation at the top of the symbol you want to deprecate. 


[Deprecated (replacement = "ReplacementClass", since = "0.3")]
class MyDeprecatedClass { ... }

On Mon, Apr 1, 2013 at 12:25 PM, Chris Timberlake  
wrote:

Is there a way to add compile time warnings to it?

In the event developers are using it and are unknowing? I'm not 
knowledgeable about adding compile time warnings in Vala but it might 
be worth it.


On Apr 1, 2013 11:23 AM, "Sergey "Shnatsel" Davidoff" 
 wrote:

I suggest deprecating it instead of removing it right away.


2013/4/1 David Gomes 

I can only remove it when Noise stops using it.


On Mon, Apr 1, 2013 at 7:21 PM, Victor  
wrote:

I'm sure Mario has used it in many of his projects.

In my humble opinion, that class it not a big deal. It's only a 
wrapper/facade around one method from GTK+.


Would you mind removing the StatusBar class too? It is hacky, ugly 
and incomplete and only Noise is using it.


On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
 wrote:

Hello there,

There's a class/object/file in Granite called "IconFactory.vala", 
you can check it out here - 
http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala.


Is anybody using it and definitely dependent on it?

We're considering removing it and I need to know if it's 
necessary.


Best regards,
David "Munchor" Gomes






--
Mailing list: https://launchpad.net/~elementary-dev-community
Post to     : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp






--
Sergey "Shnatsel" Davidoff
OS architect @ elementary

--
Mailing list: https://launchpad.net/~elementary-dev-community
Post to     : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Victor
My bad, I was actually referring to "deprecating" it. Moving the file 
back into Noise is the logically implied action. I'm sorry for 
deviating the discussion.


Regarding the original topic, I'm assuming that the primary reason for 
the removal (and not deprecation) of IconFactory would be licensing 
issues?


On Mon, Apr 1, 2013 at 12:22 PM, David Gomes  
wrote:

I can only remove it when Noise stops using it.


On Mon, Apr 1, 2013 at 7:21 PM, Victor  
wrote:

I'm sure Mario has used it in many of his projects.

In my humble opinion, that class it not a big deal. It's only a 
wrapper/facade around one method from GTK+.


Would you mind removing the StatusBar class too? It is hacky, ugly 
and incomplete and only Noise is using it.


On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
 wrote:

Hello there,

There's a class/object/file in Granite called "IconFactory.vala", 
you can check it out here - 
http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala.


Is anybody using it and definitely dependent on it?

We're considering removing it and I need to know if it's necessary.

Best regards,
David "Munchor" Gomes






-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Chris Timberlake
Is there a way to add compile time warnings to it?

In the event developers are using it and are unknowing? I'm not
knowledgeable about adding compile time warnings in Vala but it might be
worth it.
On Apr 1, 2013 11:23 AM, "Sergey "Shnatsel" Davidoff" <
ser...@elementaryos.org> wrote:

> I suggest deprecating it instead of removing it right away.
>
>
> 2013/4/1 David Gomes 
>
>> I can only remove it when Noise stops using it.
>>
>>
>> On Mon, Apr 1, 2013 at 7:21 PM, Victor  wrote:
>>
>>> I'm sure Mario has used it in many of his projects.
>>>
>>> In my humble opinion, that class it not a big deal. It's only a
>>> wrapper/facade around one method from GTK+.
>>>
>>> Would you mind removing the StatusBar class too? It is hacky, ugly and
>>> incomplete and only Noise is using it.
>>>
>>> On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
>>> wrote:
>>>
>>> Hello there,
>>>
>>> There's a class/object/file in Granite called "IconFactory.vala", you
>>> can check it out here -
>>> http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala
>>> .
>>>
>>> Is anybody using it and definitely dependent on it?
>>>
>>> We're considering removing it and I need to know if it's necessary.
>>>
>>> Best regards,
>>> David "Munchor" Gomes
>>>
>>>
>>
>> --
>> Mailing list: https://launchpad.net/~elementary-dev-community
>> Post to : elementary-dev-community@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> --
> Sergey "Shnatsel" Davidoff
> OS architect @ elementary
>
> --
> Mailing list: https://launchpad.net/~elementary-dev-community
> Post to : elementary-dev-community@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~elementary-dev-community
> More help   : https://help.launchpad.net/ListHelp
>
>
-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Sergey "Shnatsel" Davidoff
I suggest deprecating it instead of removing it right away.


2013/4/1 David Gomes 

> I can only remove it when Noise stops using it.
>
>
> On Mon, Apr 1, 2013 at 7:21 PM, Victor  wrote:
>
>> I'm sure Mario has used it in many of his projects.
>>
>> In my humble opinion, that class it not a big deal. It's only a
>> wrapper/facade around one method from GTK+.
>>
>> Would you mind removing the StatusBar class too? It is hacky, ugly and
>> incomplete and only Noise is using it.
>>
>> On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
>> wrote:
>>
>> Hello there,
>>
>> There's a class/object/file in Granite called "IconFactory.vala", you can
>> check it out here -
>> http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala
>> .
>>
>> Is anybody using it and definitely dependent on it?
>>
>> We're considering removing it and I need to know if it's necessary.
>>
>> Best regards,
>> David "Munchor" Gomes
>>
>>
>
> --
> Mailing list: https://launchpad.net/~elementary-dev-community
> Post to : elementary-dev-community@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~elementary-dev-community
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Sergey "Shnatsel" Davidoff
OS architect @ elementary
-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread David Gomes
I can only remove it when Noise stops using it.


On Mon, Apr 1, 2013 at 7:21 PM, Victor  wrote:

> I'm sure Mario has used it in many of his projects.
>
> In my humble opinion, that class it not a big deal. It's only a
> wrapper/facade around one method from GTK+.
>
> Would you mind removing the StatusBar class too? It is hacky, ugly and
> incomplete and only Noise is using it.
>
> On Mon, Apr 1, 2013 at 12:06 PM, David Gomes 
> wrote:
>
> Hello there,
>
> There's a class/object/file in Granite called "IconFactory.vala", you can
> check it out here -
> http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala
> .
>
> Is anybody using it and definitely dependent on it?
>
> We're considering removing it and I need to know if it's necessary.
>
> Best regards,
> David "Munchor" Gomes
>
>
-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp


Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Victor

I'm sure Mario has used it in many of his projects.

In my humble opinion, that class it not a big deal. It's only a 
wrapper/facade around one method from GTK+.


Would you mind removing the StatusBar class too? It is hacky, ugly and 
incomplete and only Noise is using it.


On Mon, Apr 1, 2013 at 12:06 PM, David Gomes  
wrote:

Hello there,

There's a class/object/file in Granite called "IconFactory.vala", you 
can check it out here - 
http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala.


Is anybody using it and definitely dependent on it?

We're considering removing it and I need to know if it's necessary.

Best regards,
David "Munchor" Gomes

-- 
Mailing list: https://launchpad.net/~elementary-dev-community
Post to : elementary-dev-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~elementary-dev-community
More help   : https://help.launchpad.net/ListHelp