The elfutils-devel mailinglist is now at sourceware.

2016-12-30 Thread Mark Wielaard
Hi elfutils hackers, The elfutils-devel mailinglist is now hosted at sourceware. https://sourceware.org/ml/elfutils-devel/ Everybody subscribed to the old elfutils-devel hosted at lists.fedorahosted.org has been subscribed to the new list. This is the last message to go to the old list. Everybod

elfutils 0.168 released

2016-12-28 Thread Mark Wielaard
void *. Kevin Cernekee (2): unstrip: Don't try to use unstripped .symtab with stripped .strtab tests: unstrip: Add test for mismatched .strtab sections Mark Wielaard (12): tests: Fix --enable-gcov tests build. Add libdw to LDADD for asm_tsts. libcpu: Fix build of bpf_disasm.c for ke

[PATCH] Initial sourceware.org htdocs.

2016-12-26 Thread Mark Wielaard
U. The Roadmap was years out of date and hasn't been moved over yet. It needs a full rewrite first. Signed-off-by: Mark Wielaard --- DwarfExtensions | 135 + ElflintGNU | 30 ++ default.css | 41 ++

[PATCH] http://elfutils.org/ is now hosted at http://sourceware.org/elfutils/

2016-12-24 Thread Mark Wielaard
, releases, bugs, git and mailinglist to README. Make the --version output of all tools the same by using a common print_version function and update the publicly shown copyright holder to the elfutils developers. Signed-off-by: Mark Wielaard --- CONTRIBUTING| 29

Re: sourceware hosting for elfutils

2016-12-22 Thread Mark Wielaard
On Wed, 2016-12-21 at 19:49 -0500, Frank Ch. Eigler wrote: > Thanks for your patience. Thanks for setting it up! I'll adjust the project files to point to our new sourceware home and do a 0.168 release soon to celebrate. That will be our last release from fedorahosted after which we will only use

Moving from fedorahosted to sourceware and preparing a new release

2016-12-12 Thread Mark Wielaard
Hi hackers, fedorahosted is decommissioning some of the hosting services that the rely on in the new year. I asked sourceware if they could provide elfutils hosting. If that works out I would like to do a 0.168 release with all documentation updated to point to the new home (which will be the las

Re: [PATCH] libelf: Do not cast pointer to integer in gelf_newphdr

2016-12-07 Thread Mark Wielaard
On Thu, 2016-10-13 at 12:28 +0200, Mark Wielaard wrote: > On Tue, 2016-10-11 at 23:12 +0900, Akihiko Odaki wrote: > > unsigned long int is not always capable to have pointer in some cases > > (LLP64, for example). > > This makes sense, but it does change a public API. One

Re: libelf gelf_newehdr and gelf_newphdr return types

2016-12-06 Thread Mark Wielaard
On Tue, Dec 06, 2016 at 09:45:31AM -0700, Ali Bahrami wrote: > > Which is slightly horrible. But neither the Solaris documentation, nor > > the elfutils libelf documentation seem to actually make any promise > > about the return value. It is only implied that, like all gelf > > functions, zero will

Re: libelf gelf_newehdr and gelf_newphdr return types

2016-12-06 Thread Mark Wielaard
On Sat, 2016-12-03 at 23:02 +0100, Kurt Roeckx wrote: > On Sat, Dec 03, 2016 at 02:05:41PM -0700, Ali Bahrami wrote: > > I also googled for these APIs, and found very little of note, > > other than manpages. > > You can search the source in Debian here: > https://codesearch.debian.net/search?q=gel

Re: libelf gelf_newehdr and gelf_newphdr return types

2016-12-06 Thread Mark Wielaard
On Fri, 2016-12-02 at 13:39 -0700, Ali Bahrami wrote: > Although uintptr_t would work, it seems unnecessary. Note that freebsd > already uses 'void *', and surely they build most of the same ELF-related > FOSS code that we might be concerned about, so I think that the libelf > code already has port

libelf gelf_newehdr and gelf_newphdr return types

2016-12-02 Thread Mark Wielaard
Hi, Someone was porting elfutils libelf to Windows64 and noticed that the return types of gelf_newehdr and gelf_newphdr (unsigned long int) is not appropriate on that platform. It uses the LLP64 data model where int and long are both 32bits, while pointers are 64bits. Instead of the more common LP

Re: Trying not call elfutils functions in ABRT under root

2016-12-01 Thread Mark Wielaard
On Thu, 2016-12-01 at 20:44 +, Adam Sulc wrote: > Ptrace process before dropping privileges does not allow me to traverse mem > files. Still problem persists> OK. Do you have a code example and what errors you get? > https://github.com/xsulca00/elfutils-for-satyr/blob/satyr_dwfl_linux_proc_r

Re: [Dwarf-Discuss] Some DWARFv5 draft feedback

2016-12-01 Thread Mark Wielaard
DW_FORM_ref_sup and DW_FORM_line_strp to the list of allowed forms at the end of point 4 opcode_operands_table. Subject: Add DW_AT_encoding to the attribute list for DW_TAG_enumeration_type Name: Mark Wielaard Email: m...@redhat.com Section: Appendix A Page: 255 Type: Improvement It i

Some DWARFv5 draft feedback

2016-11-30 Thread Mark Wielaard
I have been working on elfutils DWARFv5 support based on what GCC7 implements and the current public draft. I haven't had time to implement everything. But since the public comment period was kept short I thought it would be nice to at least document some of the things that I stumbled over. Hopefu

Re: Trying not call elfutils functions in ABRT under root

2016-11-30 Thread Mark Wielaard
Hi Adam, On Wed, 2016-11-30 at 08:00 +, Adam Sulc wrote: > im using elfutils in ABRT program specifically when generating > core_backtrace. According to this > https://github.com/abrt/abrt/issues/890 post, it is not a good idea > using elfutils under root. So I have tried moving as much elfuti

Re: Analyzing process and core dump files in changed root environments

2016-11-30 Thread Mark Wielaard
Hi Jakub, On Tue, 2016-11-29 at 13:37 +0100, h wrote: > I have a question regarding analyzing processes running in a change root > environment or in an own mount namespace with re-mounted /. > I want to debug a process running in a non-system root using elfutils or gdb > from system root, and vic

Re: [PATCH] Only workaround fts.h if we have a bad version that doesn't handle LFS.

2016-11-28 Thread Mark Wielaard
On Wed, Nov 23, 2016 at 08:58:34PM +0100, Mark Wielaard wrote: > Older versions of glibc included an fts implementation that didn't have > Large File System support. We worked around that in linux-kernel-modules.c > by including it early before config.h and then redefining some sy

[PATCH] Only workaround fts.h if we have a bad version that doesn't handle LFS.

2016-11-23 Thread Mark Wielaard
with newer glibc. If possible we want the 64bit fts version always. Signed-off-by: Mark Wielaard --- ChangeLog | 5 + configure.ac | 9 + libdwfl/ChangeLog | 7 ++- libdwfl/linux-kernel-modules.c | 20 +--- 4

Re: [PATCH] readelf: Add optional --symbols[=SECTION] argument to select section name.

2016-11-18 Thread Mark Wielaard
On Thu, 2016-11-17 at 15:45 +0100, Florian Weimer wrote: > On 11/17/2016 03:23 PM, Mark Wielaard wrote: > > +2016-11-17 Mark Wielaard > > + > > + * readelf.c (options): Add optional arg SECTION for symbols. > > + (symbol_table_section): New static variabl

Re: [PATCH] ar: Fix GCC7 -Wformat-length issues.

2016-11-18 Thread Mark Wielaard
On Fri, 2016-11-11 at 13:10 +0100, Mark Wielaard wrote: > On Thu, 2016-11-10 at 18:52 +0100, Mark Wielaard wrote: > > GCC7 adds warnings for snprintf formatting into too small buffers. > > Fix the two issues pointed out by the new warning. The ar header > > fields are fixed l

[PATCH] readelf: Add optional --symbols[=SECTION] argument to select section name.

2016-11-17 Thread Mark Wielaard
Make it possible to display just the symbols from a named symbol section instead of always displaying all symbol sections. https://bugzilla.redhat.com/show_bug.cgi?id=1396092 Signed-off-by: Mark Wielaard --- src/ChangeLog | 7 +++ src/readelf.c | 20

Re: [PATCH] ar: Fix GCC7 -Wformat-length issues.

2016-11-11 Thread Mark Wielaard
On Thu, 2016-11-10 at 18:52 +0100, Mark Wielaard wrote: > GCC7 adds warnings for snprintf formatting into too small buffers. > Fix the two issues pointed out by the new warning. The ar header > fields are fixed length containing left-justified strings without > zero terminator. snp

[PATCH] ar: Fix GCC7 -Wformat-length issues.

2016-11-10 Thread Mark Wielaard
opy into the ar header field) and numbers are decimal strings of fixed 10 chars (-Wformat-length thinks formatting them as size_t might overflow on 64bit arches). Signed-off-by: Mark Wielaard --- src/ChangeLog | 7 +++ src/ar.c | 15 +++ src/arlib.c | 10 +++--- 3 fi

Re: [PATCH] libelf: Always set ELF maxsize when reading an ELF file for sanity checks.

2016-11-10 Thread Mark Wielaard
On Wed, 2016-10-26 at 13:17 +0200, Mark Wielaard wrote: > There are various sanity checks that depend on knowing the file size > of the underlying ELF file which we only used when mmapping the ELF file. > Although we probably won't crash if we use pread to try to read from > t

Re: [PATCH] libdw: Correct spelling of DW_LANG_PLI in dwarf.h.

2016-11-10 Thread Mark Wielaard
On Thu, 2016-10-27 at 10:14 +0200, Mark Wielaard wrote: > Updated patch attached. Which I have now committed to master. Thanks, Mark ___ elfutils-devel mailing list -- elfutils-devel@lists.fedorahosted.org To unsubscribe send an email to elfut

Re: [PATCH] libelf: Sanity check offset and size before trying to malloc and read data.

2016-11-10 Thread Mark Wielaard
On Fri, 2016-10-21 at 15:24 +0200, Mark Wielaard wrote: > Bad sh_off or sh_size could trigger a bad malloc or read. Sanity check > the header values first before trying to malloc a huge buffer or reading > any data that will certainly fail. > > https://bugzilla.redhat.com/show_bug

Re: [PATCH] Add GCC7 -Wimplicit-fallthrough support/fixes.

2016-11-10 Thread Mark Wielaard
On Wed, 2016-11-02 at 13:36 +0100, Mark Wielaard wrote: > GCC7 will have a new -Wimplicit-fallthrough warning. It did catch one > small buglet in elflint option procession. So it seems useful to enable > to make sure all swatch case fallthroughs are deliberate. > > Add configure

[PATCH] Add GCC7 -Wimplicit-fallthrough support/fixes.

2016-11-02 Thread Mark Wielaard
and explicit fallthrough comments where necessary. Signed-off-by: Mark Wielaard --- ChangeLog | 7 ++- backends/ChangeLog | 11 +++ backends/i386_regs.c | 1 + backends/i386_retval.c | 3 +-- backends/linux-core-note.c | 4 ++-- backends

[PATCH 4/6] libdw: Add new DWARF5 tag constants.

2016-10-28 Thread Mark Wielaard
Add DW_TAG_coarray_type, DW_TAG_generic_subrange, DW_TAG_dynamic_type, DW_TAG_call_site, DW_TAG_call_site_parameter, DW_TAG_skeleton_unit, DW_TAG_immutable_type. Just the constants, no further interpretion yet. Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 6 ++ libdw/dwarf.h | 9

[PATCH 6/6] libdw: Add DW_MACRO constants and DW_MACRO_GNU compatibility defines.

2016-10-28 Thread Mark Wielaard
_getmacros currently rejects the new formats. Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 7 libdw/dwarf.h | 38 ++-- libdw/dwarf_getmacros.c | 27 +++--- src/ChangeLog | 9 - src/readelf.c

[PATCH 1/6] libdw: DWARF5 Add DW_CC_pass_by_reference and DW_CC_pass_by_reference.

2016-10-28 Thread Mark Wielaard
Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 4 libdw/dwarf.h | 7 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libdw/ChangeLog b/libdw/ChangeLog index 5c2968b..3525391 100644 --- a/libdw/ChangeLog +++ b/libdw/ChangeLog @@ -1,5 +1,9 @@ 2016-10-22 Mark

[PATCH 5/6] libdw: Handle immutable, packed and shared types in dwarf_peel_type.

2016-10-28 Thread Mark Wielaard
Also update the documentation to explain that any type alias or modifier that doesn't modify, change the structural layout or the way to access the underlying type is peel. Explicitly mention pointer and reference types, which aren't peeled. Signed-off-by: Mark Wielaard

[PATCH 3/6] libdw: Add dwarf_default_lower_bound.

2016-10-28 Thread Mark Wielaard
Add dwarf_default_lower_bound to get the default lower bound for a language when not given as attribute for an subrange type. Implementation extracted from dwarf_aggregate_size. Add a test to check all known language codes are handled. Signed-off-by: Mark Wielaard --- libdw/ChangeLog

Some DWARF5 work

2016-10-28 Thread Mark Wielaard
Hi, You might have seen that there is a draft of DWARF5 out now. Summary of changes: http://dwarfstd.org/Dwarf5Std.php DWARF5 public review pdf: http://dwarfstd.org/doc/DWARF5_Public_Review.pdf Feedback needs to be given by end of next month. So I started looking at it and pushed some patches to

[PATCH 2/6] libdw: DWARF5 Add new DW_LANG codes and default lower array bound.

2016-10-28 Thread Mark Wielaard
Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 11 +++ libdw/dwarf.h| 10 +- libdw/dwarf_aggregate_size.c | 11 +++ 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/libdw/ChangeLog b/libdw/ChangeLog index 3525391..e0141cc

Re: [PATCH] libdw: Correct spelling of DW_LANG_PLI in dwarf.h.

2016-10-27 Thread Mark Wielaard
On Wed, 2016-10-26 at 11:18 -0700, Josh Stone wrote: > On 10/26/2016 10:47 AM, Mark Wielaard wrote: > > On Wed, Oct 26, 2016 at 09:36:31AM -0700, Josh Stone wrote: > >> On 10/26/2016 03:24 AM, Mark Wielaard wrote: > >>> The name used in the standard and o

Re: [PATCH] libdw: Correct spelling of DW_LANG_PLI in dwarf.h.

2016-10-26 Thread Mark Wielaard
On Wed, Oct 26, 2016 at 09:36:31AM -0700, Josh Stone wrote: > On 10/26/2016 03:24 AM, Mark Wielaard wrote: > > The name used in the standard and other DWARF implementations for > > Programming Language One, PL/I, is DW_LANG_PLI (not DW_LANG_PL1). > > [...] > > +Ver

[PATCH] libelf: Always set ELF maxsize when reading an ELF file for sanity checks.

2016-10-26 Thread Mark Wielaard
se us to malloc insane amounts of memory. Always try to get the maxsize when unknown in elf_begin.c (read_file). https://bugzilla.redhat.com/show_bug.cgi?id=1388057 Signed-off-by: Mark Wielaard --- libelf/ChangeLog | 8 ++-- libelf/elf_begin.c | 37 +--

[PATCH] libdw: Correct spelling of DW_LANG_PLI in dwarf.h.

2016-10-26 Thread Mark Wielaard
The name used in the standard and other DWARF implementations for Programming Language One, PL/I, is DW_LANG_PLI (not DW_LANG_PL1). Fix usage in dwarf_aggregate_size. Signed-off-by: Mark Wielaard --- NEWS | 5 + libdw/ChangeLog | 6 ++ libdw/dwarf.h

Re: [PATCH 2/2] tests: unstrip: Add test for mismatched .strtab sections

2016-10-24 Thread Mark Wielaard
On Sun, 2016-10-23 at 10:25 -0700, Kevin Cernekee wrote: > Current unstrip test cases either have no .symtab/.strtab in the > stripped binary, or .strtab sections that are identical between the > stripped and debuginfo binaries. Add a test case where .symtab/.strtab > in the stripped binary contai

Re: [PATCH 1/2] unstrip: Don't try to use unstripped .symtab with stripped .strtab

2016-10-24 Thread Mark Wielaard
On Sun, 2016-10-23 at 10:25 -0700, Kevin Cernekee wrote: > Prematurely matching up the stripped and unstripped .strtab sections > in the "Match each debuginfo" loop can lead to a case where sec->outscn > gets populated for the stripped .strtab, which we normally want to > ignore. This causes the .

[PATCH] libelf: Sanity check offset and size before trying to malloc and read data.

2016-10-21 Thread Mark Wielaard
Bad sh_off or sh_size could trigger a bad malloc or read. Sanity check the header values first before trying to malloc a huge buffer or reading any data that will certainly fail. https://bugzilla.redhat.com/show_bug.cgi?id=1387584 Signed-off-by: Mark Wielaard --- libelf/ChangeLog | 5

Re: [PATCH v3] Do not depend on some non-POSIX features.

2016-10-14 Thread Mark Wielaard
On Fri, 2016-10-14 at 11:03 +0900, Akihiko Odaki wrote: > Define/open code memrchr, rawmemchr, powerof2 and TEMP_FAILURE_RETRY if > not available through system headers. This is the version I already committed. Thanks for posting it, and sorry for the confusion. I should have been clearer that I a

Re: [PATCH] libelf: Do not cast pointer to integer in gelf_newphdr

2016-10-13 Thread Mark Wielaard
On Tue, 2016-10-11 at 23:12 +0900, Akihiko Odaki wrote: > unsigned long int is not always capable to have pointer in some cases > (LLP64, for example). This makes sense, but it does change a public API. One we share with other libelf implementations. So I'll like to discuss this first to make sure

Re: [PATCH] Allow to choose to build shared or static library

2016-10-13 Thread Mark Wielaard
The problem is that libebl depends on loading any backends dynamically as shared libraries. See libebl/eblopenbackend.c. Without the backends various functionality just doesn't work. So you'll have to compile in at least the native/target backend. There is a hacky version of that on the mjw/RH-DTS

Re: [PATCH] Allow to disable components

2016-10-13 Thread Mark Wielaard
On Thu, 2016-10-13 at 11:51 +0200, Mark Wielaard wrote: > We this split up and why do you want to enable/disable these specific > parts? > > I don't think it makes sense to be able to not build the ebl backends > (unless you don't build libasm, libdw and also not the tool

Re: [PATCH] Allow to disable components

2016-10-13 Thread Mark Wielaard
Hi, We this split up and why do you want to enable/disable these specific parts? I don't think it makes sense to be able to not build the ebl backends (unless you don't build libasm, libdw and also not the tools - only libelf doesn't directly use the backends). And obviously various tools won't b

Re: [PATCH v2] Do not depend on some non-POSIX features.

2016-10-13 Thread Mark Wielaard
On Thu, 2016-10-13 at 09:16 +0900, Akihiko Odaki wrote: > Define/open code memrchr, rawmemchr, powerof2 and TEMP_FAILURE_RETRY if > not available through system headers. > > Signed-off-by: Akihiko Odaki > Signed-off-by: Mark Wielaard > --- > ChangeLog | 4

Re: [PATCH] Allow to build for non-ELF target

2016-10-12 Thread Mark Wielaard
Hi, On which platforms have you tested this? What about the testsuite? We have various self-tests that depend on the binaries/libraries being ELF file. We should probably skip those as unsupported then? Thanks, Mark ___ elfutils-devel mailing list -- e

Re: [PATCH] Do not depend on non-POSIX features

2016-10-12 Thread Mark Wielaard
On Wed, 2016-10-12 at 16:22 +0200, Mark Wielaard wrote: > I am no fan of redefining/open coding things which reasonable can be > expected to be provided through normal GNU system headers/libs. But > these seem fairly minor. However if there are larger changes needed we > should prob

Re: [PATCH] Do not depend on non-POSIX features

2016-10-12 Thread Mark Wielaard
] Do not depend on some non-POSIX features. Define/open code memrchr, rawmemchr, powerof2 and TEMP_FAILURE_RETRY if not available through system headers. Signed-off-by: Akihiko Odaki Signed-off-by: Mark Wielaard --- ChangeLog | 4 configure.ac | 3 +++ lib/ChangeLog

Re: [PATCH] lib: Provide MAX and MIN in system.h

2016-10-12 Thread Mark Wielaard
On Tue, 2016-10-11 at 23:06 +0900, Akihiko Odaki wrote: > This change also creates a new header file libeu.h to provide the > prototypes for the function of libeu. That hides the definition of function > crc32, which can conflict with zlib, from libelf. It also prevents mistakes > to refer those fu

Re: [PATCH] strip: Don't remove real symbols from allocated symbol tables.

2016-10-12 Thread Mark Wielaard
On Thu, 2016-10-06 at 11:53 -0700, Josh Stone wrote: > On 10/06/2016 07:18 AM, Mark Wielaard wrote: > > Having a symbol in an allocated symbol table (like .dynsym) that > > points to an unallocated section is wrong. Traditionally strip > > has removed such symbols if they

[PATCH] strip: Don't remove real symbols from allocated symbol tables.

2016-10-06 Thread Mark Wielaard
means rewriting the dynamic segment and hash sections. Since we don't do that, don't remove the symbol (and corrupt the ELF file). Do warn and set the symbol section to SHN_UNDEF. https://bugzilla.redhat.com/show_bug.cgi?id=1380961 Signed-off-by: Mark Wielaard --- src/ChangeLog | 5

Re: bfd_find_inliner_info reports different (wrong) information compared to GDB - off-by-one?

2016-10-05 Thread Mark Wielaard
Hi Milian, On Wed, 2016-10-05 at 17:45 +0200, Milian Wolff wrote: > I'm trying to improve Linux perf report by adding inliner information to the > callstacks it reports, to make the output more easily interpretable when > looking at complicated C++ applications. You might want to take a look at

Re: [PATCH] Fix BPF check for kernels < 3.20

2016-09-07 Thread Mark Wielaard
On Tue, 2016-09-06 at 10:00 -0700, Richard Henderson wrote: > On 09/05/2016 02:21 AM, Mark Wielaard wrote: > > On Wed, 2016-08-31 at 16:21 +0200, Mark Wielaard wrote: > >> > Thanks, that does look like the correct configure check. > >> > > >> > Bu

Re: [PATCH] Fix BPF check for kernels < 3.20

2016-09-05 Thread Mark Wielaard
On Wed, 2016-08-31 at 16:21 +0200, Mark Wielaard wrote: > Thanks, that does look like the correct configure check. > > But it seems that BPF_PSEUDO_MAP_FD is the only missing constant > introduced since 3.18 (when linux/bpf.h was added) that we use. > So maybe we could simply defi

Re: [PATCH] Fix BPF check for kernels < 3.20

2016-08-31 Thread Mark Wielaard
On Tue, 2016-08-30 at 23:38 +0200, Julian Ospald wrote: > -dnl Check if we have for EM_BPF disassembly. > -AC_CHECK_HEADERS(linux/bpf.h) > -AM_CONDITIONAL(HAVE_LINUX_BPF_H, [test "x$ac_cv_header_linux_bpf_h" = > "xyes"]) > +dnl Check if we have for EM_BPF disassembly and it has the > required d

Re: Suprious backtrace-native test failures on ubuntu package builders

2016-08-30 Thread Mark Wielaard
On Tue, 2016-08-30 at 09:34 +0200, Matthias Klose wrote: > after a few retries the build succeeded "unfortunately". Always annoying when we cannot replicate an issue. Thanks for trying. For 0.167 we did remove this specific assert from the testcase since it didn't really provide any useful feedbac

[COMMITTED] tests: Fix --enable-gcov tests build. Add libdw to LDADD for asm_tsts.

2016-08-30 Thread Mark Wielaard
Lukas did another coverage report for elfutils 0.167: https://fedorapeople.org/~lberk/elfutils-coverage/ Which showed --enable-gcov was broken. For the tests we need to link against all libraries used. Signed-off-by: Mark Wielaard --- tests/ChangeLog | 4 tests/Makefile.am | 18

elfutils 0.167 released

2016-08-26 Thread Mark Wielaard
): config: Fix check for argp_parse to pass &argv config: Pass the compiler -Werror during warning detection John Ogness (1): libelf: find 1st section instead of assuming Jose E. Marchesi (1): sparc: fix the printing of hw capabilities object attributes. Mark Wielaard (17): libelf:

[COMMITTED] strip: Use ELF_CHF_FORCE to recompress any sections that were uncompressed.

2016-08-25 Thread Mark Wielaard
Older gcc might create small .debug_pubtype. If such a section is compressed then strip should use ELF_CHF_FORCE to return it to compressed state after it is done with the section. Found by the run-strip-reloc.sh testcase on rhel6. Signed-off-by: Mark Wielaard --- src/ChangeLog | 4 src

[PATCH] tests: Simplify backtrace-native tests. Drop raise jmp patching even for x86_64.

2016-08-25 Thread Mark Wielaard
sents the executable is found we just pick that Dwfl_Module and don't iterate through any of the others. Signed-off-by: Mark Wielaard --- tests/ChangeLog | 16 tests/backtrace-child.c | 18 ++ tests/backtrace.c | 39 +--

[COMMITTED] Regenerate .po files.

2016-08-24 Thread Mark Wielaard
Signed-off-by: Mark Wielaard --- po/ChangeLog | 4 ++ po/de.po | 166 -- po/es.po | 165 - po/ja.po | 164 - po

[COMMITTED] tests: Add testfilesparc64attrs.o.bz2 to EXTRA_DIST.

2016-08-24 Thread Mark Wielaard
Signed-off-by: Mark Wielaard --- tests/ChangeLog | 4 tests/Makefile.am | 1 + 2 files changed, 5 insertions(+) diff --git a/tests/ChangeLog b/tests/ChangeLog index 98a31dd..1d8c5b0 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,3 +1,7 @@ +2016-08-24 Mark Wielaard

[COMMITTED 1/3] Update POTFILES.in

2016-08-19 Thread Mark Wielaard
From: Piotr Dr=C4=85g https://bugzilla.redhat.com/show_bug.cgi?id=3D1368130 Signed-off-by: Piotr Dr=C4=85g --- po/POTFILES.in | 1 + 1 file changed, 1 insertion(+) diff --git a/po/POTFILES.in b/po/POTFILES.in index 93bcf6e..648e682 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -29,6 +29

[COMMITTED 3/3] Updated Polish translation

2016-08-19 Thread Mark Wielaard
From: Piotr Drąg https://bugzilla.redhat.com/show_bug.cgi?id=1368130 Signed-off-by: Piotr Drąg --- po/pl.po | 1162 ++ 1 file changed, 405 insertions(+), 757 deletions(-) diff --git a/po/pl.po b/po/pl.po index 9b30541..4f51fc7 100644

[COMMITTED 2/3] Add --add-comments to XGETTEXT_OPTIONS in Makevars

2016-08-19 Thread Mark Wielaard
From: Piotr Drąg So that translator comments show up in .po files. https://bugzilla.redhat.com/show_bug.cgi?id=1368130 Signed-off-by: Piotr Drąg --- po/Makevars | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/po/Makevars b/po/Makevars index 8a8ebc6..15d5d31 100644 --- a/

Re: [PATCH] Prepare 0.167 release.

2016-08-16 Thread Mark Wielaard
Hi Jose, On Tue, Aug 09, 2016 at 10:58:35PM +0200, Mark Wielaard wrote: > On Tue, Aug 09, 2016 at 01:58:30PM +0200, Jose E. Marchesi wrote: > > Ok for master? > > OK with the following nitpicks below. Did you have time to look at the nitpicks and see if you want to push it wi

Re: [PATCH] libelf: Fix memory leak in elf_compress for mmapped ELF files.

2016-08-16 Thread Mark Wielaard
On Sun, Aug 07, 2016 at 10:38:58PM +0200, Mark Wielaard wrote: > The testcase added to run-strip-reloc.sh for strip-compressed.o showed > a memory leak when ran under valgrind (configure --enable-valgrind). > > For a mmapped ELF file when existing section data was compressed > elf

Re: [PATCH] libdwfl: Fix assert and set in.d_size in dwfl_link_map_report.

2016-08-16 Thread Mark Wielaard
On Fri, Aug 12, 2016 at 11:52:51AM +0200, Mark Wielaard wrote: > When reading the phdrs from a core file segment fails we would try to read > them from the exec. This fallback path contained a faulty assert that the > requested size of the phdrs was still setup. But the core fil

Re: [PATCH] strip: Handle compressed relocation target sections.

2016-08-16 Thread Mark Wielaard
On Sat, Aug 06, 2016 at 03:27:29PM +0200, Mark Wielaard wrote: > binutils 2.27 assembler will create compressed sections for x86 ELF > targets. The linker will decompress them again and it doesn't do this > for any other target. This broke one of the run-strip-reloc.sh self test

Suprious backtrace-native test failures on ubuntu package builders

2016-08-12 Thread Mark Wielaard
Hi Matthias, elfutils hackers, The ubuntu package builders sometimes see failures in backtrace-native and/or backtrace-native-biarch tests. The failures comes from an assert in tests/backtrace.c (see_exec_module): struct see_exec_module { Dwfl_Module *mod; char selfpath[PATH_MAX + 1]; }; sta

[PATCH] libdwfl: Fix assert and set in.d_size in dwfl_link_map_report.

2016-08-12 Thread Mark Wielaard
the number of bytes we want to read again instead of asserting the size. https://bugzilla.redhat.com/show_bug.cgi?id=1365812 Signed-off-by: Mark Wielaard --- libdwfl/ChangeLog | 4 libdwfl/link_map.c | 7 +-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libdwfl

Re: [PATCH] Fix bpf disassembler for _FORTIFY_SOURCE

2016-08-10 Thread Mark Wielaard
On Wed, Aug 10, 2016 at 12:41:21PM +0530, Richard Henderson wrote: > It's illegal to skip positional operands for printf. Rearrange the > printing of the instructions to use exactly the operands required. > > Also, fix printing of mod operations: s/%/%%/ in the print format. > Also, fix printing

Re: [PATCH] Prepare 0.167 release.

2016-08-09 Thread Mark Wielaard
Hi Jose, On Tue, Aug 09, 2016 at 01:58:30PM +0200, Jose E. Marchesi wrote: > Ok for master? OK with the following nitpicks below. > commit c7e007a9f3bd550a2f00e41f303f23175af0dcca > Author: Jose E. Marchesi > Date: Tue Aug 9 04:30:37 2016 -0700 > > sparc: fix the printing of hw capabilit

bpf_disasm format strings vs FORTIFY_SOURCE

2016-08-07 Thread Mark Wielaard
Hi Richard, elfutils hackers, Fedora builds everything with -D_FORTIFY_SOURCE=2 which catches an issue with the bpf_disasm.c printf format strings. It can most easily be seen by compiling with CFLAGS="-g -Og -D_FORTIFY_SOURCE=2" and running the objdump testcase from run-disasm-bpf.sh. It will cras

[PATCH] libelf: Fix memory leak in elf_compress for mmapped ELF files.

2016-08-07 Thread Mark Wielaard
non-mapped files rawdata_base is always freed. For decompressed data rawdata_base is released together with zdata_base. Use the Elf_Scn flag ELF_T_MALLOCED to track whether rawdata_base points to malloced memory and free it in elf_end even for mmapped ELF files. Signed-off-by: Mark Wielaard

[PATCH] strip: Handle compressed relocation target sections.

2016-08-06 Thread Mark Wielaard
first decompressing it before applying relocations and then compressing again if necessary. Add explicit testcases for compressed and uncompressed ET_REL files to run-strip-reloc.sh. Signed-off-by: Mark Wielaard --- src/ChangeLog| 5 + src/strip.c

[PATCH] Prepare 0.167 release.

2016-08-04 Thread Mark Wielaard
index 6a038a2..07e8f57 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2016-08-04 Mark Wielaard + + * configure.ac: Set version to 0.167. + * NEWS: Add 0.167 section. + 2016-07-06 Mark Wielaard * .gitignore: Remove src/ld. ldlex.c, ldscript.c and ldscript.h. diff --

Re: [PATCH] dwelf: Add string table functions from ebl.

2016-08-03 Thread Mark Wielaard
On Fri, 2016-07-08 at 14:45 +0200, Mark Wielaard wrote: > Move the strtab functions from libebl to libdw. Programs often want to > create ELF/DWARF string tables. We don't want (static) linking against > ebl since those are internal functions that might change. >

Re: [PATCH] Remove eu-ld and unused code.

2016-08-03 Thread Mark Wielaard
On Wed, 2016-07-06 at 23:10 +0200, Mark Wielaard wrote: > Nobody has hacked on eu-ld in a very long time. It didn't really work. > And we didn't install it by default in the spec file. Remove sources, > the build rules and any (now) unused code. After a small vacation and som

Re: [PATCH] Add m68k tests

2016-07-11 Thread Mark Wielaard
Hi Andreas, This looks good and all new tests also pass on my x86_64 setup. Pushed to master. Thanks, Mark

Re: [PATCH] unstrip: Fix off by one array access with unstripped_strent.

2016-07-11 Thread Mark Wielaard
On Wed, 2016-07-06 at 21:43 +0200, Mark Wielaard wrote: > When configuring with --enable-sanitize-undefined the latest GCC found > an array out of bounds access when running the un-strip-strmerge.sh test. > We keep an array of section names. But skipped section zero, since it > didn&#

Re: [PATCH] libelf: Allow updating phdrs for any e_type.

2016-07-11 Thread Mark Wielaard
On Wed, 2016-07-06 at 15:46 +0200, Mark Wielaard wrote: > elf[32|64]_updatenull would sanity check the e_type before allowing to > update the phdrs. This prevents creating an ET_REL file with phdrs. It > also prevents creating any vendor specific ELF file having phdrs. We > only che

Re: [PATCH] Remove eu-ld and unused code.

2016-07-08 Thread Mark Wielaard
On Thu, 2016-07-07 at 07:37 -0400, Ulrich Drepper wrote: > On Thu, Jul 7, 2016 at 3:55 AM, Mark Wielaard wrote: > > Yes, you did a lot of work on it. And yes, it does have an unique > > design. Thanks. But your last commit to it was 8 years ago. > > The changes aren't

[PATCH] dwelf: Add string table functions from ebl.

2016-07-08 Thread Mark Wielaard
tions. Signed-off-by: Mark Wielaard --- libasm/ChangeLog | 17 + libasm/Makefile.am| 5 +- libasm/asm_begin.c| 6 +- libasm/asm_end.c | 46 +++-- libasm/asm_newabs

Re: [PATCH] Remove eu-ld and unused code.

2016-07-07 Thread Mark Wielaard
Hi Ulrich, On Wed, 2016-07-06 at 18:04 -0400, Ulrich Drepper wrote: > On Wed, Jul 6, 2016 at 5:10 PM, Mark Wielaard wrote: > > Nobody has hacked on eu-ld in a very long time. It didn't really work. > > And we didn't install it by default in the spec file. Remove sources

[PATCH] unstrip: Fix off by one array access with unstripped_strent.

2016-07-06 Thread Mark Wielaard
(zero) when storing and reading the names. Signed-off-by: Mark Wielaard --- src/ChangeLog | 5 + src/unstrip.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index 21fc7d5..fbe4afc 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3

[PATCH] libelf: Allow updating phdrs for any e_type.

2016-07-06 Thread Mark Wielaard
elf_getphdrnum should simply succeed and return zero. https://bugzilla.redhat.com/show_bug.cgi?id=1352232 Signed-off-by: Mark Wielaard --- libelf/ChangeLog | 7 ++ libelf/elf32_updatenull.c | 15 +--- libelf/elf_getphdrnum.c | 58 +++--- tests/ChangeLog | 8 ++ te

Re: [PATCH] libelf: find 1st section instead of assuming

2016-06-28 Thread Mark Wielaard
On Fri, 2016-06-24 at 15:49 +0200, Mark Wielaard wrote: > Thanks. None of our existing tests cover this. So I adapted one of them > and created a testcase that fails before your fix and succeeds after. > It does the same test for all combinations of ELF class 32/64 and > ELF_C_RDWR[_M

Re: [PATCH v2 0/2] Add support for BPF

2016-06-28 Thread Mark Wielaard
On Wed, 2016-06-22 at 08:57 -0700, Richard Henderson wrote: > On 06/22/2016 07:54 AM, Mark Wielaard wrote: > > Lets push this with that small tweak as soon as the glibc elf.h lands. > > Ok. Pushed! Thanks, Mark

Re: [PATCH] libelf: find 1st section instead of assuming

2016-06-24 Thread Mark Wielaard
ding a section to and "empty" ELF file 32/64 class with ELF_C_RDWR[_MMAP]. Signed-off-by: John Ogness Signed-off-by: Mark Wielaard --- libelf/ChangeLog | 6 + libelf/elf32_updatenull.c | 11 +- libelf/elf_nextscn.c | 38 +++ tests/ChangeLog | 7 ++

Re: [PATCH] libelf: find 1st section instead of assuming

2016-06-23 Thread Mark Wielaard
Hi John, On Thu, 2016-06-23 at 16:03 +0200, John Ogness wrote: > When getting section headers it is assumed that the first section > is on the first section list. However, it is possible that the > first section list only contains the zeroth section, in which > case either illegal memory access oc

Re: [PATCH v2 0/2] Add support for BPF

2016-06-22 Thread Mark Wielaard
On Tue, 2016-06-21 at 15:10 -0700, Richard Henderson wrote: > Changes since v2: > (1) We've got an official number for EM_BPF, > (2) A disassembly test case, > (3) Added a configure test for , > (4) Byte swapping of bpf_insns during disassembly, > (5) ChangeLog entries. This all looks very go

Re: [PATCH] CONTRIBUTING: Extend patch, committer and maintainer guidelines.

2016-06-21 Thread Mark Wielaard
On Fri, Jun 17, 2016 at 02:02:33PM +0200, Mark Wielaard wrote: > On Fri, 2016-06-10 at 14:06 +0200, Mark Wielaard wrote: > > +As a maintainer/committer you should still post patches as described > > +above. And ideally they are reviewed and approved as above. If no > >

Re: [PATCH] CONTRIBUTING: Extend patch, committer and maintainer guidelines.

2016-06-17 Thread Mark Wielaard
On Fri, 2016-06-17 at 15:37 +0300, Dmitry V. Levin wrote: > On Fri, Jun 10, 2016 at 02:06:43PM +0200, Mark Wielaard wrote: > > +The ideal patch contains a ChangeLog entry and a test case for the > > +bug fixed or feature added. The testsuite (make check) is zero FAIL. > > Th

Re: [PATCH] CONTRIBUTING: Extend patch, committer and maintainer guidelines.

2016-06-17 Thread Mark Wielaard
On Fri, 2016-06-10 at 14:06 +0200, Mark Wielaard wrote: > +As a maintainer/committer you should still post patches as described > +above. And ideally they are reviewed and approved as above. If no > +other committer has reviewed or objected to your patch for a week > +you may

[PATCH] CONTRIBUTING: Extend patch, committer and maintainer guidelines.

2016-06-10 Thread Mark Wielaard
Signed-off-by: Mark Wielaard --- CONTRIBUTING | 48 ChangeLog| 4 2 files changed, 52 insertions(+) diff --git a/CONTRIBUTING b/CONTRIBUTING index 3f5e5aa..418b9c7 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -46,3 +46,51 @@ using

Re: example for using libdw(fl) for in-process stack unwinding?

2016-06-10 Thread Mark Wielaard
On Thu, 2016-06-09 at 17:54 +0200, Milian Wolff wrote: > from [1] I got that libdw(fl) can be used for unwinding as an alternative to > libunwind, i.e. `dwfl_getthread_frames()`. Apparently, it is even > considerably > faster in the context of Linux perf. I'd like to try that out and compare it

  1   2   3   4   5   6   7   8   9   10   >