☺ Buildbot (Sourceware): elfutils - build successful (master)

2023-11-02 Thread builder
A restored build has been detected on builder elfutils-fedora-s390x while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/43/builds/245 Build state: build successful Revision: 6902b610939fbe15887905a0e2390c2f46cb1eb9 Worker: fedora-s390x

Re: [PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size)

2023-11-02 Thread Mark Wielaard
Hi Sergei, On Thu, Nov 02, 2023 at 07:58:46PM +, Sergei Trofimovich wrote: > `gcc-14` adde a new -Walloc-size warning that makes sure that size of an > individual element matches size of a pointed type: > > https://gcc.gnu.org/PR71219 > > `elfutils` triggers is on `calloc()` call where

Re: [PATCH 00/14] elfutils: DWARF package (.dwp) file support

2023-11-02 Thread Mark Wielaard
Hi Omar, On Wed, Sep 27, 2023 at 11:20:49AM -0700, Omar Sandoval wrote: > This patch series adds support for DWARF package files to libdw and the > elfutils tools. It supports the GNU DebugFission format for DWARF 4 [1] > and the format standardized in DWARF 5 (section 7.3.5 "DWARF Package >

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-11-02 Thread builder
A new failure has been detected on builder elfutils-fedora-s390x while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/43/builds/244 Build state: failed test (failure) Revision: 7878737f1c60dd444f47b701c208ade0b5a2becf Worker: fedora-s390x

Re: [PATCH 13/14] libdw: Apply DWARF package file section offsets where appropriate

2023-11-02 Thread Mark Wielaard
Hi Omar, On Wed, Sep 27, 2023 at 11:21:02AM -0700, Omar Sandoval wrote: > The final piece of DWARF package file support is that offsets have to be > interpreted relative to the section offset from the package index. > .debug_abbrev.dwo is already covered, so sprinkle around calls to >

Re: [PATCH 12/14] tests: Optionally dump all units in dwarf-getmacros

2023-11-02 Thread Mark Wielaard
Hi Omar, On Wed, Sep 27, 2023 at 11:21:01AM -0700, Omar Sandoval wrote: > If instead of a CU offset an empty string is given as the second > argument, dump all units. Pushed, Mark

Re: [PATCH 11/14] tests: Handle DW_MACRO_{define, undef}_{strx, sup} in dwarf-getmacros

2023-11-02 Thread Mark Wielaard
Hi Omar, On Wed, Sep 27, 2023 at 11:21:00AM -0700, Omar Sandoval wrote: > + * dwarf-getmacros.c (mac): Add DW_MACRO_define_sup, > + DW_MACRO_define_strx, DW_MACRO_undef_sup, and DW_MACRO_undef_strx > + cases to opcode switch statement. Looks sane. Applied and pushed. Thanks, Mark

[PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size)

2023-11-02 Thread Sergei Trofimovich
`gcc-14` adde a new -Walloc-size warning that makes sure that size of an individual element matches size of a pointed type: https://gcc.gnu.org/PR71219 `elfutils` triggers is on `calloc()` call where member size is sued as `1`. elf_newscn.c: In function `elf_newscn`:

Re: [PATCH 10/14] libdw: Try .dwp file in __libdw_find_split_unit()

2023-11-02 Thread Mark Wielaard
Hi Omar, On Wed, Sep 27, 2023 at 11:20:59AM -0700, Omar Sandoval wrote: > Try opening the file in the location suggested by the standard (the > skeleton file name + ".dwp") and looking up the unit in the package > index. The rest is similar to .dwo files, with slightly different > cleanup since

☺ Buildbot (Sourceware): elfutils - build successful (master)

2023-11-02 Thread builder
A restored build has been detected on builder elfutils-fedora-s390x while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/43/builds/242 Build state: build successful Revision: 14c5658acfc24367bc1cf63b0e04b70220bedad2 Worker: fedora-s390x

Re: [PATCH 09/14] libdw, libdwfl: Save original path of ELF file

2023-11-02 Thread Mark Wielaard
Hi Omar, On Wed, 2023-09-27 at 11:20 -0700, Omar Sandoval wrote: > libdw and libdwfl currently save the path of the directory containing > the ELF file to use when searching for alt and dwo files. To search for > dwp files, we need the file name too. Add an elfpath field to Dwarf, > and set the

Re: [PATCH] readelf: Support .gdb_index version 9

2023-11-02 Thread Aaron Merey
On Thu, Nov 2, 2023 at 10:20 AM Frank Ch. Eigler wrote: > > > BTW the description of the gdb_index at the top > > https://sourceware.org/gdb/current/onlinedocs/gdb/Index-Section-Format.html > > doesn't resolve anymore. It is now > >

Re: [PATCH] readelf: Support .gdb_index version 9

2023-11-02 Thread Frank Ch. Eigler
Hi - > OK. BTW the description of the gdb_index at the top > https://sourceware.org/gdb/current/onlinedocs/gdb/Index-Section-Format.html > doesn't resolve anymore. It is now > https://sourceware.org/gdb/current/onlinedocs/gdb.html/Index-Section-Format.html Added another httpd redirect to make

[Bug general/30975] elfutils incorrectly reports core files with non-contiguous segments

2023-11-02 Thread pablogsal at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30975 --- Comment #2 from Pablo Galindo Salgado --- Maybe a first attempt to improve the situation could be to not eagerly remove "colliding" modules but either warn or take a callback to act on them or some way to deactivate that behavior as

[Bug general/30975] elfutils incorrectly reports core files with non-contiguous segments

2023-11-02 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30975 Mark Wielaard changed: What|Removed |Added Last reconfirmed||2023-11-02

[Bug libdw/30980] offline.c:53: dwfl_offline_section_address: Assertion `mod->e_type == ET_REL' failed.

2023-11-02 Thread amerey at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30980 --- Comment #7 from Aaron Merey --- (In reply to Mark Wielaard from comment #6) > We should go over all asserts in the library code and rewrite/remove them. > It is never a good thing to trigger an abort in library code. I created a PR for

[Bug general/31027] New: Remove asserts from library code

2023-11-02 Thread amerey at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=31027 Bug ID: 31027 Summary: Remove asserts from library code Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 Component: general

[Bug tools/30986] Bug Report: elfutils eu-addr2line not working correctly with Rust inline functions

2023-11-02 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30986 Mark Wielaard changed: What|Removed |Added CC||mark at klomp dot org Last

[Bug libdw/28148] eu-addr2line reports function name of the caller when code is inlined

2023-11-02 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=28148 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[Bug libdw/30948] src/stack doesn't show source inforamtion if the target is compiled with clang

2023-11-02 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30948 Mark Wielaard changed: What|Removed |Added CC||mark at klomp dot org --- Comment #1

Re: [PATCH] readelf: Support .gdb_index version 9

2023-11-02 Thread Mark Wielaard
Hi Aaron, On Tue, 2023-10-31 at 16:33 -0400, Aaron Merey wrote: > I'd like to merge this patch before the next release. Unless anyone objects > I'll merge it by Friday Nov 3. Looks good to me. Some small comments below. > Commit message: BTW if you add comments like the above after the first

[Bug libdw/30980] offline.c:53: dwfl_offline_section_address: Assertion `mod->e_type == ET_REL' failed.

2023-11-02 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30980 --- Comment #6 from Mark Wielaard --- Thanks, that seems to be the correct thing to do here. Note that there are a couple more asserts on this code path. In particular in __libdwfl_find_elf_build_id there is what apparently is the root of

[PATCH v2 5/5] backends: Add register_info, return_value_location, core_note function on mips

2023-11-02 Thread Ying Huang
From: Ying Huang --- backends/Makefile.am | 3 +- backends/mips_corenote.c | 85 + backends/mips_init.c | 3 + backends/mips_regs.c | 135 +++ backends/mips_retval.c | 196 +++ 5 files changed, 421

[PATCH v2 2/5] readelf: Adapt src/readelf -h/-S/-r/-w/-l/-d/-a on mips

2023-11-02 Thread Ying Huang
From: Ying Huang -h: support show Flags name -S: support show mips related section type -r: support show type of Relocation section -w: can work and can show correct "strp" contents -l: support show mips related program header entry type -d: can show mips related Dynamic type name -a: support

[PATCH v2 3/5] elflint: adapt src/elflint --gnu src/nm on mips

2023-11-02 Thread Ying Huang
From: Ying Huang The errors were: $ src/elflint --gnu src/nm section [ 2] '.MIPS.options' contains unknown flag(s) 0x800 section [ 7] '.dynsym': symbol 165 (_DYNAMIC_LINKING): non-local section symbol section [24] '.got' contains invalid processor-specific flag(s) 0x1000 section [25]

[PATCH v2 1/5] strip: Adapt src/strip -o -f on mips

2023-11-02 Thread Ying Huang
From: Ying Huang In mips64 little-endian, r_info consists of four byte fields(contains three reloc types) and a 32-bit symbol index. In order to adapt GELF_R_SYM and GELF_R_TYPE, need convert raw data to get correct symbol index and type. libelf/elf_getdata.c: Some eu-utils use read-mmap

[PATCH v2 4/5] stack: Fix stack unwind failure on mips

2023-11-02 Thread Ying Huang
From: Ying Huang Add abi_cfi, set_initial_registers_tid, unwind on mips. --- backends/Makefile.am| 3 +- backends/mips_cfi.c | 68 + backends/mips_init.c| 4 ++ backends/mips_initreg.c | 61 ++ backends/mips_unwind.c |

[PATCH v2 0/5] Add support for MIPS

2023-11-02 Thread Ying Huang
This is a series of modifications about MIPS. Support src/readelf, strip, elflint, objdump related tools. Pass all previous test cases that failed due to MIPS non-support. The following are the test results on mips64el. # TOTAL: 271 # PASS: 263 # SKIP: 8 # XFAIL: 0 # FAIL: 0 # XPASS: 0 #