Re: [PATCH] Support nullglob in profile.sh.in

2024-05-13 Thread Dmitry V. Levin
On Mon, May 13, 2024 at 02:04:04PM +0200, Andreas Schwab wrote: > Don't block on stdin when /etc/debuginfod/*.certpath expands to nothing. > > Signed-off-by: Andreas Schwab > --- > config/profile.sh.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Dmitry V. Levin
Hi Frank, On Thu, May 09, 2024 at 07:03:47PM -0400, Frank Ch. Eigler wrote: > Hi - > > > > > What's the purpose of sending proposed patches to the mailing list > > > > if reviews are silently ignored? > > > > > > Please be collegial and don't exaggerate. > > > > The fact is that the review was

Re: [COMMITTED] Makefile.am: Avoid code duplication

2024-05-09 Thread Dmitry V. Levin
On Thu, May 09, 2024 at 07:24:26PM -0400, Aaron Merey wrote: > On Thu, May 9, 2024 at 6:59 PM Dmitry V. Levin wrote: > > On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote: > > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > > > &

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Dmitry V. Levin
On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote: > Hi - > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > > Pushed as commit ca8ad4648197 > > > > What's the purpose of sending proposed patches to the mailing list >

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Dmitry V. Levin
On Wed, May 08, 2024 at 12:28:04PM -0400, Aaron Merey wrote: > On Mon, May 6, 2024 at 4:45 PM Aaron Merey wrote: > > > > Starting with version 2.0, various lcov warnings now trigger an error > > exit. This results in 'make coverage' terminating before completion. > > > > Fix this by invoking

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-06 Thread Dmitry V. Levin
Hi, On Mon, May 06, 2024 at 04:45:27PM -0400, Aaron Merey wrote: > Starting with version 2.0, various lcov warnings now trigger an error > exit. This results in 'make coverage' terminating before completion. > > Fix this by invoking lcov and genhtml with --ignore-errors to prevent > the error

Re: [PATCH] config: Make sure profile.sh succeeds with set -e and set -o pipefail

2024-03-26 Thread Dmitry V. Levin
On Tue, Mar 26, 2024 at 09:49:48PM +0100, Mark Wielaard wrote: > profile.sh might fail with set -o pipefail because: > > cat /dev/null "${prefix}/etc/debuginfod"/*.urls 2>/dev/null | tr '\n' ' ' > > might fail when there isn't an *.urls file the first command in the > pipe fails (the 2>/dev/null

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-10-24 Thread Dmitry V. Levin
On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote: > On 10/24/22 13:41, Dmitry V. Levin wrote: > > On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: > > [...] > >> One TODO I see is that: > >> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzst

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-10-24 Thread Dmitry V. Levin
On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: [...] > One TODO I see is that: > +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd > > should be conditional based on HAVE_ZSTD. But I don't know how to do that? I suppose you're talking about libzstd_LIBS. [...] > diff --git

Re: elfutils does not compile with gcc 12.2.0

2022-08-24 Thread Dmitry V. Levin
On Wed, Aug 24, 2022 at 10:51:13PM +0200, Nick via Elfutils-devel wrote: > I try to compile elfutils on OpenWrt with the newest gcc 12.2.0 version. > However, it fails due to -Werror=use-after-free. A workaround is a patch > that I found on the mailinglist, to disable -Werror >

Re: [PATCH] po: standardize Project-Id-Version to just elfutils

2022-08-05 Thread Dmitry V. Levin
On Fri, Aug 05, 2022 at 07:51:04PM +0200, Mark Wielaard wrote: > The po/pl.po file already just said Project-Id-Version: elfutils\n > Do the same for the other po files which had somewhat odd names. > The generated pot file will still include the version number too. That's obviously correct,

Re: [PATCH] config: Remove unnecessary setting/unsetting of prefix in profiles

2022-06-29 Thread Dmitry V. Levin
Hi, On Wed, Jun 29, 2022 at 08:33:19PM +0200, Mark Wielaard wrote: > Hi Frank, > > On Wed, Jun 29, 2022 at 01:29:04PM -0400, Frank Ch. Eigler wrote: > > > In both profile.csh.in and profile.sh.in we set and then unset > > > prefix, but never use it. > > > > It is used, because the autoconf

Re: [PATCH] tests: Add -ldl to dwfl_proc_attach_LDFLAGS

2021-11-25 Thread Dmitry V. Levin
On Sat, Nov 20, 2021 at 03:18:27PM +0100, Mark Wielaard wrote: > Hi, > > On Sat, Nov 20, 2021 at 01:12:17AM +0300, Dmitry V. Levin wrote: > > On Fri, Nov 19, 2021 at 05:58:19PM +0100, Florian Weimer wrote: > > > It may have to do with --as-nee

Re: [PATCH] tests: Add -ldl to dwfl_proc_attach_LDFLAGS

2021-11-19 Thread Dmitry V. Levin
On Fri, Nov 19, 2021 at 05:58:19PM +0100, Florian Weimer wrote: > * Dmitry V. Levin: > > > Let's make clear what's going on here. First of all, dwfl-proc-attach.c > > does not use dlopen so it doesn't pull it in and doesn't need -ldl. > > In regular builds, dwfl

Re: [PATCH] tests: Add -ldl to dwfl_proc_attach_LDFLAGS

2021-11-18 Thread Dmitry V. Levin
On Thu, Nov 18, 2021 at 10:23:41PM +0100, Mark Wielaard wrote: > dwfl-proc-attach uses (overrides) dlopen (so it does nothing). This > seems to cause a versioned dlopen symbol to be pulled in when building > with LTO. Resulting in a link failure (when dlopen isn't integrated > into libc): > >

Re: [PATCH] dwfl: fix potential overflow when reporting on kernel modules

2021-11-18 Thread Dmitry V. Levin
On Thu, Nov 18, 2021 at 07:44:50PM +, Matthias Maennich via Elfutils-devel wrote: > dwfl_linux_kernel_report_modules_ has an outstanding ancient bug when > reading kernel module information from a modules list file. The target > buffer for the module name was sized too small to hold potential

Re: [patch] PR27783: default debuginfod-urls profile rework

2021-11-10 Thread Dmitry V. Levin
On Thu, Nov 11, 2021 at 12:42:47AM +0300, Dmitry V. Levin wrote: > Hi Frank, > > On Sun, Oct 03, 2021 at 05:33:33PM -0400, Frank Ch. Eigler via Elfutils-devel > wrote: > > commit 0c634f243d266ce8841fd311433d5d79555fabf9 > > Author: Frank Ch. Eigler > > Date:

Re: [patch] PR27783: default debuginfod-urls profile rework

2021-11-10 Thread Dmitry V. Levin
On Thu, Nov 11, 2021 at 12:42:47AM +0300, Dmitry V. Levin wrote: > Hi Frank, > > On Sun, Oct 03, 2021 at 05:33:33PM -0400, Frank Ch. Eigler via Elfutils-devel > wrote: > > commit 0c634f243d266ce8841fd311433d5d79555fabf9 > > Author: Frank Ch. Eigler > > Date:

Re: [patch] PR27783: default debuginfod-urls profile rework

2021-11-10 Thread Dmitry V. Levin
Hi Frank, On Sun, Oct 03, 2021 at 05:33:33PM -0400, Frank Ch. Eigler via Elfutils-devel wrote: > commit 0c634f243d266ce8841fd311433d5d79555fabf9 > Author: Frank Ch. Eigler > Date: Sun Oct 3 17:04:24 2021 -0400 > > PR27783: switch default debuginfod-urls to drop-in style files > >

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Dmitry V. Levin
On Tue, Nov 09, 2021 at 10:04:57AM +0100, Martin Liška wrote: > On 11/9/21 09:58, Dmitry V. Levin wrote: > > Yes, but those who build elfutils with -flto are likely using > > -ffat-lto-objects if they build static libraries. > > Yes, I can confirm that we do that as openSU

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Dmitry V. Levin
Hi Mark, On Tue, Nov 09, 2021 at 12:18:31AM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Mon, Nov 08, 2021 at 01:02:28PM +0300, Dmitry V. Levin wrote: > > > Thanks. This patch was indeed one reason I kept postponing the release, > > > because I didn't have h

Re: [PATCH v2] Improve building with LTO

2021-11-08 Thread Dmitry V. Levin
Hi Mark, On Thu, Nov 04, 2021 at 01:12:29PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, 2021-11-04 at 14:23 +0300, Dmitry V. Levin wrote: > > On Sat, Aug 28, 2021 at 12:31:43PM +0300, Dmitry V. Levin wrote: > > > On Thu, Feb 18, 2021 at 03:38:56AM +01

Re: [PATCH v2] Improve building with LTO

2021-11-04 Thread Dmitry V. Levin
On Sat, Aug 28, 2021 at 12:31:43PM +0300, Dmitry V. Levin wrote: > On Thu, Feb 18, 2021 at 03:38:56AM +0100, Alexander Miller via Elfutils-devel > wrote: > > From: Alexander Miller > > > > Use symver attribute for symbol versioning instead of .symver > > asse

[PATCH v2] findtextrel: do not use unbound alloca

2021-09-09 Thread Dmitry V. Levin
This fixes the following compilation warning: findtextrel.c:184:1: warning: stack usage might be unbounded [-Wstack-usage=] Signed-off-by: Dmitry V. Levin --- v1 introduced a memory leak, so in v2 I rearranged the code a bit to make clear the new code does not introduce any memory leaks

Re: Buildbot failure in Wildebeest Builder on whole buildset

2021-09-07 Thread Dmitry V. Levin
On Tue, Sep 07, 2021 at 02:12:18AM +0200, Mark Wielaard wrote: [...] > Subject: [PATCH] tests: Make sure to wait for initial scan and groom cycle > > At startup the debuginfod server does a scan and groom cycle. Make > sure to wait for that before triggering a new one with SIGUSR1 or > SIGURST2.

[PATCH] findtextrel: do not use unbound alloca

2021-09-06 Thread Dmitry V. Levin
This fixes the following compilation warning: findtextrel.c:184:1: warning: stack usage might be unbounded [-Wstack-usage=] Signed-off-by: Dmitry V. Levin --- src/ChangeLog | 5 + src/Makefile.am | 1 - src/findtextrel.c | 31 +-- 3 files changed, 14

[PATCH 2/2] Use xasprintf instead of asprintf followed by error(EXIT_FAILURE)

2021-09-06 Thread Dmitry V. Levin
Signed-off-by: Dmitry V. Levin --- lib/ChangeLog | 3 +++ lib/color.c | 6 ++ src/ChangeLog | 7 +++ src/objdump.c | 17 - src/readelf.c | 14 ++ src/unstrip.c | 8 ++-- 6 files changed, 28 insertions(+), 27 deletions(-) diff --git a/lib/ChangeLog b

[PATCH 1/2] Introduce xasprintf

2021-09-06 Thread Dmitry V. Levin
Similar to other x* functions, xasprintf is like asprintf except that it dies in case of an error. Signed-off-by: Dmitry V. Levin --- lib/ChangeLog | 6 ++ lib/Makefile.am | 2 +- lib/libeu.h | 2 ++ lib/xasprintf.c | 52 + 4 files

[PATCH] Remove redundant casts of memory allocating functions returning void *

2021-09-06 Thread Dmitry V. Levin
Return values of functions returning "void *", e.g. calloc, malloc, realloc, xcalloc, xmalloc, and xrealloc, do not need explicit casts. Signed-off-by: Dmitry V. Levin --- debuginfod/ChangeLog | 5 + debuginfod/debuginfod-client.c | 2 +- lib

[PATCH] src: add -Wno-error=stack-usage= to AM_LDFLAGS

2021-09-05 Thread Dmitry V. Levin
=24498 Signed-off-by: Dmitry V. Levin --- config/ChangeLog | 4 config/eu.am | 2 ++ src/ChangeLog| 4 src/Makefile.am | 2 +- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/config/ChangeLog b/config/ChangeLog index 70a1e923..b2c0af8a 100644 --- a/config/ChangeLog

Re: [PATCH v2] Improve building with LTO

2021-08-28 Thread Dmitry V. Levin
On Thu, Feb 18, 2021 at 03:38:56AM +0100, Alexander Miller via Elfutils-devel wrote: > From: Alexander Miller > > Use symver attribute for symbol versioning instead of .symver > assembler directive when available. Convert to use double @ syntax > for default version in all cases (required when

Re: [PATCH] libdwfl: fix crash when reading link map

2021-06-10 Thread Dmitry V. Levin
On Wed, Jun 09, 2021 at 05:45:57PM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > When read_addrs() was converted was converted from a nested function to > a normal function, there was a mistake in converting "buffer" from a > closure variable to a parameter: we are checking whether the

Re: [PATCH v2] elflint: fix undefined 'buffer_left' reference

2021-06-07 Thread Dmitry V. Levin
> +2021-06-06 Sergei Trofimovich > + > + * elflint.c (buffer_left): Mark as 'static' to avoid external linkage > + failure. > + > 2021-05-12 Dmitry V. Levin > > * elfcompress.c (process_file): Return 1 instead of -1 in case of an > diff --git a/src

Re: [PATCH] elflint: fix undefined 'buffer_left' reference

2021-06-06 Thread Dmitry V. Levin
185..e030de0d 100644 > --- a/src/ChangeLog > +++ b/src/ChangeLog > @@ -1,3 +1,8 @@ > +2021-06-06 Sergei Trofimovich > + > + * elflint.c (buffer_left): Mark as 'inline' to avoid external linkage > + failure. Did you mean 'static'? > + > 2021-05-12 Dmitry V

[PATCH v2] elfcompress: fix exit status in case of an error

2021-05-12 Thread Dmitry V. Levin
n(-) diff --git a/src/ChangeLog b/src/ChangeLog index de130f79..2c7be185 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,8 @@ 2021-05-12 Dmitry V. Levin + * elfcompress.c (process_file): Return 1 instead of -1 in case of an + error. + * elfcompress.c (process_fil

Re: [PATCH] elfcompress: fix exit status in case of an error

2021-05-12 Thread Dmitry V. Levin
Hi Mark, On Wed, May 12, 2021 at 10:29:33PM +0200, Mark Wielaard wrote: > Hi Dmitry, > > On Wed, May 12, 2021 at 04:00:00PM +0000, Dmitry V. Levin wrote: > > Exit status of 255 in case of an error is probably not what elfcompress > > users expect, change it to 1. > &g

Re: [PATCH 1/2] elfcompress: fix exit status in case of "Nothing to do"

2021-05-12 Thread Dmitry V. Levin
On Wed, May 12, 2021 at 03:00:00PM +, Dmitry V. Levin wrote: > When elfcompress decides that no section data needs to be updated and > therefore the file does not have to be rewritten, it still has to exit > with a zero status indicating success. > > Resolves: https://sourcewa

[PATCH] elfcompress: fix exit status in case of an error

2021-05-12 Thread Dmitry V. Levin
n(-) diff --git a/src/ChangeLog b/src/ChangeLog index de130f79..bc6ffc87 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,7 @@ 2021-05-12 Dmitry V. Levin + * elfcompress.c (main): Return 1 instead of -1 in case of an error. + * elfcompress.c (process_file): Remove redundant

[PATCH 2/2] elfcompress: remove redundant assignment

2021-05-12 Thread Dmitry V. Levin
to be updated.") --- src/ChangeLog | 3 +++ src/elfcompress.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index 47c7eb79..de130f79 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,8 @@ 2021-05-12 Dmitry V. Levin +

[PATCH 1/2] elfcompress: fix exit status in case of "Nothing to do"

2021-05-12 Thread Dmitry V. Levin
file if no section data needs to be updated.") --- src/ChangeLog | 4 src/elfcompress.c | 1 + 2 files changed, 5 insertions(+) diff --git a/src/ChangeLog b/src/ChangeLog index c5ecc05b..47c7eb79 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2021-05-12 Dmitr

Re: [PATCH] po: update XGETTEXT_OPTIONS

2021-04-26 Thread Dmitry V. Levin
On Sun, Mar 21, 2021 at 08:00:00AM +, Dmitry V. Levin wrote: > Recognize sgettext as a macro which is used for translations. > > Flag _, N_, and sgettext with pass-c-format. The effect of this > specification is that xgettext will propagate format string > require

[PATCH] po: update XGETTEXT_OPTIONS

2021-03-21 Thread Dmitry V. Levin
. Signed-off-by: Dmitry V. Levin --- po/ChangeLog | 4 po/Makevars | 11 +-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/po/ChangeLog b/po/ChangeLog index 798db019..50439333 100644 --- a/po/ChangeLog +++ b/po/ChangeLog @@ -1,3 +1,7 @@ +2021-03-21 Dmitry V. Levin

Re: [PATCH v3] backends/ppc_initreg.c: include .

2021-02-05 Thread Dmitry V. Levin
02-01 Érico Nogueira > + > + * ppc_initreg.c: Also include . > + > 2020-12-12 Dmitry V. Levin > > * aarch64_retval.c (aarch64_return_value_location): Fix spelling typo > diff --git a/backends/ppc_initreg.c b/backends/ppc_initreg.c > index 0e0d3599..e5

Re: [PATCH v2] libdwfl: use GNU strerror_r only when available.

2021-02-05 Thread Dmitry V. Levin
On Fri, Feb 05, 2021 at 03:46:42PM +0100, Mark Wielaard wrote: > On Tue, 2021-02-02 at 05:56 +0300, Dmitry V. Levin wrote: > > On Mon, Feb 01, 2021 at 09:16:56PM -0300, Érico Nogueira via Elfutils-devel > > wrote: > > [...] > > > I'm not sure if it's a bug in t

Re: [PATCH v2] backends/ppc_initreg.c: include .

2021-02-01 Thread Dmitry V. Levin
> backends/ppc_initreg.c | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/backends/ChangeLog b/backends/ChangeLog > index f22cd57f..eb15c81d 100644 > --- a/backends/ChangeLog > +++ b/backends/ChangeLog > @@ -1,3 +1,7 @@ > +2021-02-01 Érico Nogueira >

Re: [PATCH v2] libdwfl: use GNU strerror_r only when available.

2021-02-01 Thread Dmitry V. Levin
Hi, On Mon, Feb 01, 2021 at 09:16:56PM -0300, Érico Nogueira via Elfutils-devel wrote: [...] > I'm not sure if it's a bug in this configure.ac or this macro, but > _GNU_SOURCE wasn't defined and lead to XSI strerror_r being used on > glibc until I added the trick with CFLAGS and old_CFLAGS. It's

Re: [PATCH v2] Add coverage target

2021-01-12 Thread Dmitry V. Levin
On Tue, Jan 12, 2021 at 12:48:17PM +0100, Mark Wielaard wrote: > On Tue, 2021-01-12 at 07:29 +0300, Dmitry V. Levin wrote: > > Implement a target for capturing code coverage using lcov. > > It is available when elfutils is configured using --enable-gcov.

[PATCH elfutils-htdocs] update-coverage.sh: use "make coverage"

2021-01-11 Thread Dmitry V. Levin
The coverage report is now prepared by "make coverage". Signed-off-by: Dmitry V. Levin --- update-coverage.sh | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/update-coverage.sh b/update-coverage.sh index 46f30ab2..cddfbf24 100755 --- a/update-coverage.sh ++

[PATCH v2] Add coverage target

2021-01-11 Thread Dmitry V. Levin
Implement a target for capturing code coverage using lcov. It is available when elfutils is configured using --enable-gcov. Tested with autoreconf -if && ./configure --enable-maintainer-mode --enable-gcov && make && make check && make coverage Signed-off-by:

Re: [PATCH] tests: add coverage-html target

2021-01-11 Thread Dmitry V. Levin
Hi Mark, On Mon, Jan 11, 2021 at 04:07:38PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Wed, 2020-12-23 at 00:25 +0300, Dmitry V. Levin wrote: > > Implement a target for capturing code coverage using lcov. > > It is available when elfutils is configured using --enable-

[PATCH] tests: add coverage-html target

2020-12-22 Thread Dmitry V. Levin
Implement a target for capturing code coverage using lcov. It is available when elfutils is configured using --enable-gcov. Signed-off-by: Dmitry V. Levin --- Rather than trying to salvage the coverage target, implement a different target for capturing code coverage similar to those I use

Re: [PATCH 1/2] Split top level .gitignore file

2020-12-20 Thread Dmitry V. Levin
On Sun, Dec 20, 2020 at 06:37:36PM +0300, Dmitry V. Levin wrote: > On Sun, Dec 20, 2020 at 04:28:30PM +0100, Mark Wielaard wrote: > > Hi Dmitry, > > > > On Sun, Dec 20, 2020 at 03:11:19PM +0300, Dmitry V. Levin wrote: > > > Move subdirectory parts of the top lev

Re: [PATCH 1/2] Split top level .gitignore file

2020-12-20 Thread Dmitry V. Levin
On Sun, Dec 20, 2020 at 04:28:30PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Sun, Dec 20, 2020 at 03:11:19PM +0300, Dmitry V. Levin wrote: > > Move subdirectory parts of the top level .gitignore into appropriate > > subdirectories. This would be consistent

[PATCH 2/2] Update .gitignore files

2020-12-20 Thread Dmitry V. Levin
Signed-off-by: Dmitry V. Levin --- .gitignore| 2 ++ ChangeLog | 2 ++ config/.gitignore | 2 ++ config/ChangeLog | 2 ++ debuginfod/.gitignore | 1 + debuginfod/ChangeLog | 2 ++ tests/.gitignore | 2 ++ tests/ChangeLog | 2 ++ 8 files changed, 15

[PATCH 1/2] Split top level .gitignore file

2020-12-20 Thread Dmitry V. Levin
-off-by: Dmitry V. Levin --- .gitignore| 157 +- ChangeLog | 4 ++ backends/.gitignore | 1 + backends/ChangeLog| 4 ++ config/.gitignore | 13 config/ChangeLog | 4 ++ debuginfod/.gitignore | 2

Re: [PATCH v2 1/2] libdwfl: use XSI-compliant strerror_r.

2020-12-17 Thread Dmitry V. Levin
On Thu, Dec 17, 2020 at 01:17:40AM -0300, Érico Nogueira wrote: > On Wed Dec 16, 2020 at 9:08 PM -03, Dmitry V. Levin wrote: > > On Wed, Dec 16, 2020 at 07:30:11PM -0300, Érico Nogueira via > > Elfutils-devel wrote: > > > From: Érico Rolim > > > > > >

Re: [PATCH v2 1/2] libdwfl: use XSI-compliant strerror_r.

2020-12-16 Thread Dmitry V. Levin
92 100644 > --- a/libdwfl/ChangeLog > +++ b/libdwfl/ChangeLog > @@ -1,3 +1,7 @@ > +2020-12-16 Érico Nogueira > + > + * dwfl_error.c (strerror_r): Always use the XSI-compliant version. > + > 2020-12-16 Dmitry V. Levin > > * argp-std.c (_): Remove. >

Re: [PATCH] Modernize gettext infrastructure

2020-12-16 Thread Dmitry V. Levin
Hi Mark, On Wed, Dec 16, 2020 at 03:05:54PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Wed, 2020-12-16 at 02:40 +0300, Dmitry V. Levin wrote: > > Switch to use AM_GNU_GETTEXT, AM_GNU_GETTEXT_VERSION, and > > AM_GNU_GETTEXT_REQUIRE_VERSION, this allows to

Re: [PATCH 2/2] Handle SHF_GNU_RETAIN in eu-readelf and eu-elflint.

2020-12-16 Thread Dmitry V. Levin
On Sat, Dec 12, 2020 at 11:38:55PM +0100, Mark Wielaard wrote: > readelf -S now shows 'R' when SHF_GNU_RETAIN is set. > elflint accepts SHF_GNU_RETAIN when set on section in --gnu mode. > > Signed-off-by: Mark Wielaard > --- > src/ChangeLog | 5 > src/elflint.c

Re: [PATCH 1/2] libelf: Sync elf.h from glibc.

2020-12-16 Thread Dmitry V. Levin
On Sat, Dec 12, 2020 at 11:38:54PM +0100, Mark Wielaard wrote: > Adds SHF_GNU_RETAIN. This is obviously OK. -- ldv

[PATCH 3/4] libcpu: consistently use _(Str) instead of gettext(Str)

2020-12-16 Thread Dmitry V. Levin
@ -1,3 +1,8 @@ +2020-12-16 Dmitry V. Levin + + * i386_lex.l (invalid_char): Replace gettext(...) with _(...). + * i386_parse.y (yyerror): Likewise. + 2020-12-12 Dmitry V. Levin * bpf_disasm.c (bswap_bpf_insn): Fix spelling typo in comment. diff --git a/libcpu/i386_lex.l

[PATCH 2/4] lib: consistently use _(Str) instead of gettext(Str)

2020-12-16 Thread Dmitry V. Levin
ngeLog @@ -1,5 +1,10 @@ 2020-12-16 Dmitry V. Levin + * color.c (parse_opt): Replace gettext(...) and + dgettext("elfutils, ...) with _(...). + * printversion.c (print_version): Replace gettext(...) with _(...). + * system.h (sgettext): Likewise. + * e

[PATCH 1/4] Consistently define _(Str) using dgettext ("elfutils", Str)

2020-12-16 Thread Dmitry V. Levin
) and _(Str) macros from other files to avoid conflicts and redundancies. The next step is to replace all uses of gettext(Str) with _(Str). Signed-off-by: Dmitry V. Levin --- lib/ChangeLog | 5 + lib/eu-config.h | 3 ++- lib/xmalloc.c | 4 libasm/ChangeLog| 4

[PATCH] libebl: consistently use _(Str) instead of gettext(Str)

2020-12-15 Thread Dmitry V. Levin
a/libebl/ChangeLog b/libebl/ChangeLog index 04e9cd49..e0862ec3 100644 --- a/libebl/ChangeLog +++ b/libebl/ChangeLog @@ -1,3 +1,17 @@ +2020-12-15 Dmitry V. Levin + + * eblbackendname.c (ebl_backend_name): Replace gettext(...) with _(...). + * eblcorenotetypename.c (ebl_core_note_

Q: splitting the top level .gitignore file

2020-12-15 Thread Dmitry V. Levin
On Wed, Dec 16, 2020 at 02:40:32AM +0300, Dmitry V. Levin wrote: [...] > Use this opportunity to create separate .gitignore files for m4/ and po/ > directories. By the way, what do you think about moving subdirectory parts of the top level .gitignore file into subdirectories? This

Re: [PATCH] elflint: Always print symbol name (if known) in error messages.

2020-12-15 Thread Dmitry V. Levin
On Tue, Dec 15, 2020 at 09:52:40PM +0100, Mark Wielaard wrote: > Adding the symbol name associated with the symbol index number > makes the error messages a little bit more useful. We used to say: > > section [59] '.symtab': symbol 9: st_value out of bounds > > But now says: > > section [59]

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
Hi, On Tue, Dec 15, 2020 at 03:14:27PM -0500, Frank Ch. Eigler wrote: > Hi - > > > I think it is too early to switch to autoconf 2.70. Currently we > > require autoconf 2.63 and automake 1.11. We could probably upgrade to > > autconf 2.69 and automake 1.13, but that doesn't seem to help with > >

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
On Tue, Dec 15, 2020 at 04:07:02PM +0100, Mark Wielaard wrote: > On Tue, 2020-12-15 at 17:40 +0300, Dmitry V. Levin wrote: > > Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4", > > that is enough for autoreconf to do the right thing. > > But is that a goo

[PATCH 2/2] m4: remove unneeded Makefile.am

2020-12-15 Thread Dmitry V. Levin
m4 files do not have to listed in EXTRA_DIST, in fact, biarch.m4 has not been listed since its very beginning in 2013, and nobody seems to have noticed so far. Tested with autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck Signed

[PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4", that is enough for autoreconf to do the right thing. Tested with autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck Signed-off-by: Dmitry V. Levin --- ChangeLog| 4

[PATCH 12/12] Fix spelling typos in NEWS, NOTES, TODO, and in comments of configure.ac

2020-12-12 Thread Dmitry V. Levin
rely suport -> support tranformation -> transformation Signed-off-by: Dmitry V. Levin --- ChangeLog| 7 +++ NEWS | 18 +- NOTES| 4 ++-- TODO | 2 +- configure.ac | 6 +++--- libebl/ChangeLog | 2 +- 6 files changed, 23

[PATCH 11/12] tests: fix spelling typos in error diagnostics and comments

2020-12-12 Thread Dmitry V. Levin
Cannnot -> Cannot decriptors -> descriptors experssions -> expressions explit -> explicit falg -> flag irrelevent -> irrelevant mininum -> minimum outselves -> ourselves proces -> process versio -> version Signed-off-by: Dmitry V. Levin --- tests/Ch

[PATCH 10/12] src: fix spelling typos in comments and ChangeLog

2020-12-12 Thread Dmitry V. Levin
Indeces -> Indices adress -> address affort -> afford dont' -> don't futher -> further higest -> highest indeces -> indices interate -> iterate occured -> occurred overlow -> overflow sectin -> section succesful -> successful teminated -> terminated S

[PATCH 09/12] libelf: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
Auxialiary -> Auxiliary constucted -> constructed desriptor -> descriptor endianess -> endianness responsibilty -> responsibility sufficent -> sufficient elf.h comes from glibc and therefore is excluded. Signed-off-by: Dmitry V. Levin --- libelf/ChangeLog | 11 +

[PATCH 08/12] libdwfl: fix spelling typos in comments and ChangeLog

2020-12-12 Thread Dmitry V. Levin
adresses -> addresses boundery -> boundary explictly -> explicitly fo -> for layed -> laid partical -> particular setion -> section substract -> subtract wil -> will Signed-off-by: Dmitry V. Levin --- libdwfl/ChangeLog | 13 ++--- libdwfl/

[PATCH 07/12] libdwelf: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
algorith -> algorithm occured -> occurred Signed-off-by: Dmitry V. Levin --- libdwelf/ChangeLog | 3 +++ libdwelf/dwelf_strtab.c | 2 +- libdwelf/libdwelf.h | 4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libdwelf/ChangeLog b/libdwelf/ChangeLog index 9d

[PATCH 05/12] libcpu: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
layed -> laid adressing -> addressing Signed-off-by: Dmitry V. Levin --- libcpu/ChangeLog | 5 + libcpu/bpf_disasm.c | 2 +- libcpu/i386_disasm.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libcpu/ChangeLog b/libcpu/ChangeLog index a342b7f6..000105bf

[PATCH 04/12] libasm: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
endianess -> endianness setion -> section Signed-off-by: Dmitry V. Levin --- libasm/ChangeLog | 5 + libasm/asm_begin.c | 2 +- libasm/asm_end.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libasm/ChangeLog b/libasm/ChangeLog index 6268b26c..78f1baa4

[PATCH 03/12] config: fix spelling typos in comments and %changelog

2020-12-12 Thread Dmitry V. Levin
directoy -> directory fo -> for funtions -> functions ist -> is mutliple -> multiple priviliges -> privileges reenable -> re-enable Signed-off-by: Dmitry V. Levin --- config/10-default-yama-scope.conf | 2 +- config/ChangeLog | 6 ++ config/elfutils.s

[PATCH 02/12] backends: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
adress -> address sigle -> single Signed-off-by: Dmitry V. Levin --- backends/ChangeLog| 6 ++ backends/aarch64_retval.c | 2 +- backends/ppc_cfi.c| 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/backends/ChangeLog b/backends/ChangeLog index e8

[PATCH 00/12] Fix spelling typos in comments, tests, and text files

2020-12-12 Thread Dmitry V. Levin
This is the least significant part of all spelling fixes, most users won't notice any difference at all, but it still makes sense to use correct spelling. Dmitry V. Levin (12): debuginfod: fix spelling typos in error diagnostics and comments backends: fix spelling typos in comments config

[PATCH] doc: fix spelling typos

2020-12-11 Thread Dmitry V. Levin
filesytem -> filesystem requries -> requires hte -> the recieve -> receive varients -> variants preceeded -> preceded Signed-off-by: Dmitry V. Levin --- doc/ChangeLog | 7 +++ doc/debuginfod.8| 2 +- doc/debuginfod_find_debuginfo

[PATCH] Remove unused tests/configure.ac

2020-12-10 Thread Dmitry V. Levin
644 tests/configure.ac diff --git a/ChangeLog b/ChangeLog index def6279a..92efa22f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2020-12-11 Dmitry V. Levin + * configure.ac (AM_CONDITIONAL): Remove HAVE_LIBASM and STANDALONE. + * configure.ac: Rewrite argp ch

[PATCH] configure.ac: fix typo in error diagnostics

2020-12-10 Thread Dmitry V. Levin
Fixes: da855fc9c ("Support building when fts and obstack aren't part of libc") Signed-off-by: Dmitry V. Levin --- ChangeLog| 4 configure.ac | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 71e80a25..563af0d2 100644 --- a/Chang

[PATCH] Remove unused Makefile variable GCC_INCLUDE

2020-12-10 Thread Dmitry V. Levin
It appears to be unused since the first commit in the revision history. Signed-off-by: Dmitry V. Levin --- libasm/ChangeLog | 4 libasm/Makefile.am | 1 - libelf/ChangeLog | 4 libelf/Makefile.am | 2 +- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libasm

Re: [PATCH] Fix automake warnings

2020-12-10 Thread Dmitry V. Levin
On Thu, Dec 10, 2020 at 12:28:35PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, 2020-12-10 at 13:30 +0300, Dmitry V. Levin wrote: > > On Thu, Dec 10, 2020 at 11:09:21AM +0100, Mark Wielaard wrote: > > > Very nice. I have one small issue, with automake 1.13.4 whe

[PATCH] Fix automake warnings

2020-12-09 Thread Dmitry V. Levin
to noinst_DATA and removing no longer needed lib{asm,dw,elf}_so_SOURCES variables. Reported-by: Mark Wielaard Fixes: 2f02e8151094 ("Drop $(EXEEXT) suffix from shared libraries") Signed-off-by: Dmitry V. Levin --- libasm/ChangeLog | 5 + libasm/Makefile.am | 3 +-- libdw/Change

Re: [PATCH] Drop $(EXEEXT) suffix from shared libraries

2020-12-09 Thread Dmitry V. Levin
On Wed, Dec 09, 2020 at 11:42:44PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, 2020-12-10 at 01:20 +0300, Dmitry V. Levin wrote: > > OK, there was no mystery at all: > > > > $ git grep '_PROGRAMS.*_LIBRARIES' > > libasm/Makefile.am:noinst_PROGRAM

Re: [PATCH] Drop $(EXEEXT) suffix from shared libraries

2020-12-09 Thread Dmitry V. Levin
On Thu, Dec 10, 2020 at 01:04:14AM +0300, Dmitry V. Levin wrote: > On Wed, Dec 09, 2020 at 08:55:23PM +0100, Mark Wielaard wrote: > > On Sun, 2020-12-06 at 12:49 +0100, Mark Wielaard wrote: > > > On Mon, 2020-11-30 at 21:35 +0100, Mark Wielaard wrote: > > > > On M

Re: [PATCH] Drop $(EXEEXT) suffix from shared libraries

2020-12-09 Thread Dmitry V. Levin
On Wed, Dec 09, 2020 at 08:55:23PM +0100, Mark Wielaard wrote: > On Sun, 2020-12-06 at 12:49 +0100, Mark Wielaard wrote: > > On Mon, 2020-11-30 at 21:35 +0100, Mark Wielaard wrote: > > > On Mon, Nov 30, 2020 at 08:00:00AM +0000, Dmitry V. Levin wrote: > > >

Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

2020-12-09 Thread Dmitry V. Levin
Hi, On Mon, Nov 09, 2020 at 09:57:57AM -0500, Frank Ch. Eigler via Elfutils-devel wrote: > Hi - > > > [...] The problem with doing the dlopen late is that we also need > > libcurl and initializing libcurl (as done by libdebuginfod) is not > > thread-safe. > > From reading libcurl code, and

Re: [PATCH v3 2/3] debuginfod: create libdebuginfod.so.1 before libdebuginfod.so

2020-12-08 Thread Dmitry V. Levin
On Wed, Dec 09, 2020 at 03:13:12AM +0300, Dmitry V. Levin wrote: > This would allow to switch from "libdebuginfod-" VERSION ".so" > to DEBUGINFOD_SONAME in __libdwfl_debuginfod_init, and to remove the > fall back to dlopen of "libdebuginfod.so" which is

[PATCH v3 3/3] libdwfl: switch to DEBUGINFOD_SONAME, remove libdebuginfod.so fallback

2020-12-08 Thread Dmitry V. Levin
Since DEBUGINFOD_SONAME is as good as ("libdebuginfod-" VERSION ".so") for dlopen, switch to use the name which is a part of the API. Given that DEBUGINFOD_SONAME is always available now, remove the no longer needed fall back to dlopen of "libdebuginfod.so".

[PATCH v3 2/3] debuginfod: create libdebuginfod.so.1 before libdebuginfod.so

2020-12-08 Thread Dmitry V. Levin
This would allow to switch from "libdebuginfod-" VERSION ".so" to DEBUGINFOD_SONAME in __libdwfl_debuginfod_init, and to remove the fall back to dlopen of "libdebuginfod.so" which is no longer needed. Signed-off-by: Dmitry V. Levin --- debuginfod/ChangeLog | 5

[PATCH v3 1/3] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-08 Thread Dmitry V. Levin
Add DEBUGINFOD_SONAME macro to API for use by those of libdebuginfod clients that would like to dlopen the library in the same way as __libdwfl_debuginfod_init does. Signed-off-by: Dmitry V. Levin --- ChangeLog| 5 + configure.ac

Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-08 Thread Dmitry V. Levin
Hi Mark, On Wed, Dec 09, 2020 at 12:07:04AM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Tue, Dec 08, 2020 at 06:15:40PM +0300, Dmitry V. Levin wrote: > > On Tue, Dec 08, 2020 at 01:02:41PM +0100, Mark Wielaard wrote: > > > On Sun, 2020-12-06 at 15:28 +030

Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-08 Thread Dmitry V. Levin
On Tue, Dec 08, 2020 at 01:02:41PM +0100, Mark Wielaard wrote: > On Sun, 2020-12-06 at 15:28 +0300, Dmitry V. Levin wrote: > > On Sun, Dec 06, 2020 at 01:06:42PM +0100, Mark Wielaard wrote: [...] > > > Finally, I am actually using the Makefile VERSION variable in a > > &g

[PATCH v2 4/3] debuginfod: create libdebuginfod files using a race-free method

2020-12-06 Thread Dmitry V. Levin
/ChangeLog index 27abdfda..03eabb6b 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,5 +1,9 @@ 2020-12-06 Dmitry V. Levin + * Makefile.am [LIBDEBUGINFOD]: Create the fully versioned + libdebuginfod file name first, turn the soname and libdebuginfod.so

[PATCH v2 3/3] libdwfl: do not fall back to dlopen of libdebuginfod.so

2020-12-06 Thread Dmitry V. Levin
The fully versioned libdebuginfod file name should always be available. Signed-off-by: Dmitry V. Levin --- libdwfl/ChangeLog | 5 + libdwfl/debuginfod-client.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index

[PATCH v2 2/3] debuginfod: create the fully versioned libdebuginfod file name during build

2020-12-06 Thread Dmitry V. Levin
When the fully versioned file name is available, the fall back to dlopen of "libdebuginfod.so" in __libdwfl_debuginfod_init is no longer needed. Signed-off-by: Dmitry V. Levin --- debuginfod/ChangeLog | 7 +++ debuginfod/Makefile.am | 10 ++ 2 files changed, 13 insert

  1   2   >