Re: rfc/patch: user-agent distro-description for debuginfod http traffic

2020-01-09 Thread Frank Ch. Eigler
Hi - > > > We do want a reproducible build. > > > > Can you give an example? Bootstrapping a new distro version/arch? > > Probably best explained at https://reproducible-builds.org/ most > distributions are participating. (I understood that part, just not how you thought build-time literals

Re: rfc/patch: user-agent distro-description for debuginfod http traffic

2020-01-08 Thread Mark Wielaard
Hi Frank, On Wed, Jan 08, 2020 at 10:11:25AM -0500, Frank Ch. Eigler wrote: > > Eep. We really should pick up this info during runtime instead of > > during build time. > > That's what I thought at first too. However, doing it at run time > means doing work - a popen() etc. - over and over or

Re: rfc/patch: user-agent distro-description for debuginfod http traffic

2020-01-08 Thread Frank Ch. Eigler
Hi - > Eep. We really should pick up this info during runtime instead of > during build time. That's what I thought at first too. However, doing it at run time means doing work - a popen() etc. - over and over or saving in a locked global. Since on a normal machine, the distro doesn't change

Re: rfc/patch: user-agent distro-description for debuginfod http traffic

2020-01-08 Thread Mark Wielaard
Hi Frank, On Mon, 2020-01-06 at 04:53 -0500, Frank Ch. Eigler wrote: > +debuginfod-client-useragent.h: > + if type uname 2>/dev/null; then \ > + echo '#define DEBUGINFOD_CLIENT_USERAGENT_1 "'`uname -sm | sed > -e 's, ,/,g'`'"' > $@; \ > + else \ > + echo '#define

Re: rfc/patch: user-agent distro-description for debuginfod http traffic

2020-01-07 Thread Frank Ch. Eigler
Hi - > Should this add quoting to make the field boundaries unforgeable? I'm thinking of adding a second output stream later on, for machine consumption, with that info carefully quoted. - FChE

Re: rfc/patch: user-agent distro-description for debuginfod http traffic

2020-01-07 Thread Florian Weimer
* Frank Ch. Eigler: > - return string(hostname) + string(":") + string(servname); > + // extract headers relevant to administration > + const char* user_agent = MHD_lookup_connection_value (conn, > MHD_HEADER_KIND, "User-Agent") ?: ""; > + const char* x_forwarded_for =

rfc/patch: user-agent distro-description for debuginfod http traffic

2020-01-06 Thread Frank Ch. Eigler
Hi - commit 53aac40e9577168b886dfeecb77e5a72d2666fc9 (HEAD -> fche/debuginfod-useragent, origin/fche/debuginfod-useragent) Author: Frank Ch. Eigler Date: Mon Jan 6 04:29:21 2020 -0500 debuginfod: pass a distro-summary User-Agent request header It may be useful for a debuginfod