Re: [PATCH] Do not depend on non-POSIX features

2016-10-12 Thread Mark Wielaard
Hi, I am no fan of redefining/open coding things which reasonable can be expected to be provided through normal GNU system headers/libs. But these seem fairly minor. However if there are larger changes needed we should probably pull in the relevant gnulib modules. I added ChangeLog entries and

Re: [PATCH] Do not depend on non-POSIX features

2016-10-12 Thread Mark Wielaard
On Wed, 2016-10-12 at 16:22 +0200, Mark Wielaard wrote: > I am no fan of redefining/open coding things which reasonable can be > expected to be provided through normal GNU system headers/libs. But > these seem fairly minor. However if there are larger changes needed we > should probably pull in

Re: [PATCH] lib: Provide MAX and MIN in system.h

2016-10-12 Thread Mark Wielaard
On Tue, 2016-10-11 at 23:06 +0900, Akihiko Odaki wrote: > This change also creates a new header file libeu.h to provide the > prototypes for the function of libeu. That hides the definition of function > crc32, which can conflict with zlib, from libelf. It also prevents mistakes > to refer those

[PATCH v2] Do not depend on some non-POSIX features.

2016-10-12 Thread Akihiko Odaki
Define/open code memrchr, rawmemchr, powerof2 and TEMP_FAILURE_RETRY if not available through system headers. Signed-off-by: Akihiko Odaki Signed-off-by: Mark Wielaard --- ChangeLog | 4 configure.ac | 3 +++