[PATCH] Add fallthrough attributes

2018-02-08 Thread Joshua Watt
Adds the __attribute__ ((fallthrough)) annotation to all the places where switch case fallthrough was occurring. This allows the -Wimplicit-fallthrough warning to be used even after the source has been pre-processed. Signed-off-by: Joshua Watt --- backends/i386_regs.c | 3 +++ backends

[PATCH v2] Add fallthrough attributes

2018-02-08 Thread Joshua Watt
strengthened so that it *only* allows the attribute; comments alone are insufficient. Signed-off-by: Joshua Watt --- backends/aarch64_retval.c| 3 +++ backends/alpha_retval.c | 6 ++ backends/arm_regs.c | 3 +++ backends/arm_retval.c| 3 +++ backends/i386_regs.c

Re: [PATCH v2] Add fallthrough attributes

2018-02-09 Thread Joshua Watt
t/commit/?id=11fdf80b21f2b4 > 0a10687b9a3d16c852b19d512c > > The idea is that those versions of GCC that support > -Wimplicit-fallthrough also have support for the __attribute__ > ((fallthrough)) statement. So they can always be used together. Yes, that is cleaner and makes more sense. I will change my patch to do that. Thanks, Joshua Watt > > Cheers, > > Mark

[PATCH v3] Use fallthrough attribute

2018-02-09 Thread Joshua Watt
FALLBACK macro in case the compiler doesn't support it. Finally, the -Wimplict-fallthrough warning was upgraded to only allow the attribute to satisfy it; a comment alone is no longer sufficient. Signed-off-by: Joshua Watt --- backends/aarch64_retval.c| 2 +- backends/alpha_retval.c