Witold Filipczyk <[EMAIL PROTECTED]> writes:
> Do you think that maintaining 3 versions of ELinks is reasonable?
With this few people hacking on ELinks, I think it would be
better to maintain just one stable and one development branch.
Thus, the ELinks 0.10 branch should be dropped now, and the
E
Alexey Tourbin <[EMAIL PROTECTED]> writes:
> va_start(params, fmt);
> - vasprintf((char **) &buf, fmt, params);
> + rv = vasprintf((char **) &buf, fmt, params);
> + if (rv < 0) {
> + perror("vasprintf");
> + return;
> + }
> va_end(params);
>
---
src/protocol/smb/smb.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/protocol/smb/smb.c b/src/protocol/smb/smb.c
index 62550e3..a7cc0dc 100644
--- a/src/protocol/smb/smb.c
+++ b/src/protocol/smb/smb.c
@@ -627,8 +627,12 @@ smb_protocol_handler(struct c
---
src/util/error.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/src/util/error.c b/src/util/error.c
index 0c2d1cd..8164f82 100644
--- a/src/util/error.c
+++ b/src/util/error.c
@@ -145,13 +145,18 @@ void
elinks_assertm(int x, unsigned char *fmt, ...)
{
gcc warning as follows:
textarea.c: In function 'save_textarea_file':
textarea.c:305: warning: ignoring return value of 'fwrite', declared with
attribute warn_unused_result
Check fwrite() and fclose() return values.
Also unlink temporary file on error conditions.
This routine is now very similar
search.c: In function 'point_intersect':
search.c:828: warning: value computed is not used
search.c:828: warning: value computed is not used
---
src/viewer/text/search.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/viewer/text/search.c b/src/viewer/text/search.c
This is basically to fix gcc warning:
user.c: In function 'save_form_data_to_file':
user.c:243: warning: ignoring return value of 'fwrite', declared with attribute
warn_unused_result
Now fwrite() return value must be checked. But I also noticed that
temporary file is not being freed on error con
osdep.c: In function 'start_thread':
osdep.c:648: warning: ignoring return value of 'write', declared with attribute
warn_unused_result
---
src/osdep/osdep.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/osdep/osdep.c b/src/osdep/osdep.c
index 374b3e5..c5b5408 1
Hello,
I've got a few patches for elinks-0.11 which make it -Wall -Werror
clean against recent gcc-4.1 compiler. Some of them can be applied
to elinks-0.12, too.
charsets.c: In function 'get_translation_table_to_utf_8':
charsets.c:274: warning: value computed is not used
charsets.c:274: warning: