Re: [elinks-dev] Patch for porting Elinks to OpenSolaris

2009-03-16 Thread Muktha Narayan
Hi Kalle, Kalle Olavi Niemitalo wrote: Kalle Olavi Niemitalo writes: However I've now looked at C99 6.7.4p3 and it specifically mentions modifiable objects. So I wonder if we could just put some const in elinks_ulongcat to make the objects unmodifiable. I have pushed this change to

Re: [elinks-dev] Patch for porting Elinks to OpenSolaris

2009-03-14 Thread Kalle Olavi Niemitalo
Kalle Olavi Niemitalo writes: > However I've now looked at C99 6.7.4p3 and it specifically > mentions modifiable objects. So I wonder if we could just put > some const in elinks_ulongcat to make the objects unmodifiable. I have pushed this change to the elinks-0.11 branch and it is included in

Re: [elinks-dev] Patch for porting Elinks to OpenSolaris

2009-03-04 Thread Kalle Olavi Niemitalo
Muktha Narayan writes: > Kalle Olavi Niemitalo wrote: >> Because ELinks is violating a C99 requirement, rather than >> something specific to Sun, I don't think it's right to make an >> exception for the Sun compiler. Instead, we should make the >> functions not inline and measure how that affect

Re: [elinks-dev] Patch for porting Elinks to OpenSolaris

2009-03-04 Thread Mark A. Carlson
Kalle, Is this acceptable? -- mark Muktha Narayan wrote: Hi, Kalle Olavi Niemitalo wrote: "Mark A. Carlson" writes: +#if defined (__SUNPRO_C) +static inline void +#else inline void +#endif load_frames(struct session *ses, struct document_view *doc_view) This looks like

Re: [elinks-dev] Patch for porting Elinks to OpenSolaris

2009-03-03 Thread Muktha Narayan
Hi Kalle, Please let know if the modified patch is acceptable. Regards Muktha Muktha Narayan wrote: Hi, Kalle Olavi Niemitalo wrote: "Mark A. Carlson" writes: +#if defined (__SUNPRO_C) +static inline void +#else inline void +#endif load_frames(struct session *ses, struct document_vie

Re: [elinks-dev] Patch for porting Elinks to OpenSolaris

2009-02-24 Thread Muktha Narayan
Hi, Kalle Olavi Niemitalo wrote: "Mark A. Carlson" writes: +#if defined (__SUNPRO_C) +static inline void +#else inline void +#endif load_frames(struct session *ses, struct document_view *doc_view) This looks like . That bug was repor

Re: [elinks-dev] Patch for porting Elinks to OpenSolaris

2009-02-18 Thread Kalle Olavi Niemitalo
"Mark A. Carlson" writes: > +#if defined (__SUNPRO_C) > +static inline void > +#else > inline void > +#endif > load_frames(struct session *ses, struct document_view *doc_view) This looks like . That bug was reported against ELinks 0.12pre1 though