Re: [elinks-dev] Errors in bittorent

2008-09-06 Thread Kalle Olavi Niemitalo
Witold Filipczyk <[EMAIL PROTECTED]> writes: > + uri = get_uri(uri_string.source, URI_BASE); > + done_string(&uri_string); > + if (!uri) { > + done_bittorrent_peer_connection(peer); > + return BITTORRENT_STATE_OUT_OF_MEM; > + } > + uri->protocol = PROTOC

Re: [elinks-dev] Errors in bittorent

2008-08-30 Thread Witold Filipczyk
On Sat, Aug 30, 2008 at 12:24:40PM +0200, Jonas Fonseca wrote: > Some comments ... > > Witold Filipczyk <[EMAIL PROTECTED]> wrote Sat, Aug 30, 2008: > > commit b589f19b73c65621c0a8582199509f58dbcac09f > > Author: Witold Filipczyk <[EMAIL PROTECTED]> > > AuthorDate: Sat Aug 30 10:52:00 2008 +02

Re: [elinks-dev] Errors in bittorent

2008-08-30 Thread Jonas Fonseca
Some comments ... Witold Filipczyk <[EMAIL PROTECTED]> wrote Sat, Aug 30, 2008: > commit b589f19b73c65621c0a8582199509f58dbcac09f > Author: Witold Filipczyk <[EMAIL PROTECTED]> > AuthorDate: Sat Aug 30 10:52:00 2008 +0200 > Commit: Witold Filipczyk <[EMAIL PROTECTED]> > CommitDate: Sat Aug

Re: [elinks-dev] Errors in bittorent

2008-08-30 Thread Witold Filipczyk
On Fri, Aug 29, 2008 at 10:38:20PM +0200, Witold Filipczyk wrote: > Hi, > I noticed a bug in the bittorent protocol code while trying to get an ISO from > http://torrents.gentoo.org/. > > Here is a fix for it. > 1) Before the uri was put on the stack and the access that uri later > may trash the s

[elinks-dev] Errors in bittorent

2008-08-29 Thread Witold Filipczyk
Hi, I noticed a bug in the bittorent protocol code while trying to get an ISO from http://torrents.gentoo.org/. Here is a fix for it. 1) Before the uri was put on the stack and the access that uri later may trash the stack. 2) done_uri expects that uri->string is not NULL, so uri->string points to