Re: [elinks-dev] [PATCH] make test fails

[Simon Ruderich]

On Sun, Jul 25, 2010 at 07:09:25PM +0300, أحمد المحمودي wrote:
> Hello,
>
>   I'm not sure if I sent this patch before, anyways, make test fails at
>   some parts due to missing includes and so, the included patch fixes
>   the issue.

Hi,

make test still fails for me. This patch should fix it.

Thanks,
Simon
---
 src/protocol/test/stub.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/protocol/test/stub.c b/src/protocol/test/stub.c
index 313d8c8..90370e2 100644
--- a/src/protocol/test/stub.c
+++ b/src/protocol/test/stub.c
@@ -118,5 +118,5 @@ void
 mailcap_protocol_handler(struct connection *conn)
 {
stub_called("mailcap_protocol_handler");
-   return NULL;
+   return;
 }
-- 
1.7.2

-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9


pgptO8ddbS1cY.pgp
Description: PGP signature
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

[elinks-dev] [PATCH] make test fails

[أحمد المحمودي]

Hello,

  I'm not sure if I sent this patch before, anyways, make test fails at 
  some parts due to missing includes and so, the included patch fixes 
  the issue.

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7
Description: Fixes to make test target to work
Author: أحمد المحمودي (Ahmed El-Mahmoudy) 
--- a/src/mime/backend/Makefile
+++ b/src/mime/backend/Makefile
@@ -11,7 +11,7 @@
 
 # The dependencies are a bit funny here! I don't know why. Just remember to
 # make clean before making the test. --jonas
-mailcap-cache.o: mailcap.c
+mailcap-cache.o: $(top_srcdir)/src/mime/backend/mailcap.c
 	$(call cmd,compile,-DTEST_MAILCAP)
 
 TESTDEPS = \
--- a/src/protocol/test/stub.c
+++ b/src/protocol/test/stub.c
@@ -9,6 +9,7 @@
 
 #include "elinks.h"
 
+#include "protocol/file/mailcap.h"
 #include "bfu/msgbox.h"
 #include "main/module.h"
 #include "protocol/user.h"
@@ -61,6 +62,7 @@
 	protocol_external_handler_T name /* consume semicolon */
 STUB_PROTOCOL_HANDLER(about_protocol_handler);
 STUB_PROTOCOL_HANDLER(bittorrent_protocol_handler);
+STUB_PROTOCOL_HANDLER(bittorrent_peer_protocol_handler);
 STUB_PROTOCOL_HANDLER(data_protocol_handler);
 STUB_PROTOCOL_EXTERNAL_HANDLER(ecmascript_protocol_handler);
 STUB_PROTOCOL_HANDLER(file_protocol_handler);
@@ -111,3 +113,10 @@
 	return NULL;
 }
 
+/* declared in "protocol/file/mailcap.h" */
+void
+execute_mailcap(struct connection *conn)
+{
+	stub_called("execute_mailcap");
+	return NULL;
+}
--- a/src/protocol/test/uri-test.c
+++ b/src/protocol/test/uri-test.c
@@ -3,6 +3,7 @@
 #endif
 
 #include 
+#include 
 
 #include "elinks.h"
 
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev