Re: [elixir-core:11420] Re: [Proposal] Pretty print diff when matching on context fails in ExUnit

2023-05-28 Thread José Valim
We already have an opt-in Exception.blame mechanism that is only used in certain scenarios (like Plug Debugger, ExUnit, and so on) and this would be done as part of Exception.blame, so it won't run all the time, which should alleviate both performance and security concerns. On Sun, May 28, 2023

Re: [elixir-core:11420] Re: [Proposal] Pretty print diff when matching on context fails in ExUnit

2023-05-28 Thread Ben Wilson
That would be lovely as well. My main question there is if there are performance concerns invoking the formatter in such cases? I can't imagine it'd be an issue for test failures, but general pattern match exceptions seem like they might be more sensitive to such things. And possibly a