Re: [elixir-core:11683] [Proposal] Add `shift/2-3` to calendar types

2024-03-06 Thread José Valim
Compatibility with the other time units is an important point. My mind is back on singular again. :) On Thu, Mar 7, 2024 at 07:20 'Theo Fiedler' via elixir-lang-core < elixir-lang-core@googlegroups.com> wrote: > While i was strongly leaning towards singular, i understand why one would > expect

Re: [elixir-core:11683] [Proposal] Add `shift/2-3` to calendar types

2024-03-06 Thread 'Theo Fiedler' via elixir-lang-core
While i was strongly leaning towards singular, i understand why one would expect plural. Given that seems to be pretty standard in wild, i am fine changing it as well. What mostly put me off about was that we'd end up with `Time.add(t, 3, :minute)` vs `Time.shift(t, minutes: 3)`, which after