Re: `define-minor-mode' makes erroneous docstrings.

2005-04-12 Thread Luc Teirlinck
Richerd Stallman wrote: Would it work to try to distinguish by whether the "body" of the define-minor-mode form is empty? I believe that would work. Sincerely, Luc. ___ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/

Re: `define-minor-mode' makes erroneous docstrings.

2005-04-12 Thread Richard Stallman
The docstrings provided by `define-minor-mode' are wrong for many minor-mode variables. They _automatically_ say that setting the variable directly has no effect. I believe that this is wrong for the majority of minor modes. Would it work to try to distinguish by whether the "bod

Re: `define-minor-mode' makes erroneous docstrings.

2005-04-12 Thread Luc Teirlinck
Stefan Monnier wrote: The comment about not setting the variable locally should not be added if the mode is not declared to be global. If the mode is not global, the comment is less explicit, but still says: Use the command `visible-mode' to change this variable. In the case of Visible

Re: `define-minor-mode' makes erroneous docstrings.

2005-04-11 Thread Stefan Monnier
> useful, like for column-number-mode. For local minor modes, you can > enable them globally by setting the default-value of the variable. The comment about not setting the variable locally should not be added if the mode is not declared to be global. Stefan __

Re: `define-minor-mode' makes erroneous docstrings.

2005-04-11 Thread Luc Teirlinck
>From my previous message: Well, setting the variable definitely will run no mode hooks, but who cares. Maybe basic minor modes such as column-number-mode that work by just setting the variable should not be defined using `define-minor-mode' and should not have any useless hooks assoc

Re: `define-minor-mode' makes erroneous docstrings.

2005-04-11 Thread Luc Teirlinck
>From my previous message: As an example here is what you get from `C-h v column-number-mode'. It is definitely wrong, you can set it directly and buffer locally. It works. Well, setting the variable definitely will run no mode hooks, but who cares. Maybe basic minor modes such as colum