> From: Juri Linkov <[EMAIL PROTECTED]>
> Cc: [EMAIL PROTECTED], emacs-devel@gnu.org
> Date: Tue, 12 Jul 2005 09:51:05 +0300
>
> Here is a new patch:
I tried that on a tty. I'm mildly worried about the visibility of
green on (the default) white background: is it possible that it will
stand out t
>> (defface diff-context
>> - '((t :inherit shadow))
>> + 'class color) (min-colors 88)) :inherit shadow))
>>"`diff-mode' face used to highlight context and other side-information."
>>:group 'diff-mode)
>
> Maybe the shadow face should be fixed instead.
The shadow face should be fix
> From: Stefan Monnier <[EMAIL PROTECTED]>
> Date: Mon, 11 Jul 2005 15:46:43 -0400
> Cc: [EMAIL PROTECTED], emacs-devel@gnu.org
>
> >> Maybe the shadow face should be fixed instead.
>
> > Why? It does what it's supposed to do: makes the text barely visible.
>
> Then why isn't it good for the `d
> Cc: Eli Zaretskii <[EMAIL PROTECTED]>, emacs-devel@gnu.org
> From: Stefan Monnier <[EMAIL PROTECTED]>
> Date: Mon, 11 Jul 2005 09:43:07 -0400
>
> Maybe the shadow face should be fixed instead.
Why? It does what it's supposed to do: makes the text barely visible.
>> Cc: Eli Zaretskii <[EMAIL PROTECTED]>, emacs-devel@gnu.org
>> From: Stefan Monnier <[EMAIL PROTECTED]>
>> Date: Mon, 11 Jul 2005 09:43:07 -0400
>>
>> Maybe the shadow face should be fixed instead.
> Why? It does what it's supposed to do: makes the text barely visible.
Then why isn't it good
> (defface diff-context
> - '((t :inherit shadow))
> + 'class color) (min-colors 88)) :inherit shadow))
>"`diff-mode' face used to highlight context and other side-information."
>:group 'diff-mode)
Maybe the shadow face should be fixed instead.
Stefan
___
> This part affects non-TTY platforms, while leaving the TTY colors
> intact. Why? I don't think there's any problem with Diff-mode colors
> on displays that support many colors, are there?
Maybe the following patch is more correct:
Index: lisp/diff-mode.el
=
> From: Juri Linkov <[EMAIL PROTECTED]>
> Cc: emacs-devel@gnu.org
> Date: Sat, 09 Jul 2005 23:56:19 +0300
>
> (defface diff-context
> - '((t :inherit shadow))
> + 'type tty pc) (class color)))
> +(t :inherit shadow))
>"`diff-mode' face used to highlight context and other side-inform
>> Are there any objections to changing context fg/bg to the default fg/bg
>> and file header's yellow foreground to green on light background tty?
>
> Please post the suggested diffs, I'd like to try that before I make up
> my mind about this proposal.
Index: lisp/diff-mode.el
===
>> Are there any objections to changing context fg/bg to the default fg/bg
>
> Yes; that is a bad change. I went into detail in a previous message;
> did you not read it?
Then I don't understand why changing yellow context foreground to the
default black foreground is a bad change if everyone com
2005/7/7, Juri Linkov <[EMAIL PROTECTED]>:
> Are there any objections to changing context fg/bg to the default fg/bg
Yes; that is a bad change. I went into detail in a previous message;
did you not read it?
-Miles
--
Do not taunt Happy Fun Ball.
___
> From: Juri Linkov <[EMAIL PROTECTED]>
> Cc: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED],
> merlyn@stonehenge.com, [EMAIL PROTECTED], emacs-devel@gnu.org
> Date: Wed, 06 Jul 2005 23:53:53 +0300
>
> Are there any objections to changing context fg/bg to the default fg/bg
> and file hea
> Would you please make whatever change you think is good
> for the diff-header face in the case of a light background
> and few colors supported?
Are there any objections to changing context fg/bg to the default fg/bg
and file header's yellow foreground to green on light background tty?
--
Juri
Would you please make whatever change you think is good
for the diff-header face in the case of a light background
and few colors supported?
___
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
2005/7/2, Juri Linkov <[EMAIL PROTECTED]>:
> > The diff-mode colors on a dark-background terminal (gnome-terminal or
> > generic xterm) are:
...
> > These colors work very well and should not be changed
>
> Bold text is unreadable on terminals with small fonts.
I have not found this to be the cas
>> Something has to be done about colors of diff context, because
>> currently it is white on black for dark backgrounds, and yellow
>> on white for light backgrounds.
>
> The diff-mode colors on a dark-background terminal (gnome-terminal or
> generic xterm) are:
>
>Changed lines: yellow+bold
>> On TTY it classifies colors as follows:
>>
>> Dark: black red green blue
>> Light: magenta yellow cyan white
>>
>> But on xterm it is quite different:
>>
>> Dark: black red green blue magenta yellow cyan
>> Light: white
>>
>> That anomaly could be worth fixing.
>
>
> According to this classification, yellow is a dark color,
> as it were suitable as a foreground color for light backgrounds.
>
> I think that is a non-issue. Emacs never chooses foreground colors
> based on such a classification. The only thing Eacs does based on
> this classification i
> From: "Richard M. Stallman" <[EMAIL PROTECTED]>
> CC: [EMAIL PROTECTED], [EMAIL PROTECTED], emacs-devel@gnu.org,
> merlyn@stonehenge.com
> Date: Thu, 30 Jun 2005 17:30:23 -0400
>
> On TTY it classifies colors as follows:
>
> Dark: black red green blue
> Light: magenta yellow
Something has to be done about colors of diff context, because
currently it is white on black for dark backgrounds, and yellow
on white for light backgrounds.
I don't see any face in diff-mode.el that produces yellow-on-white.
So I don't understand what specific behavior you're talking
On TTY it classifies colors as follows:
Dark: black red green blue
Light: magenta yellow cyan white
But on xterm it is quite different:
Dark: black red green blue magenta yellow cyan
Light: white
That anomaly could be worth fixing.
According to this classification
> "Juri" == Juri Linkov <[EMAIL PROTECTED]> writes:
Juri> Something has to be done about colors of diff context, because
Juri> currently it is white on black for dark backgrounds, and yellow
Juri> on white for light backgrounds.
Yes, my original complaint. :)
--
Randal L. Schwartz - Stonehe
On 6/28/05, Juri Linkov <[EMAIL PROTECTED]> wrote:
> Something has to be done about colors of diff context, because
> currently it is white on black for dark backgrounds, and yellow
> on white for light backgrounds.
The diff-mode colors on a dark-background terminal (gnome-terminal or
generic xter
>For quite a long time (most likely from the time when color translation
>was implemented for tty) colors of context lines in diff mode on tty
>were yellow for light backgrounds. There are also other faces with
>yellow foreground for light backgrounds, like font-lock-variable-name-
> From: Juri Linkov <[EMAIL PROTECTED]>
> Date: Mon, 20 Jun 2005 07:48:08 +0300
> Cc: emacs-devel@gnu.org
>
> > First, it calls an obsolete function frame-update-face-colors (it's an
> > alias for backward compatibility; let's use the function it is aliased
> > to).
>
> Then it would be better to
> First, it calls an obsolete function frame-update-face-colors (it's an
> alias for backward compatibility; let's use the function it is aliased
> to).
Then it would be better to rename it in all C files to not create
Lisp symbols in C for both of them.
> Second, I think doing this unconditional
BTW, font-lock-comment-delimiter-face as well as
font-lock-negation-char-face
are very new faces, so it's better to remove the -face suffix from them now
than to create aliases for backward compatibility later after the release.
Maybe, but currently all the faces defined by font-lock
On 6/19/05, Juri Linkov <[EMAIL PROTECTED]> wrote:
> By default on terminals Emacs background mode is `light', regardless of
> actual terminal background color, so you don't need to change the
> background mode when the main text is black on white.
No -- by default the background mode is `dark' on
> From: Juri Linkov <[EMAIL PROTECTED]>
> Cc: merlyn@stonehenge.com, emacs-devel@gnu.org
> Date: Sun, 19 Jun 2005 16:09:47 +0300
>
> I see there is one problem with background-mode on tty. Unlike X,
> on tty Emacs doesn't adjust background-mode after changing the
> background color with any of th
> "Luc" == Luc Teirlinck <[EMAIL PROTECTED]> writes:
Luc> I remember seeing people complain that they have trouble reading
Luc> yellow on white _many_ times on this list.
Yup.
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
http://www.stonehenge.com/merlyn/>
Juri Linkov wrote:
> Juri> Yellow foreground works well for context lines.
>
> Except when you normally read black on white.
For quite a long time (most likely from the time when color translation
was implemented for tty) colors of context lines in diff mode on tty
were yellow f
BTW, font-lock-comment-delimiter-face as well as font-lock-negation-char-face
are very new faces, so it's better to remove the -face suffix from them now
than to create aliases for backward compatibility later after the release.
--
Juri Linkov
http://www.jurta.org/emacs/
__
> Juri> Yellow foreground works well for context lines.
>
> Except when you normally read black on white.
For quite a long time (most likely from the time when color translation
was implemented for tty) colors of context lines in diff mode on tty
were yellow for light backgrounds. There are also
>> Cc: Eli Zaretskii <[EMAIL PROTECTED]>, emacs-devel@gnu.org
>> From: merlyn@stonehenge.com (Randal L. Schwartz)
>> Date: 18 Jun 2005 08:27:12 -0700
>>
>> Is there no way to switch automatically to a proper set of darker
>> colors when the main text is black instead of white?
>
> Yes, it's called
Then could you explain the reasons for removing comments highlighting
on tty with leaving only comment delimiters highlighted.
I explained them a few weeks ago.
I see no big difference between comments displayed in red and diff lines
displayed in bold italic magenta (the latter lo
> Cc: Eli Zaretskii <[EMAIL PROTECTED]>, emacs-devel@gnu.org
> From: merlyn@stonehenge.com (Randal L. Schwartz)
> Date: 18 Jun 2005 08:27:12 -0700
>
> Is there no way to switch automatically to a proper set of darker
> colors when the main text is black instead of white?
Yes, it's called backgrou
> "Juri" == Juri Linkov <[EMAIL PROTECTED]> writes:
Juri> Yellow foreground works well for context lines.
Except when you normally read black on white. Is there no way to
switch automatically to a proper set of darker colors when the main
text is black instead of white?
--
Randal L. Schwar
> I don't find the current Diff mode setup hard to use on a tty.
> That is perhaps because the font used for the changed lines
> is not hard to read.
Then could you explain the reasons for removing comments highlighting
on tty with leaving only comment delimiters highlighted.
I see no big differe
>> The default diff face used to highlight changed lines on tty
>> (magenta/yellow bold italic) makes an indigestible fruit salad.
>
> In your opinion, perhaps. These faces are there since 5 years ago,
> and I don't recall anyone complaining.
Maybe people prefer to quietly customize faces in .ema
> The "^#.*" pattern is meant to match "comment lines". These are
> part of an extension of the diff format. It has nothing to do with
> the -D option which I do not consider as outputting a diff format
> and diff-mode does not support this output format in any way.
Since it is meant to match co
I don't find the current Diff mode setup hard to use on a tty.
That is perhaps because the font used for the changed lines
is not hard to read.
___
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
> With -D option diff makes `#ifdef' format output with conditional
> preprocessor directives. Currently diff-mode.el uses hard-coded
> font-lock-string-face to highlight them. The patch adds a new face
> to allow users to configure it. By default, it inherits from
> font-lock-preprocessor-face.
Juri Linkov wrote:
I propose instead of highlighting whole lines on tty to use at least
the same approach as introduced recently for comments on tty to highlight
only comment delimiters in new face font-lock-comment-delimiter-face.
Similarly, only diff indicators (the first character of the line
> From: Juri Linkov <[EMAIL PROTECTED]>
> Date: Fri, 17 Jun 2005 14:47:05 +0300
>
> The default diff face used to highlight changed lines on tty
> (magenta/yellow bold italic) makes an indigestible fruit salad.
In your opinion, perhaps. These faces are there since 5 years ago,
and I don't recall
44 matches
Mail list logo
